From: H Hartley Sweeten <hartleys@visionengravers.com>
To: Mika Westerberg <mika.westerberg@iki.fi>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "vinod.koul@intel.com" <vinod.koul@intel.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"rmallon@gmail.com" <rmallon@gmail.com>,
Rafal Prylowski <prylowski@metasoft.pl>
Subject: RE: [PATCH v2 2/2] dma/ep93xx_dma: prevent ep93xx_dma_tasklet() to reference an empty list
Date: Mon, 28 Nov 2011 11:33:04 -0600 [thread overview]
Message-ID: <ADE657CA350FB648AAC2C43247A983F001F3E96DACDC@AUSP01VMBX24.collaborationhost.net> (raw)
In-Reply-To: <e3de259ed9d1b39ee9ba9ce681133b126166cbb5.1322304185.git.mika.westerberg@iki.fi>
On Saturday, November 26, 2011 3:54 AM, Mika Westerberg wrote:
>
> If dma_terminate_all() is called before the ep93xx_dma_tasklet() gets to run,
> it tries to access an empty ->active list which results following OOPS:
[OOPS snipped...]
> To make the code a bit more robust against things like these, we modify
> ep93xx_dma_get_active() to return NULL in case of empty ->active list and make
> sure that callers handle this correctly.
>
> Reported-by: Rafal Prylowski <prylowski@metasoft.pl>
> Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi>
> ---
> drivers/dma/ep93xx_dma.c | 60 ++++++++++++++++++++++++++++++++++++---------
> 1 files changed, 48 insertions(+), 12 deletions(-)
Looks good. Thanks.
Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
next prev parent reply other threads:[~2011-11-28 17:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-26 10:54 [PATCH v2 1/2] dma/ep93xx_dma: fix initialization of M2M control register Mika Westerberg
2011-11-26 10:54 ` [PATCH v2 2/2] dma/ep93xx_dma: prevent ep93xx_dma_tasklet() to reference an empty list Mika Westerberg
2011-11-28 17:33 ` H Hartley Sweeten [this message]
2011-12-05 2:48 ` [PATCH v2 1/2] dma/ep93xx_dma: fix initialization of M2M control register Vinod Koul
2011-12-06 11:59 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ADE657CA350FB648AAC2C43247A983F001F3E96DACDC@AUSP01VMBX24.collaborationhost.net \
--to=hartleys@visionengravers.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@iki.fi \
--cc=prylowski@metasoft.pl \
--cc=rmallon@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®