From: Segher Boessenkool <segher@kernel.crashing.org>
To: Richard Henderson <rth@twiddle.net>
Cc: Matt Turner <mattst88@gmail.com>,
Oliver Falk <oliver@linux-kernel.at>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
linux-alpha@vger.kernel.org, Jay Estabrook <jay.estabrook@hp.com>
Subject: Re: alpha: half done futex implementation
Date: Tue, 14 Apr 2009 11:40:50 +0200 [thread overview]
Message-ID: <AE456C27-B568-4835-8843-F2A2E2D8FC32@kernel.crashing.org> (raw)
In-Reply-To: <49E39F3D.4060501@twiddle.net>
> Also, there's a bug in the powerpc implementation. It appears that
> oparg is clobbered, and if stwcx fails the operation will be
> repeated with incorrect inputs.
If either the lwarx or the stwcx. faults, the routine returns -EFAULT
and doesn't retry (label "3" is the end of the asm).
If the stwcx. fails because the CPU lost the reservation, %1 isn't
clobbered as far as I see?
Segher
next prev parent reply other threads:[~2009-04-14 9:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-12 0:55 Matt Turner
2009-04-12 13:49 ` Tobias Klausmann
2009-04-13 20:23 ` Richard Henderson
2009-04-13 21:54 ` Andreas Schwab
2009-04-13 22:20 ` Richard Henderson
2009-04-14 9:40 ` Segher Boessenkool [this message]
2009-04-14 9:45 ` Segher Boessenkool
2009-04-14 22:38 ` Matt Turner
2009-04-15 15:42 ` Ivan Kokshaysky
2009-04-16 22:06 ` Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AE456C27-B568-4835-8843-F2A2E2D8FC32@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=ink@jurassic.park.msu.ru \
--cc=jay.estabrook@hp.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mattst88@gmail.com \
--cc=oliver@linux-kernel.at \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®