From: Arthur Cassegrain <Arthur.Cassegrain@arm.com>
To: Shuah Khan <shuah@kernel.org>
Cc: "linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
NeilBrown <neilb@ownmail.net>,
Vincent Mailhol <Vincent.Mailhol@arm.com>
Subject: Re: [PATCH RESEND] selftests/filesystems: include fcntl.h in fclog
Date: Thu, 10 Sep 2026 09:39:32 +0000 [thread overview]
Message-ID: <AM0PR08MB4402874569C5F506F332CC02F9BF2@AM0PR08MB4402.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20260910-fclog-fix-include-v1-1-b72bb03eb998@arm.com>
> fclog.c uses open(), O_RDONLY, O_CLOEXEC and AT_FDCWD, but it does
> not include <fcntl.h>, where they are declared or defined.
>
> This was hidden while <sys/mount.h> pulled in <fcntl.h> indirectly.
> glibc stopped providing that transitive include in [1], which exposes
> the missing direct dependency.
>
> Include <fcntl.h> explicitly so fclog.c builds with glibc 2.44
> development headers.
>
> [1] glibc -- change 419245719ccb ("include: isolate __O_CLOEXEC flag for
> sys/mount.h and fcntl.h")
> Link: https://sourceware.org/git/?p=glibc.git;a=commit;h=419245719ccb
>
> Fixes: df579e471111 ("selftests/filesystems: add basic fscontext log tests")
> Reported-by: NeilBrown <neilb@ownmail.net>
> Closes: https://lore.kernel.org/all/178331747789.27465.4739600418387513587@noble.neil.brown.name/
> Signed-off-by: Arthur Cassegrain <arthur.cassegrain@arm.com>
> ---
Sorry, I just realized that this fix has already been merged:
https://lore.kernel.org/all/20260710171741.837308-1-jkoolstra@xs4all.nl/
Please ignore this resend.
Thanks,
Arthur
prev parent reply other threads:[~2026-09-10 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 9:14 Arthur Cassegrain
2026-09-10 9:39 ` Arthur Cassegrain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR08MB4402874569C5F506F332CC02F9BF2@AM0PR08MB4402.eurprd08.prod.outlook.com \
--to=arthur.cassegrain@arm.com \
--cc=Vincent.Mailhol@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=neilb@ownmail.net \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®