From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932589AbcDMCld (ORCPT ); Tue, 12 Apr 2016 22:41:33 -0400 Received: from mail-db3on0081.outbound.protection.outlook.com ([157.55.234.81]:48687 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751648AbcDMCla convert rfc822-to-8bit (ORCPT ); Tue, 12 Apr 2016 22:41:30 -0400 From: Yao Yuan To: Shawn Guo , Yuan Yao CC: "robh+dt@kernel.org" , "mark.rutland@arm.com" , "computersforpeace@gmail.com" , "pawel.moll@arm.com" , "Han Xu" , Yang-Leo Li , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH 2/2] dts/ls1043a: add the DTS node for QSPI support Thread-Topic: [PATCH 2/2] dts/ls1043a: add the DTS node for QSPI support Thread-Index: AQHRixonyDxphW4y/EmD1+4S11l81J+Ftb6AgAGN1hA= Date: Wed, 13 Apr 2016 02:41:27 +0000 Message-ID: References: <1459406701-40993-1-git-send-email-yao.yuan@freescale.com> <1459406701-40993-3-git-send-email-yao.yuan@freescale.com> <20160412024947.GD15949@tiger> In-Reply-To: <20160412024947.GD15949@tiger> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=nxp.com; x-originating-ip: [123.151.195.51] x-ms-office365-filtering-correlation-id: 529e72c5-ed1d-4c1e-78a2-08d363451cb0 x-microsoft-exchange-diagnostics: 1;AM2PR04MB0772;5:sMRN6m0QjkenUE4524CB0SrE93gfmQbcSOmC8CIbZLaUFT/GO6Am1l9HQQL7WMbTeCRaX/AWbuYg8ubl0/ZS9YPCdjYCG5fA9Jw9IvALU0X6oYVLrlsDxzM/Mm1j06hI2w0RV2DwXk585JL5aLJzog==;24:sxAD+xMQNo77PJ0pvhO+wobs/9riQ1s/HMu9kZPbGpDTZDfrsZR/f519nClJ4kJkTIcAyHD4PaYFA3G1zDaL59e17GQ+7PvIaju8Nxnuh2w= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM2PR04MB0772; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:AM2PR04MB0772;BCL:0;PCL:0;RULEID:;SRVR:AM2PR04MB0772; x-forefront-prvs: 0911D5CE78 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(1096002)(586003)(6116002)(3846002)(3660700001)(102836003)(4326007)(77096005)(1720100001)(2900100001)(10400500002)(15975445007)(1220700001)(81166005)(9686002)(5003600100002)(5001770100001)(5002640100001)(2950100001)(11100500001)(50986999)(5004730100002)(3280700002)(189998001)(76176999)(54356999)(92566002)(2906002)(33656002)(19580395003)(122556002)(66066001)(76576001)(19580405001)(74316001)(5008740100001)(106116001)(86362001)(87936001)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:AM2PR04MB0772;H:AM2PR04MB0722.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2016 02:41:27.3186 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0772 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 12, 2016 at 10:50:01AM +0800, Shawn Guo wrote: > On Thu, Mar 31, 2016 at 02:45:01PM +0800, Yuan Yao wrote: > > From: Yuan Yao > > > > Signed-off-by: Yuan Yao > > Please style of 'arm64: dts: ls1043a: ' for subject prefix. > > > --- > > arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 16 ++++++++++++++++ > > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 14 ++++++++++++++ > > 2 files changed, 30 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts > > b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts > > index 97e9906..c8303a3 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts > > @@ -100,6 +100,22 @@ > > }; > > }; > > > > +&qspi { > > Please sort such labeled node alphabetically in label name. That said, it should > go after &lpuart0. Ok, Thanks. > > + num-cs = <2>; > > I do not see this property in bindings doc. We can find this property in ./Documentation/devicetree/bindings/spi/spi-bus.txt > > > + bus-num = <0>; > > + status = "okay"; > > Please let 'status' line be the last of property list. Ok, Thanks. > > + fsl,ddr-sampling-point = <4>; > > I do not see this one in bindings definition either. It's used for DDR mode; The DDR mode will send to upstream late. So I will remove this, once the DDR mode patch is merged, I will send patch to add the property. > > > + > > + qflash0: s25fl128s@0 { > > + compatible = "spansion,m25p80"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + spi-max-frequency = <20000000>; > > + ddr-quad-read; > > Ditto Ditto, Thanks. > > > + reg = <0>; > > + }; > > +}; > > + > > &i2c0 { > > status = "okay"; > > pca9547@77 { > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > index be72bf5..49b1aeb 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > > @@ -208,6 +208,20 @@ > > status = "disabled"; > > }; > > > > + qspi: quadspi@1550000 { > > Please sort the node in .dtsi in order of unit-address. That said, the node > should be added between ifc@1530000 and esdhc@1560000. Thanks. I will update it and resend it soon. > Shawn > > > + compatible = "fsl,ls1043a-qspi", "fsl,ls1021a-qspi"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0x0 0x1550000 0x0 0x10000>, > > + <0x0 0x40000000 0x0 0x4000000>; > > + reg-names = "QuadSPI", "QuadSPI-memory"; > > + interrupts = <0 99 0x4>; > > + clock-names = "qspi_en", "qspi"; > > + clocks = <&clockgen 4 0>, <&clockgen 4 0>; > > + big-endian; > > + status = "disabled"; > > + }; > > + > > i2c0: i2c@2180000 { > > compatible = "fsl,vf610-i2c"; > > #address-cells = <1>; > > -- > > 2.1.0.27.g96db324 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > >