From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755029AbcBBLoq (ORCPT ); Tue, 2 Feb 2016 06:44:46 -0500 Received: from mail-db3on0079.outbound.protection.outlook.com ([157.55.234.79]:8872 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754299AbcBBLoo convert rfc822-to-8bit (ORCPT ); Tue, 2 Feb 2016 06:44:44 -0500 From: Yao Yuan To: Shawn Guo , Yuan Yao CC: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH] dts/ls1021a: add the DTS for QSPI support Thread-Topic: [PATCH] dts/ls1021a: add the DTS for QSPI support Thread-Index: AQHRWae7Tjq+woL2j06p+xfn0KtseJ8YaROAgAA29QA= Date: Tue, 2 Feb 2016 11:10:41 +0000 Message-ID: References: <1453970006-46509-1-git-send-email-yao.yuan@freescale.com> <20160202074907.GK8307@tiger> In-Reply-To: <20160202074907.GK8307@tiger> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=nxp.com; x-originating-ip: [199.59.230.102] x-microsoft-exchange-diagnostics: 1;AM2PR04MB0722;5:dezBDZQqJh2NXTnIMGgMdIabziq8qRCI4b65+iK0DK24B8BB5q6ADD1vJJvYjo9DkrYteFbxpJ018ruAWPiyA3EFUa5dVq+NB3Y4ZXh3l5cVO06mACOOWIrRWfWRWysmFwiehB6E77Z6TxRFzSLdFA==;24:iyc2uGVG2orODvJ1bzxlETCPv4rEoIJ45/ugNb//RlNEpxnx4UW0J4th83BqVynHxnqQQIjoaVbQR7K9kfQ+4jOl8BLsiB5yXQaZcWUko0Y= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM2PR04MB0722; x-ms-office365-filtering-correlation-id: ba74bd30-35f0-4e75-b805-08d32bc17d31 x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:AM2PR04MB0722;BCL:0;PCL:0;RULEID:;SRVR:AM2PR04MB0722; x-forefront-prvs: 084080FC15 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(2900100001)(15975445007)(87936001)(5001770100001)(74316001)(2950100001)(1096002)(6116002)(33656002)(1220700001)(77096005)(102836003)(3846002)(5001960100002)(10400500002)(189998001)(4326007)(92566002)(122556002)(586003)(3470700001)(2906002)(5002640100001)(5004730100002)(40100003)(3660700001)(3280700002)(5003600100002)(76176999)(19580395003)(76576001)(86362001)(5008740100001)(19580405001)(54356999)(50986999)(106116001)(11100500001)(66066001)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:AM2PR04MB0722;H:AM2PR04MB0722.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2016 11:10:41.5964 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0722 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 02, 2016 at 03:49PM, Shawn Guo wrote: > On Thu, Jan 28, 2016 at 04:33:26PM +0800, Yuan Yao wrote: > > From: Yuan Yao > > > > Signed-off-by: Yuan Yao > > --- > > Add in v1: > > Can merge, but the function depend on the patch: > > https://patchwork.kernel.org/patch/8118251/ > > Please send me dts patch only after the driver part gets applied. Ok, I will resend the patch after the driver part gets applied. I just only want to speed up my upstream. > > > > > mtd: spi-nor: fsl-quadspi: add support for ls1021a > > > > LS1021a also support Freescale Quad SPI controller. > > Add fsl-quadspi support for ls1021a chip and make SPI_FSL_QUADSPI > > selectable for LS1021A SOC hardwares. > > > > --- > > arch/arm/boot/dts/ls1021a.dtsi | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm/boot/dts/ls1021a.dtsi > > b/arch/arm/boot/dts/ls1021a.dtsi index 9430a99..c764fa5 100644 > > --- a/arch/arm/boot/dts/ls1021a.dtsi > > +++ b/arch/arm/boot/dts/ls1021a.dtsi > > @@ -252,6 +252,21 @@ > > status = "disabled"; > > }; > > > > + qspi: quadspi@1550000 { > > + compatible = "fsl,ls1021a-qspi"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0x0 0x1550000 0x0 0x10000>, > > + <0x0 0x40000000 0x0 0x4000000>; > > + reg-names = "QuadSPI", "QuadSPI-memory"; > > + interrupts = ; > > + clock-names = "qspi_en", "qspi"; > > + clocks = <&platform_clk 1>, <&platform_clk 1>; > > + big-endian; > > + amba-base = <0x40000000>; > > What is this property? I cannot find it in any bindings doc. Is it added by your > patches on driver code? Sorry, it's the legacy property, after the latest discussion we will remove this property. So I will remove it in the next version. Thanks for your review. Yuan Yao.