From: Yao Yuan <yao.yuan@nxp.com>
To: Rob Herring <robh@kernel.org>, Yuan Yao <yao.yuan@freescale.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v2 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string
Date: Wed, 30 Dec 2015 03:17:50 +0000 [thread overview]
Message-ID: <AM2PR04MB07228C97A751DA40EEDD231489FD0@AM2PR04MB0722.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20151229183501.GH12450@rob-hp-laptop>
Hi Rob,
Thanks for your review.
So you mean that I should add the commit message for why I add this new compatible?
Best Regards,
Yuan Yao
On Wed, Dec 30, 2015 at 02:35AM, Rob Herring wrote:
> On Thu, Dec 24, 2015 at 07:01:00PM +0800, Yuan Yao wrote:
> > new compatible string: "fsl,ls2080a-qspi".
> >
> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> > ---
> > Changed in v2:
> > Update my email to <yao.yuan@nxp.com>
> > ---
> > Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt
> b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt
> > index fa77f87..2fe51d6 100644
> > --- a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt
> > +++ b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt
> > @@ -1,7 +1,8 @@
> > ARM Freescale DSPI controller
> >
> > Required properties:
> > -- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", "fsl,ls2085a-dspi"
> > +- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi",
> > + "fsl,ls2085a-dspi", "fsl,ls2080a-dspi"
>
> You should explain what combinations of compatible strings are valid.
>
> Rob
next prev parent reply other threads:[~2015-12-30 4:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 11:01 Yuan Yao
2015-12-24 11:01 ` [PATCH v2 2/4] Documentation: fsl-quadspi: Add fsl, ls2080a-qspi " Yuan Yao
2015-12-29 18:34 ` Rob Herring
2015-12-24 11:01 ` [PATCH v2 3/4] dts/ls2080a: update the DTS for QSPI and DSPI support Yuan Yao
2015-12-24 11:01 ` [PATCH 4/4] Documentation: fsl-quadspi: Add optional properties Yuan Yao
2015-12-29 18:34 ` Rob Herring
2015-12-29 18:35 ` [PATCH v2 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string Rob Herring
2015-12-30 3:17 ` Yao Yuan [this message]
2015-12-30 15:19 ` Rob Herring
2015-12-31 2:35 ` Yao Yuan
2016-01-12 4:36 ` Yao Yuan
2016-01-12 22:13 ` Rob Herring
2016-01-18 6:43 ` Yao Yuan
2016-01-20 15:16 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM2PR04MB07228C97A751DA40EEDD231489FD0@AM2PR04MB0722.eurprd04.prod.outlook.com \
--to=yao.yuan@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=yao.yuan@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®