From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753788AbcCHEgv (ORCPT ); Mon, 7 Mar 2016 23:36:51 -0500 Received: from mail-db3on0077.outbound.protection.outlook.com ([157.55.234.77]:11808 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753247AbcCHEgn convert rfc822-to-8bit (ORCPT ); Mon, 7 Mar 2016 23:36:43 -0500 From: Yao Yuan To: Brian Norris CC: "dwmw2@infradead.org" , "han.xu@freescale.com" , "robh@kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v4 4/7] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string Thread-Topic: [PATCH v4 4/7] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string Thread-Index: AQHRWAu3OQsxbRApPEeQm11y/N+0Ip9OsLUAgABaKXA= Date: Tue, 8 Mar 2016 02:03:21 +0000 Message-ID: References: <1453793041-35868-1-git-send-email-yao.yuan@freescale.com> <1453793041-35868-4-git-send-email-yao.yuan@freescale.com> <20160307203200.GW55664@google.com> In-Reply-To: <20160307203200.GW55664@google.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [123.151.195.51] x-microsoft-exchange-diagnostics: 1;AM2PR04MB0721;5:Km4bd8qE8+c5+r691fTbY7yJMs1BWT5T7MafeYT4+0EI+GZ11TjFsq/3fTd7859mPJ+jW3EsWlh54hT31P57n9B8NlyiypgdDNa0DRZm7Bep6un/xGB2GaQWAVK/apop92ZasswbnyIlgaplyUBuNA==;24:BKKNRgKfU2iFOEAO4vuwEojeGUSNQZ0p5kpJBN5VbFfoDWozAAyY7QM+g4lxBMI3QAqsyg1PllQEt1GBgueQp+E/K5nxIm0WGHIm/UnQNiY= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM2PR04MB0721; x-ms-office365-filtering-correlation-id: 9c7e0ffc-a7a4-445e-2ce7-08d346f5d35d x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:AM2PR04MB0721;BCL:0;PCL:0;RULEID:;SRVR:AM2PR04MB0721; x-forefront-prvs: 08756AC3C8 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(19580405001)(19580395003)(77096005)(3660700001)(5008740100001)(92566002)(11100500001)(3846002)(102836003)(586003)(575784001)(5003600100002)(2950100001)(76576001)(86362001)(66066001)(5002640100001)(5004730100002)(76176999)(40100003)(2900100001)(1411001)(6116002)(122556002)(3280700002)(87936001)(10400500002)(189998001)(110136002)(1220700001)(54356999)(50986999)(1096002)(4326007)(106116001)(74316001)(2906002)(81166005)(7059030)(142933001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM2PR04MB0721;H:AM2PR04MB0722.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2016 02:03:21.4840 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0721 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 08, 2016 at 4:32AM, Brian Norris wrote: > On Tue, Jan 26, 2016 at 03:23:58PM +0800, Yuan Yao wrote: > > new compatible string: "fsl,ls2080a-qspi". > > ^^ This line doesn't match the subject or the content of the patch. > > > Signed-off-by: Yuan Yao > > Acked-by: Rob Herring > > --- > > Changed in v4: > > No changes. > > > > Changed in v3: > > Add the modifier for new compatible string like: > > "fsl,ls2080a-dspi" followed by "fsl,ls2085a-dspi" > > > > Changed in v2: > > Update my email to > > --- > > Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt | 5 ++++- > > ^^ What is this change doing in this series anyway? You're touching MTD stuff, > not SPI stuff, and this string doesn't get used in any driver. Is this controller > somehow related, or is it a separate IP block that happens to be on some of the > same SoCs? > Sorry for the wrong subject, this patch is used for add the SPI(DSPI) binging document. It should be some mistake that I make the wrong subject and the commit message. > Anyway, you should send this kind of stuff to the SPI list, not the MTD one. I will resend it to SPI list, thanks for your review. > Regards, > Brian > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt > > b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt > > index fa77f87..1ad0fe3 100644 > > --- a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt > > +++ b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt > > @@ -1,7 +1,10 @@ > > ARM Freescale DSPI controller > > > > Required properties: > > -- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", "fsl,ls2085a-dspi" > > +- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", > > + "fsl,ls2085a-dspi" > > + or > > + "fsl,ls2080a-dspi" followed by "fsl,ls2085a-dspi" > > - reg : Offset and length of the register set for the device > > - interrupts : Should contain SPI controller interrupt > > - clocks: from common clock binding: handle to dspi clock. > > -- > > 2.1.0.27.g96db324 > >