From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755653AbcI2Tad (ORCPT ); Thu, 29 Sep 2016 15:30:33 -0400 Received: from mail-db5eur01on0072.outbound.protection.outlook.com ([104.47.2.72]:52033 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755018AbcI2TaY (ORCPT ); Thu, 29 Sep 2016 15:30:24 -0400 X-Greylist: delayed 156241 seconds by postgrey-1.27 at vger.kernel.org; Thu, 29 Sep 2016 15:30:23 EDT From: Leo Li To: Arvind Yadav , "leoli@freescale.com" , "vinod.koul@intel.com" CC: "dan.j.williams@intel.com" , "linuxppc-dev@lists.ozlabs.org" , "dmaengine@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] dma/fsldma : Unmap region obtained by of_iomap Thread-Topic: [PATCH] dma/fsldma : Unmap region obtained by of_iomap Thread-Index: AQHSGXWSvknRdg+WnEOG/XbOYCLK2qCQshFw Date: Thu, 29 Sep 2016 16:57:38 +0000 Message-ID: References: <1475059511-10114-1-git-send-email-arvind.yadav.cs@gmail.com> In-Reply-To: <1475059511-10114-1-git-send-email-arvind.yadav.cs@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leoyang.li@nxp.com; x-originating-ip: [192.88.168.1] x-ms-office365-filtering-correlation-id: ea1e7911-03bf-41d3-8d7e-08d3e889b7e6 x-microsoft-exchange-diagnostics: 1;AM2PR04MB0772;7:N1TD980jO18gUEQedaCqgDmQQ2XVwhv4VrQvohNYP0NHdmNgIgsyTlBjQh6pVg0xude+m047oCcPI2qaz78F4tuxqYKUGBWslINsNhs4aMAzb0joU4HrTAktwwaJ6s70XBh1xSpqYdfK8hAe5beXipLVqK3g51zcUbfVci3HBNVI3CHWu976o2C5XpQRZMKdzjmO3KOrhEBY1Eg8NPLyrojv3CVZm9oR5DJ/jPe65UVb5us7fVA7ssNJEagbzaeL+4fXjLVlIo4nXBAH4mzhZvtqDEM8DchOXCYFgrOSrAZivmpfISlFvW8Xr72a4QzLqt5yPYZQ4pCSswKMq17rsA== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM2PR04MB0772; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(65623756079841)(185117386973197)(101931422205132)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:AM2PR04MB0772;BCL:0;PCL:0;RULEID:;SRVR:AM2PR04MB0772; x-forefront-prvs: 00808B16F3 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(377454003)(13464003)(189002)(199003)(81166006)(3660700001)(81156014)(2900100001)(106356001)(4326007)(5002640100001)(105586002)(106116001)(87936001)(3280700002)(189998001)(76576001)(8676002)(7696004)(19580405001)(19580395003)(33656002)(11100500001)(68736007)(66066001)(74316002)(2950100002)(86362001)(305945005)(2201001)(2906002)(92566002)(5660300001)(97736004)(5001770100001)(5250100002)(7736002)(7846002)(54356999)(6116002)(9686002)(2501003)(101416001)(102836003)(586003)(50986999)(8936002)(3846002)(76176999);DIR:OUT;SFP:1101;SCL:1;SRVR:AM2PR04MB0772;H:AM2PR04MB0770.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2016 16:57:38.0353 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0772 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u8TJUoc7023565 > -----Original Message----- > From: Arvind Yadav [mailto:arvind.yadav.cs@gmail.com] > Sent: Wednesday, September 28, 2016 5:45 AM > To: leoli@freescale.com; zw@zh-kernel.org; vinod.koul@intel.com > Cc: dan.j.williams@intel.com; linuxppc-dev@lists.ozlabs.org; > dmaengine@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] dma/fsldma : Unmap region obtained by of_iomap > > Free memory mapping, if probe is not successful. > > Signed-off-by: Arvind Yadav Acked-by: Li Yang > --- > drivers/dma/fsldma.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index > 911b717..7ba8944 100644 > --- a/drivers/dma/fsldma.c > +++ b/drivers/dma/fsldma.c > @@ -1351,7 +1351,7 @@ static int fsldma_of_probe(struct platform_device > *op) > if (!fdev->regs) { > dev_err(&op->dev, "unable to ioremap registers\n"); > err = -ENOMEM; > - goto out_free_fdev; > + goto out_free; > } > > /* map the channel IRQ if it exists, but don't hookup the handler yet */ > @@ -1416,6 +1416,8 @@ static int fsldma_of_probe(struct platform_device > *op) > > out_free_fdev: > irq_dispose_mapping(fdev->irq); > + iounmap(fdev->regs); > +out_free: > kfree(fdev); > out_return: > return err; > -- > 1.7.9.5