From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753399AbcJUQTV (ORCPT ); Fri, 21 Oct 2016 12:19:21 -0400 Received: from mail-db5eur01on0069.outbound.protection.outlook.com ([104.47.2.69]:12160 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934884AbcJUQTR (ORCPT ); Fri, 21 Oct 2016 12:19:17 -0400 From: Leo Li To: Bjorn Helgaas CC: Bjorn Helgaas , Minghuan Lian , Mingkai Hu , "Roy Zang" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Stuart Yoder Subject: RE: [PATCH] PCI: layerscape: Fix kernel panic on accessing NULL pointer Thread-Topic: [PATCH] PCI: layerscape: Fix kernel panic on accessing NULL pointer Thread-Index: AQHSKMB2zH2QwvUP3kqj5IgtqSpalqCzEG2AgAAEtNA= Date: Fri, 21 Oct 2016 16:05:04 +0000 Message-ID: References: <1476740647-11155-1-git-send-email-leoyang.li@nxp.com> <20161021153701.GC9007@localhost> In-Reply-To: <20161021153701.GC9007@localhost> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=leoyang.li@nxp.com; x-originating-ip: [192.88.168.50] x-ms-office365-filtering-correlation-id: d91ecbe2-0d21-41a7-20d8-08d3f9cc050f x-microsoft-exchange-diagnostics: 1;DB6PR0401MB2631;7:gtbeooG2ZHngZgLMEUd342MvTzi1v3wxUDeY9/6OprJFuayXiIy1VQo3FjtDG/argw490kK8/4PH11zxRjjN6pIFcwP+xCH2DvPpIjHlnwWKLDDZkyE4W98vZqaTHhTObCW9xm9iQBNe4T2cQZjD88ytEvmnZldwHvdoxZ6baUYRpUGm3qVYrRPZDnqyrwnLs4OuVWg1e1dqP96TR5EobwreZV4sjdZ1Jc1+8N6JsdQuWhYu7bXc35AywTQHs7G5Fca3un0lq1V8K/K1GMvrJ8jY1mxIHYHYz2od0w4B/dYVoxEyhmG67iVXp7jaK7GF4CgGDV2dw7gC5MLYj5fkS1BCh0VQO5IHwosYSIlG1i8= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0401MB2631; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197)(101931422205132)(258649278758335)(211936372134217); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:DB6PR0401MB2631;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0401MB2631; x-forefront-prvs: 01026E1310 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(377454003)(199003)(189002)(24454002)(13464003)(68736007)(7736002)(81156014)(81166006)(74316002)(7846002)(5002640100001)(2900100001)(4326007)(8936002)(87936001)(2950100002)(189998001)(305945005)(6916009)(76576001)(8676002)(3280700002)(5250100002)(92566002)(7696004)(19580395003)(19580405001)(66066001)(6116002)(9686002)(5660300001)(86362001)(3660700001)(586003)(97736004)(33656002)(110136003)(102836003)(76176999)(11100500001)(106116001)(54356999)(106356001)(2906002)(50986999)(3846002)(105586002)(101416001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0401MB2631;H:AM2PR04MB0770.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2016 16:05:04.1644 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2631 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9LGJTOJ004194 > -----Original Message----- > From: Bjorn Helgaas [mailto:helgaas@kernel.org] > Sent: Friday, October 21, 2016 10:37 AM > To: Leo Li > Cc: Bjorn Helgaas ; Minghuan Lian > ; Mingkai Hu ; > Roy Zang ; linux-pci@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Stuart Yoder > > Subject: Re: [PATCH] PCI: layerscape: Fix kernel panic on accessing NULL pointer > > On Mon, Oct 17, 2016 at 04:44:06PM -0500, Li Yang wrote: > > Commit fefe6733e added reference to the pcie->drvdata before it is > > initialized which causes a kernel panic. Fix the problem by > > initializing the pcie->drvdata earlier before it is used. > > > > Reported-by: Stuart Yoder > > Signed-off-by: Li Yang > > I applied Marc Zyngier's identical patch to for-linus for v4.9. I don't know which > was posted first, but I saw Marc's first. Sorry I didn't at least credit you when I > applied it. It's ok. Seems Marc sent the patch earlier and I didn't notice his patch. There is no difference as long as the problem is addressed. :) Regards, Leo