From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941438AbcIZCTm (ORCPT ); Sun, 25 Sep 2016 22:19:42 -0400 Received: from mail-db5eur01on0055.outbound.protection.outlook.com ([104.47.2.55]:44960 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S941350AbcIZCTl (ORCPT ); Sun, 25 Sep 2016 22:19:41 -0400 From: Qiang Zhao To: Scott Wood CC: "linuxppc-dev@lists.ozlabs.org" , "pku.leo@gmail.com" , "X.B. Xie" , "linux-kernel@vger.kernel.org" Subject: RE: [v6,2/2] QE: remove PPCisms for QE Thread-Topic: [v6,2/2] QE: remove PPCisms for QE Thread-Index: AQHSFuNMOuwKsTJCKk+lsdjyrD1KeqCJmiIAgAFmmNA= Date: Mon, 26 Sep 2016 01:46:37 +0000 Message-ID: References: <1474597232-33397-2-git-send-email-qiang.zhao@nxp.com> <20160925041411.GA16092@home.buserror.net> <20160925041906.GA16719@home.buserror.net> In-Reply-To: <20160925041906.GA16719@home.buserror.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=qiang.zhao@nxp.com; x-originating-ip: [199.59.226.141] x-ms-office365-filtering-correlation-id: 73d5d3f6-7109-4ce1-fad9-08d3e5aef447 x-microsoft-exchange-diagnostics: 1;DB6PR0401MB2424;7:F9YXoNHRS4j9+qQOFlvu70bdhtWmWwdBfqeRWKaB+aKm6U4dGdnFxv9XGbhA3Go6ug+VIVOoCd/Fy7JPN03BvesEa3ZRw0C7uxDtQOadKp76EEoOHWd1OeTx30+8Oz3WMWGAL6TBurTtoEesHHk/EpdPrGtGzRYcH9qVNyNrWQqXZywwZOibDwsOK0ErtPx9rtSW/v2TkgdnUBoIbVqROFlV6p6Ti0LI5BOYpuSyBPF+C0ZklEUcm/1DN1hewW9MyJyqDEXYQmNJBwNTYIBtWg6/PtyU64FOwt/nCE1dQl4Dit6pi7Ag4oSY+6TmtjBTgLRN2GNgpTcH00+QmUwSGA== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0401MB2424; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(65623756079841)(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:DB6PR0401MB2424;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0401MB2424; x-forefront-prvs: 00770C4423 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(377454003)(199003)(13464003)(189002)(24454002)(5660300001)(19580405001)(19580395003)(110136003)(7696004)(189998001)(9686002)(7736002)(92566002)(7846002)(74316002)(305945005)(66066001)(5250100002)(97736004)(2900100001)(81156014)(81166006)(87936001)(8936002)(4326007)(8676002)(5002640100001)(76576001)(586003)(54356999)(68736007)(76176999)(11100500001)(3846002)(101416001)(6116002)(102836003)(15975445007)(50986999)(2950100002)(2906002)(6916009)(3280700002)(3660700001)(86362001)(105586002)(33656002)(106116001)(106356001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0401MB2424;H:AM3PR04MB1185.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2016 01:46:37.3779 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2424 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u8Q2JlTR001066 On Sun, Sep 25, 2016 at 12:19PM -0500, Scott Wood wrote: > -----Original Message----- > From: Scott Wood [mailto:oss@buserror.net] > Sent: Sunday, September 25, 2016 12:19 PM > To: Qiang Zhao > Cc: linuxppc-dev@lists.ozlabs.org; pku.leo@gmail.com; X.B. Xie > ; linux-kernel@vger.kernel.org > Subject: Re: [v6,2/2] QE: remove PPCisms for QE > > On Sat, Sep 24, 2016 at 11:14:11PM -0500, Scott Wood wrote: > > On Fri, Sep 23, 2016 at 10:20:32AM +0800, Zhao Qiang wrote: > > > QE was supported on PowerPC, and dependent on PPC, Now it is > > > supported on other platforms. so remove PPCisms. > > > > > > Signed-off-by: Zhao Qiang > > > --- > > > Changes for v2: > > > - na > > > Changes for v3: > > > - add NO_IRQ > > > Changes for v4: > > > - modify spin_event_timeout to opencoded timeout loop > > > - remove NO_IRQ > > > - modify virq_to_hw to opencoed code Changes for v5: > > > - modify commit msg > > > - modify depends of QUICC_ENGINE > > > - add kerneldoc header for qe_issue_cmd Changes for v6: > > > - add dependency on FSL_SOC and PPC32 for drivers > > > depending on QUICC_ENGING but not available on ARM > > > > > > drivers/irqchip/qe_ic.c | 28 +++++++----- > > > drivers/net/ethernet/freescale/Kconfig | 10 ++--- > > > drivers/soc/fsl/qe/Kconfig | 2 +- > > > drivers/soc/fsl/qe/qe.c | 80 ++++++++++++++++++++-------------- > > > drivers/soc/fsl/qe/qe_io.c | 42 ++++++++---------- > > > drivers/soc/fsl/qe/qe_tdm.c | 8 ++-- > > > drivers/soc/fsl/qe/ucc.c | 10 ++--- > > > drivers/soc/fsl/qe/ucc_fast.c | 68 ++++++++++++++--------------- > > > drivers/tty/serial/Kconfig | 2 +- > > > drivers/usb/gadget/udc/Kconfig | 2 +- > > > drivers/usb/host/Kconfig | 2 +- > > > include/soc/fsl/qe/qe.h | 1 - > > > include/soc/fsl/qe/qe_ic.h | 12 ++--- > > > 13 files changed, 141 insertions(+), 126 deletions(-) > > > > I assume this means you'll be updating > > http://patchwork.ozlabs.org/patch/654473/ > > to be based on top of this... > > Apparently that assumption was wrong, since I now see that you're patching > drivers/irqchip/qe_ic.c rather than drivers/soc/fsl/qe/qe_ic.c. > Please keep the drivers/irqchip stuff separate and send to the appropriate > maintainers. > You means separate drivers/irqchip/qe_ic.c part from this patch and send it with the other qe_ic patches? Is it acceptable if I modify qe_ic.c with drivers/soc/fsl/qe/qe_ic.c, then send qe_ic patches to move qe_ic to drivers/irqchip? BR -Zhao Qiang