From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759000AbcBYDoG (ORCPT ); Wed, 24 Feb 2016 22:44:06 -0500 Received: from mail-am1on0068.outbound.protection.outlook.com ([157.56.112.68]:54144 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757717AbcBYDoE (ORCPT ); Wed, 24 Feb 2016 22:44:04 -0500 X-Greylist: delayed 1101 seconds by postgrey-1.27 at vger.kernel.org; Wed, 24 Feb 2016 22:44:03 EST From: Qiang Zhao To: Scott Wood , Rob Herring CC: Yang-Leo Li , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" Subject: RE: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings. Thread-Topic: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings. Thread-Index: AQHRaenJkhgdAeUfxkiEYhOytJ/C2p86GgIAgAABXACAAgNyEA== Date: Thu, 25 Feb 2016 03:10:26 +0000 Message-ID: References: <1455757572-44955-1-git-send-email-qiang.zhao@nxp.com> <20160223201520.GA3354@rob-hp-laptop> <1456258812.5360.22.camel@buserror.net> In-Reply-To: <1456258812.5360.22.camel@buserror.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: buserror.net; dkim=none (message not signed) header.d=none;buserror.net; dmarc=none action=none header.from=nxp.com; x-originating-ip: [123.151.195.52] x-microsoft-exchange-diagnostics: 1;AM3PR04MB0776;5:s7hcLMU9eY3bNqEXjFQgG9tYpzDBy91ueae+Q0LWYjHCwqcrhNWE6aKpbK/a2sFI49QClDfkrqjdQpACtlQiJeh2TBDFA6HDPe/G6rs69d2N638NZgtagjXp0rJmY/peA+IjJQfYwY41KFJ8AoheVg==;24:Ptql0HfAifueY6o5/ia0/QjYcuSNZ5ge/lh5ix4VPybv9STsvrzxb7d7PfMsBxlHUbX+cIEL+6IuYBje/TFOWAM0rr6RDQjqBwR/vEKBn8Y= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM3PR04MB0776; x-ms-office365-filtering-correlation-id: 92c8ac97-e45b-44db-4567-08d33d91357b x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:AM3PR04MB0776;BCL:0;PCL:0;RULEID:;SRVR:AM3PR04MB0776; x-forefront-prvs: 08635C03D4 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(377424004)(24454002)(13464003)(377454003)(102836003)(3846002)(54356999)(11100500001)(106116001)(50986999)(189998001)(5001960100002)(76176999)(1220700001)(87936001)(5008740100001)(5003600100002)(76576001)(5002640100001)(586003)(5004730100002)(86362001)(1096002)(4326007)(2906002)(74316001)(5001770100001)(3280700002)(2950100001)(6116002)(40100003)(92566002)(33656002)(66066001)(2900100001)(5250100002)(19580395003)(19580405001)(3660700001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR04MB0776;H:AM3PR04MB1185.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2016 03:10:26.4632 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR04MB0776 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u1P3iGe6029663 On Wed, 2016-02-24 at 04:20 AM, Scott Wood wrote: > -----Original Message----- > From: Scott Wood [mailto:oss@buserror.net] > Sent: Wednesday, February 24, 2016 4:20 AM > To: Rob Herring ; Qiang Zhao > Cc: Yang-Leo Li ; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree > bindings. > > On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote: > > On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote: > > > Add IC, SI and SIRAM document of QE to > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > > > > Signed-off-by: Zhao Qiang > > > --- > > > Changes for v2 > > > - Add interrupt-controller in Required properties > > > - delete address-cells and size-cells for qe-si and qe-siram > > > > > > .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50 > > > ++++++++++++++++++++++ > > > 1 file changed, 50 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > index 4f89302..84052a7 100644 > > > --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > > @@ -69,6 +69,56 @@ Example: > > > }; > > > }; > > > > > > +* Interrupt Controller (IC) > > > + > > > +Required properties: > > > +- compatible : should be "fsl,qe-ic". > > > > > +- compatible : should be "fsl,qe-si". > > > > > +- compatible : should be "fsl,qe-siram". > > > > These compatible strings are all a bit generic and should have SoC > > specific compatible strings. > > I don't know about si/siram, but "fsl,qe-ic" has been around since 2008, so it > should be documented even if a more specific compatible is also added. Agree, and si/siram are also has been around since 2008. In addition, I don’t think it is needed to add specific compatible, because they are the same in qe-supported soc. BR -Zhao