From: Anson Huang <anson.huang@nxp.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH] gpio: mxc: add power management support
Date: Mon, 16 Jul 2018 06:14:33 +0000 [thread overview]
Message-ID: <AM3PR04MB13153EB5ADEBCD57A7122B61F55D0@AM3PR04MB1315.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAOMZO5DCsdwXK0eftcpwzT4my30HZLR7-H2c+V=ro+_fOMAWCw@mail.gmail.com>
Hi, Fabio
Anson Huang
Best Regards!
> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@gmail.com]
> Sent: Sunday, July 15, 2018 12:13 AM
> To: Anson Huang <anson.huang@nxp.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>; open list:GPIO SUBSYSTEM
> <linux-gpio@vger.kernel.org>; linux-kernel <linux-kernel@vger.kernel.org>;
> dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH] gpio: mxc: add power management support
>
> Hi Anson,
>
> On Fri, Jul 13, 2018 at 10:53 PM, Anson Huang <anson.huang@nxp.com>
> wrote:
>
> > Here are the details, i.MX7D LPSR mode and i.MX8QM/8QXP etc.'
> > suspend/resume may cause GPIO bank lose power, so need to
> > save/restore, for other i.MX SoCs, although no need to do
> > save/restore, but doing it is NOT harmful, so do you think we should add SoC
> type check here?
>
> I think it would be safer to restrict the save/restore operations to mx7/mx8.
>
> You can add a fsl,imx7d-gpio compatible entry in the driver.
>
> Thanks
OK, since i.MX7D has same GPIO type as i.MX35, to make it simple, I just added
a flag to indicate whether it supports save/restore, only i.MX7D enables
the flag now, since other i.MX8 SoCs' dts is NOT upstreamed yet, so I did NOT add
support for i.MX8 SoCs, please help review V2 patch, thanks.
Anson.
next prev parent reply other threads:[~2018-07-16 6:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 7:48 Anson Huang
2018-07-13 7:11 ` Linus Walleij
2018-07-13 7:19 ` Bartosz Golaszewski
2018-07-13 17:57 ` Fabio Estevam
2018-07-13 18:33 ` Fabio Estevam
2018-07-14 1:53 ` Anson Huang
2018-07-14 16:13 ` Fabio Estevam
2018-07-16 6:14 ` Anson Huang [this message]
2018-07-17 13:43 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM3PR04MB13153EB5ADEBCD57A7122B61F55D0@AM3PR04MB1315.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=festevam@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®