From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751419AbeAYNqU (ORCPT ); Thu, 25 Jan 2018 08:46:20 -0500 Received: from mail-he1eur01on0062.outbound.protection.outlook.com ([104.47.0.62]:54176 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751114AbeAYNqS (ORCPT ); Thu, 25 Jan 2018 08:46:18 -0500 From: "A.s. Dong" To: Fabio Estevam CC: linux-clk , Jacky Bai , "Anson Huang" , Michael Turquette , Stephen Boyd , linux-kernel , dl-linux-imx , "Fabio Estevam" , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Subject: RE: [PATCH V3 10/10] add imx7ulp support Thread-Topic: [PATCH V3 10/10] add imx7ulp support Thread-Index: AQHTkScaHVP7ZX4ad0OQookhCHgvAqOEnKuAgAAFUrA= Date: Thu, 25 Jan 2018 13:46:11 +0000 Message-ID: References: <1516367470-24340-1-git-send-email-aisheng.dong@nxp.com> <1516367470-24340-11-git-send-email-aisheng.dong@nxp.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-originating-ip: [185.114.77.231] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR04MB516;7:Yp09mi0dkWBLn4Kkkf4eGc/JH8SZazuV3e6hL0ge/7Cssj/rLJc8PSd56/lpGyKey065GyDiyt6NLjbBmmdrrZDhQ+LJJCNmErbUJZ/Y+wBYTvvRGHKeVu12uZyY4vtrACJkTfRTpIt1qd8sLR37lKjEF9u/Jcjn9WMclVBIIQhz37TLP56eLMjxSw22OQuli6av3+GRXZzhiut5hSVJFSKUldierBbw0jTOUwwjbPDd03quOrkgvaOZwuH41S3S x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: cbc8721b-457d-4d54-c510-08d563f9ff10 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:AM3PR04MB516; x-ms-traffictypediagnostic: AM3PR04MB516: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197)(85827821059158)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231023)(2400081)(944501161)(6055026)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011);SRVR:AM3PR04MB516;BCL:0;PCL:0;RULEID:;SRVR:AM3PR04MB516; x-forefront-prvs: 0563F2E8B7 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(346002)(39860400002)(376002)(366004)(39380400002)(189003)(199004)(13464003)(25786009)(4326008)(102836004)(316002)(229853002)(39060400002)(5250100002)(6246003)(81166006)(3280700002)(81156014)(2900100001)(106356001)(105586002)(8676002)(6436002)(33656002)(6116002)(3660700001)(53936002)(2906002)(6506007)(7696005)(59450400001)(53546011)(76176011)(55016002)(66066001)(5660300001)(6916009)(8936002)(9686003)(2950100002)(7736002)(3846002)(86362001)(74316002)(54906003)(14454004)(186003)(97736004)(99286004)(1411001)(26005)(478600001)(305945005)(68736007)(2004002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR04MB516;H:AM3PR04MB306.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: nT+2tlwi3q/8lLf9q72uxU2zfVZfq3kz+u17ucquVlK097o3C5wvAGzlEe/4aoveMApyu0XgOKlXBZbir5W9Zw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cbc8721b-457d-4d54-c510-08d563f9ff10 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2018 13:46:11.8995 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR04MB516 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w0PDkQ8r007477 Hi Fabio, This patch (Patch 10) is used for test and was sent out by accidently, not formal one. I also explained in another email. Guess you may not see it. Really sorry for the inconvenience. Regards Dong Aisheng > -----Original Message----- > From: Fabio Estevam [mailto:festevam@gmail.com] > Sent: Thursday, January 25, 2018 9:22 PM > To: A.s. Dong > Cc: linux-clk ; Jacky Bai ; > Anson Huang ; Michael Turquette > ; Stephen Boyd ; linux- > kernel ; dl-linux-imx ; > Fabio Estevam ; Shawn Guo > ; moderated list:ARM/FREESCALE IMX / MXC ARM > ARCHITECTURE > Subject: Re: [PATCH V3 10/10] add imx7ulp support > > On Fri, Jan 19, 2018 at 11:11 AM, Dong Aisheng > wrote: > > Please always add a commit log. > > > Signed-off-by: Dong Aisheng > > > --- > > arch/arm/boot/dts/Makefile | 2 + > > arch/arm/boot/dts/imx7ulp-evk.dts | 87 +++++++++++++++ > > arch/arm/boot/dts/imx7ulp.dtsi | 202 > +++++++++++++++++++++++++++++++++++ > > arch/arm/configs/imx_v6_v7_defconfig | 16 ++- > > arch/arm/mach-imx/Kconfig | 9 ++ > > arch/arm/mach-imx/Makefile | 1 + > > arch/arm/mach-imx/common.h | 1 + > > arch/arm/mach-imx/cpu.c | 3 + > > arch/arm/mach-imx/mach-imx7ulp.c | 37 +++++++ > > arch/arm/mach-imx/mxc.h | 1 + > > arch/arm/mach-imx/pm-imx7ulp.c | 32 ++++++ > > 11 files changed, 381 insertions(+), 10 deletions(-) create mode > > 100644 arch/arm/boot/dts/imx7ulp-evk.dts create mode 100644 > > arch/arm/boot/dts/imx7ulp.dtsi create mode 100644 > > arch/arm/mach-imx/mach-imx7ulp.c create mode 100644 > > arch/arm/mach-imx/pm-imx7ulp.c > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > index d0381e9..3257e71 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -519,6 +519,8 @@ dtb-$(CONFIG_SOC_IMX7D) += \ > > imx7d-sdb-sht11.dtb \ > > imx7s-colibri-eval-v3.dtb \ > > imx7s-warp.dtb > > +dtb-$(CONFIG_SOC_IMX7ULP) += \ > > + imx7ulp-evk.dtb > > dtb-$(CONFIG_SOC_LS1021A) += \ > > ls1021a-qds.dtb \ > > ls1021a-twr.dtb > > diff --git a/arch/arm/boot/dts/imx7ulp-evk.dts > > b/arch/arm/boot/dts/imx7ulp-evk.dts > > new file mode 100644 > > index 0000000..cc4e6ef > > --- /dev/null > > +++ b/arch/arm/boot/dts/imx7ulp-evk.dts > > @@ -0,0 +1,87 @@ > > +/* > > + * Copyright 2017 NXP > > + * > > + * This program is free software; you can redistribute it and/or > > +modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > Please use SPDX identifier. > > > > + */ > > + > > +/dts-v1/; > > + > > +#include "imx7ulp.dtsi" > > + > > +/ { > > + model = "NXP i.MX7ULP EVK"; > > + compatible = "fsl,imx7ulp-evk", "fsl,imx7ulp", "Generic DT > > +based system"; > > Please remove the '"Generic DT based system" entry. > > > > + > > + chosen { > > + bootargs = "console=ttyLP0,115200 > earlycon=lpuart32,0x402D0010,115200"; > > + stdout-path = &lpuart4; > > Better remove bootargs. > > > > + }; > > + > > + memory { > > memory@60000000 , otherwise building with W=1 will give you warning. > > Please make sure that you don't get dtc warnings with W=1. > > > + device_type = "memory"; > > + reg = <0x60000000 0x40000000>; > > + }; > > +}; > > + > > +&lpuart4 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_lpuart4>; > > + status = "okay"; > > +}; > > + > > +&usdhc0 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <>; > > + pinctrl-0 = <&pinctrl_usdhc0_cmd_data>, <&pinctrl_usdhc0_clk>; > > +// <&pinctrl_usdhc0_cd>, <&pinctrl_usdhc0_rst>; > > Just remove the line instead of commenting it. > > > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi > > b/arch/arm/boot/dts/imx7ulp.dtsi new file mode 100644 index > > 0000000..05410ba > > --- /dev/null > > +++ b/arch/arm/boot/dts/imx7ulp.dtsi > > @@ -0,0 +1,202 @@ > > +/* > > + * Copyright NXP > > No year information? > > > > + * > > + * This program is free software; you can redistribute it and/or > > + modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > > Please use SPDX identifier instead. > > > diff --git a/arch/arm/configs/imx_v6_v7_defconfig > > b/arch/arm/configs/imx_v6_v7_defconfig > > index 0d44949..3ce8ff6 100644 > > --- a/arch/arm/configs/imx_v6_v7_defconfig > > +++ b/arch/arm/configs/imx_v6_v7_defconfig > > @@ -41,6 +41,7 @@ CONFIG_SOC_IMX6SL=y > > CONFIG_SOC_IMX6SX=y > > CONFIG_SOC_IMX6UL=y > > CONFIG_SOC_IMX7D=y > > +CONFIG_SOC_IMX7ULP=y > > This should be part of a separate patch. > > > > CONFIG_SOC_VF610=y > > CONFIG_PCI=y > > CONFIG_PCI_MSI=y > > @@ -48,9 +49,7 @@ CONFIG_PCI_IMX6=y > > CONFIG_SMP=y > > CONFIG_ARM_PSCI=y > > CONFIG_PREEMPT_VOLUNTARY=y > > -CONFIG_AEABI=y > > CONFIG_HIGHMEM=y > > -CONFIG_CMA=y > > CONFIG_FORCE_MAX_ZONEORDER=14 > > CONFIG_CMDLINE="noinitrd console=ttymxc0,115200" > > CONFIG_KEXEC=y > > @@ -81,7 +80,6 @@ CONFIG_CAN_FLEXCAN=y CONFIG_BT=y > > CONFIG_BT_HCIUART=y CONFIG_BT_HCIUART_H4=y - > CONFIG_BT_HCIUART_LL=y > > CONFIG_CFG80211=y CONFIG_CFG80211_WEXT=y CONFIG_MAC80211=y > @@ -90,7 > > +88,6 @@ CONFIG_RFKILL_INPUT=y CONFIG_DEVTMPFS=y > > CONFIG_DEVTMPFS_MOUNT=y # CONFIG_STANDALONE is not set > > -CONFIG_DMA_CMA=y > > CONFIG_CMA_SIZE_MBYTES=64 > > CONFIG_IMX_WEIM=y > > CONFIG_CONNECTOR=y > > @@ -167,9 +164,9 @@ CONFIG_MOUSE_PS2_ELANTECH=y > > CONFIG_INPUT_TOUCHSCREEN=y CONFIG_TOUCHSCREEN_ADS7846=y > > CONFIG_TOUCHSCREEN_EGALAX=y > > +CONFIG_TOUCHSCREEN_MAX11801=y > > CONFIG_TOUCHSCREEN_IMX6UL_TSC=y > > CONFIG_TOUCHSCREEN_EDT_FT5X06=y > > -CONFIG_TOUCHSCREEN_MAX11801=y > > CONFIG_TOUCHSCREEN_MC13783=y > > CONFIG_TOUCHSCREEN_TSC2004=y > > CONFIG_TOUCHSCREEN_TSC2007=y > > @@ -178,7 +175,6 @@ CONFIG_TOUCHSCREEN_SX8654=y > > CONFIG_TOUCHSCREEN_COLIBRI_VF50=y CONFIG_INPUT_MISC=y > > CONFIG_INPUT_MMA8450=y -CONFIG_HID_MULTITOUCH=y > > CONFIG_SERIO_SERPORT=m # CONFIG_LEGACY_PTYS is not set > > CONFIG_SERIAL_IMX=y @@ -228,13 +224,13 @@ > CONFIG_REGULATOR_GPIO=y > > CONFIG_REGULATOR_MC13783=y CONFIG_REGULATOR_MC13892=y > > CONFIG_REGULATOR_PFUZE100=y > > +CONFIG_RC_CORE=y > > +CONFIG_RC_DEVICES=y > > +CONFIG_IR_GPIO_CIR=y > > CONFIG_MEDIA_SUPPORT=y > > CONFIG_MEDIA_CAMERA_SUPPORT=y > > -CONFIG_RC_CORE=y > > CONFIG_MEDIA_CONTROLLER=y > > CONFIG_VIDEO_V4L2_SUBDEV_API=y > > -CONFIG_RC_DEVICES=y > > -CONFIG_IR_GPIO_CIR=y > > CONFIG_MEDIA_USB_SUPPORT=y > > CONFIG_USB_VIDEO_CLASS=m > > CONFIG_V4L_PLATFORM_DRIVERS=y > > @@ -245,7 +241,6 @@ CONFIG_VIDEO_CODA=m # > > CONFIG_MEDIA_SUBDRV_AUTOSELECT is not set > CONFIG_VIDEO_ADV7180=m > > CONFIG_VIDEO_OV5640=m -CONFIG_SOC_CAMERA_OV2640=y > > CONFIG_IMX_IPUV3_CORE=y CONFIG_DRM=y > CONFIG_DRM_PANEL_SIMPLE=y @@ > > -283,6 +278,7 @@ CONFIG_SND_SOC_CS42XX8_I2C=y > > CONFIG_SND_SOC_TLV320AIC3X=y CONFIG_SND_SOC_WM8960=y > > CONFIG_SND_SIMPLE_CARD=y > > +CONFIG_HID_MULTITOUCH=y > > Don't do the defconfig cleanup in the same patch. > > > CONFIG_USB=y > > CONFIG_USB_EHCI_HCD=y > > CONFIG_USB_EHCI_MXC=y > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig > > index 782699e..54002c3 100644 > > --- a/arch/arm/mach-imx/Kconfig > > +++ b/arch/arm/mach-imx/Kconfig > > @@ -554,6 +554,15 @@ comment "Cortex-A/Cortex-M asymmetric > multiprocessing platforms" > > > > if ARCH_MULTI_V7 || ARM_SINGLE_ARMV7M > > > > +config SOC_IMX7ULP > > + bool "i.MX7ULP support" > > + select ARM_GIC > > + select CLKSRC_IMX_TPM > > + select HAVE_ARM_ARCH_TIMER > > + select PINCTRL_IMX7ULP > > + help > > + This enables support for Freescale i.MX7 Ultra Low Power processor. > > + > > config SOC_VF610 > > bool "Vybrid Family VF610 support" > > select ARM_GIC if ARCH_MULTI_V7 diff --git > > a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile index > > 8ff7105..69c2517 100644 > > --- a/arch/arm/mach-imx/Makefile > > +++ b/arch/arm/mach-imx/Makefile > > arch/arm/mach-imx changes can also go in a different patch.