From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751648AbdECDsQ (ORCPT ); Tue, 2 May 2017 23:48:16 -0400 Received: from mail-ve1eur01on0073.outbound.protection.outlook.com ([104.47.1.73]:5760 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751272AbdECDsH (ORCPT ); Tue, 2 May 2017 23:48:07 -0400 From: "A.S. Dong" To: Leonard Crestez , Shawn Guo CC: Leonard Crestez , Sascha Hauer , Jagan Teki , "Fabio Estevam" , Dong Aisheng , "linux-arm-kernel@lists.infradead.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] ARM: imx_v6_v7_defconfig: Enable cpufreq governors Thread-Topic: [PATCH] ARM: imx_v6_v7_defconfig: Enable cpufreq governors Thread-Index: AQHSw1LcL/cJC7EoJkik5MM6JIBVZaHh+Tog Date: Wed, 3 May 2017 03:48:03 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [199.59.231.64] x-microsoft-exchange-diagnostics: 1;AM3PR04MB340;7:iEptMXFJxgSLbFvJJ4SqDlDjIHYviL1Bw9zBvLa5H5mflc3KbrNsxp2slZwYbs5dMFPcBVrt5oi4VCSJzWXFNnZd8ViSOCnqPlmhNuSBnkVfhhPmA5EfrxwEHZ0DQ7OfwcreX6byc4kucXRmpTrgEMhpNhfwRzjgUia3aupgs/m5aaf6UpVSGB6UJyI4biDps1U6dBHYp7wO/1OunQB+FiIl+ZjAMB/KbjFn0WdREJmaqiyiwxqpr59IWbOoqbmYaElvcbDaQrRxendg2nbHaHnYK0QP5vRoOCklGXghY1ML8vE6jjFz2OazW/tTQFdUY4MTx0t2Om3nV3brjm31jg== x-ms-office365-filtering-correlation-id: 4a6669dd-f88d-4887-fd13-08d491d733d9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:AM3PR04MB340; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(20161123558100)(6072148);SRVR:AM3PR04MB340;BCL:0;PCL:0;RULEID:;SRVR:AM3PR04MB340; x-forefront-prvs: 029651C7A1 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39400400002)(39410400002)(39840400002)(39860400002)(39450400003)(377454003)(102836003)(7736002)(305945005)(7696004)(3846002)(74316002)(229853002)(6116002)(5660300001)(8676002)(55016002)(81166006)(99286003)(9686003)(38730400002)(53936002)(8936002)(4326008)(54906002)(6246003)(25786009)(478600001)(5250100002)(6436002)(66066001)(6506006)(2950100002)(3660700001)(33656002)(50986999)(3280700002)(189998001)(86362001)(76176999)(54356999)(53546009)(2900100001)(15760500002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR04MB340;H:AM3PR04MB306.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2017 03:48:03.8909 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR04MB340 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v433mJqu018243 > -----Original Message----- > From: Leonard Crestez [mailto:leonard.crestez@nxp.com] > Sent: Tuesday, May 02, 2017 10:46 PM > To: Shawn Guo > Cc: Leonard Crestez; Sascha Hauer; Jagan Teki; Fabio Estevam; Dong Aisheng; > linux-arm-kernel@lists.infradead.org; linux-pm@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH] ARM: imx_v6_v7_defconfig: Enable cpufreq governors > > Enable more common cpufreq governors in imx defconfig because this is very > useful for testing. In particular you can't use cpufreq-set -f $FREQ > without explicitly defining CONFIG_CPU_FREQ_GOV_USERSPACE=y. > > Signed-off-by: Leonard Crestez Well, I think we do need this. So: Acked-by: Dong Aisheng Regards Dong Aisheng > > --- > > It might make sense for all governors to be enabled by default from > drivers/cpufreq/Kconfig and allow defconfigs to be shorter. > Right now the descriptions for some of them includes a line that says "If > in doubt, say Y" but the config options don't have actually have a default > value defined and they effectively default to N. > > Cycling via savedefconfig on shawnguo/for-next also generates some > reordering for some newly added options CONFIG_TOUCHSCREEN_MAX11801=y and > CONFIG_HID_MULTITOUCH=y. Those were not included but it's strange that > this happens. Maybe those options were inserted manually, or otherwise > there is an annoying bug in kconfig? > > arch/arm/configs/imx_v6_v7_defconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/configs/imx_v6_v7_defconfig > b/arch/arm/configs/imx_v6_v7_defconfig > index bb6fa56..bf1e7e3 100644 > --- a/arch/arm/configs/imx_v6_v7_defconfig > +++ b/arch/arm/configs/imx_v6_v7_defconfig > @@ -55,6 +55,9 @@ CONFIG_CMDLINE="noinitrd console=ttymxc0,115200" > CONFIG_KEXEC=y > CONFIG_CPU_FREQ=y > CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y > +CONFIG_CPU_FREQ_GOV_POWERSAVE=y > +CONFIG_CPU_FREQ_GOV_USERSPACE=y > +CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y > CONFIG_ARM_IMX6Q_CPUFREQ=y > CONFIG_CPU_IDLE=y > CONFIG_VFP=y > -- > 2.7.4