From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932503AbcLSQkN (ORCPT ); Mon, 19 Dec 2016 11:40:13 -0500 Received: from mail-db5eur01on0086.outbound.protection.outlook.com ([104.47.2.86]:4512 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759994AbcLSQkI (ORCPT ); Mon, 19 Dec 2016 11:40:08 -0500 From: Madalin-Cristian Bucur To: David Miller CC: "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Scott Wood , "mpe@ellerman.id.au" Subject: RE: [PATCH net v2 2/5] powerpc: remove fsl,fman from of_device_ids[] Thread-Topic: [PATCH net v2 2/5] powerpc: remove fsl,fman from of_device_ids[] Thread-Index: AQHSWdnyTaaT+6QEC0SlXE9W3gImFKEPZ9QAgAAIRDA= Date: Mon, 19 Dec 2016 16:07:45 +0000 Message-ID: References: <1482139343-8975-1-git-send-email-madalin.bucur@nxp.com> <1482139343-8975-3-git-send-email-madalin.bucur@nxp.com> <20161219.103712.1578523196484939315.davem@davemloft.net> In-Reply-To: <20161219.103712.1578523196484939315.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=madalin.bucur@nxp.com; x-originating-ip: [192.88.146.1] x-microsoft-exchange-diagnostics: 1;VI1PR0401MB1934;7:bEbLYKGgjmyEXaGzqCRAmnEWYVjC4WPA/wWMluJitpxVRkaprMy7y2nNn6K2vihkb6Kgu9taTiFKzvVeRBwTPnjC9DUcq/QRfvjcc7V1AUmQ2BLKg3+vVj1z8XO7jKTcjUaZJRKN28eXjxcqgwJajoawOnzJ2r6qT5uyjBgRKFErG8K/89m0okmll6iWA2wAUOhPbwlbxEQwkymQzEotOos8y2lCrdpxUs6ipI9Pqudkxt1mO58xs5R8ob2ogfLDYRjzn2FhbVmmjhslg6VULfaOakLiG09HNy81PjBpRvlj6VggZeZ2sD2e7hlcGebtqIuaxBZHn/7dOw26R9TzKCCzyH7gBzl6iMIs+6ywTUp8twssExKz1epd1eqXs7cTAGIobZ778CJghSSCivllQMQgua3Ghf65n0oqyHBnTrkiiwh/nBwbKX5rgrQqUdyGU0DlMrKzKaoYGZElWkioPQ== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39840400002)(39450400003)(39410400002)(39860400002)(39850400002)(377454003)(189002)(199003)(3280700002)(3660700001)(2950100002)(101416001)(305945005)(110136003)(3846002)(102836003)(6916009)(6116002)(4326007)(86362001)(6506006)(7696004)(2906002)(5660300001)(6436002)(25786008)(105586002)(189998001)(122556002)(33656002)(77096006)(50986999)(8676002)(76176999)(106356001)(2900100001)(54356999)(97736004)(68736007)(81166006)(81156014)(9686002)(38730400001)(106116001)(66066001)(8936002)(76576001)(92566002)(7736002)(74316002)(229853002)(142933001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB1934;H:AM4PR04MB1604.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-ms-office365-filtering-correlation-id: 1c7cc559-2661-48d2-eb85-08d428292bbc x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:VI1PR0401MB1934; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(6072148)(6047074);SRVR:VI1PR0401MB1934;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB1934; x-forefront-prvs: 01613DFDC8 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2016 16:07:45.7393 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB1934 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBJGeHPn022985 > From: David Miller [mailto:davem@davemloft.net] > Sent: Monday, December 19, 2016 5:37 PM > > From: Madalin Bucur > Date: Mon, 19 Dec 2016 11:22:20 +0200 > > > The fsl/fman drivers will use of_platform_populate() on all > > supported platforms. > > > > Signed-off-by: Madalin Bucur > > It seems that this creates a failure point between patches #2 and > #3. If the cases handled by this "fsl,fman" entry are only afterwards > covered by the of_platform_populate() code added in patch #3 then you > cannot split these two changes up like this. > > The two changes must be done at the same time, otherwise probing will > fail for some people between patches #2 and #3. You are right, that will happen. I was not convinced these need to be merged due to the different places they touch. I'll send a v3.