From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756969AbcLPThO (ORCPT ); Fri, 16 Dec 2016 14:37:14 -0500 Received: from mail-db5eur01on0043.outbound.protection.outlook.com ([104.47.2.43]:31065 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753248AbcLPThE (ORCPT ); Fri, 16 Dec 2016 14:37:04 -0500 From: Madalin-Cristian Bucur To: Scott Wood , "netdev@vger.kernel.org" , "mpe@ellerman.id.au" CC: "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "davem@davemloft.net" Subject: RE: [upstream-release] [PATCH net 2/4] fsl/fman: arm: call of_platform_populate() for arm64 platfrom Thread-Topic: [upstream-release] [PATCH net 2/4] fsl/fman: arm: call of_platform_populate() for arm64 platfrom Thread-Index: AQHSVwLgE4U5gdiPvEahcp5AQWsuI6EKygAA Date: Fri, 16 Dec 2016 17:01:41 +0000 Message-ID: References: <1481807497-4724-1-git-send-email-madalin.bucur@nxp.com> <1481807497-4724-3-git-send-email-madalin.bucur@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=madalin.bucur@nxp.com; x-originating-ip: [192.88.146.1] x-microsoft-exchange-diagnostics: 1;VI1PR0401MB1936;7:ytDxhKdJ3gTsWzIC7hXwKwDB9EEo3AyrGaviLnKWj6oyBsMQ7a21lFpQy1fWQhEiFtmcTg3cSA/5cFm5tnIRYZVSoglT4xJSrEkV3Gv4gWWwimlRq3nidXb1mKP5PVLwTOWLVmFI12M0garahq0t6IfIGXK+4xbgz0jmzskk8tAX2MIqOP7eJZ65LKRCv+xQjLMWX34J76plGyLs6P278XuKkU93fxTUaRTBCgGXFEWq+3KZoXo1olHKxADUA45hlGIkWUz/yvgKJRkdouofBUrjo8QHwThZV6hF8BUa1KuTkzSqz40lY6MjLxl1qcN7NFx9d4vvNeIxE2HvkBXocavFFaReEV5eVa1CB/Z9Rhi/+tZ63bSNYaw9pUtmYHoI0pfH+ft0inX3ZwMIBNaOs5zc25UHThX16OxosE4Td+oCyuSady0WbjYHi7EoOJdpLytvi6ek4LtOLQuLDWtJDQ== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39840400002)(39450400003)(39850400002)(39410400002)(39860400002)(24454002)(377454003)(189002)(199003)(66066001)(97736004)(5001770100001)(81166006)(2900100001)(76576001)(86362001)(2201001)(76176999)(50986999)(4326007)(68736007)(3660700001)(54356999)(2906002)(3280700002)(6506006)(33656002)(229853002)(8936002)(77096006)(9686002)(92566002)(81156014)(105586002)(106116001)(106356001)(7696004)(3846002)(122556002)(189998001)(25786008)(102836003)(6116002)(5660300001)(74316002)(2501003)(2950100002)(7736002)(305945005)(6436002)(101416001)(38730400001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB1936;H:AM4PR04MB1604.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-ms-office365-filtering-correlation-id: 73d294c1-ffe6-4c64-a355-08d425d534e9 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:VI1PR0401MB1936; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(101931422205132); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123560025)(20161123564025)(20161123555025)(20161123558021)(6072148)(6047074);SRVR:VI1PR0401MB1936;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB1936; x-forefront-prvs: 01583E185C spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2016 17:01:41.0580 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB1936 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBGJbLgR006606 > From: Scott Wood > Sent: Thursday, December 15, 2016 8:42 PM > > On 12/15/2016 07:11 AM, Madalin Bucur wrote: > > From: Igal Liberman > > > > Signed-off-by: Igal Liberman > > --- > > drivers/net/ethernet/freescale/fman/fman.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/net/ethernet/freescale/fman/fman.c > b/drivers/net/ethernet/freescale/fman/fman.c > > index dafd9e1..f36b4eb 100644 > > --- a/drivers/net/ethernet/freescale/fman/fman.c > > +++ b/drivers/net/ethernet/freescale/fman/fman.c > > @@ -2868,6 +2868,16 @@ static struct fman *read_dts_node(struct > platform_device *of_dev) > > > > fman->dev = &of_dev->dev; > > > > +#ifdef CONFIG_ARM64 > > + /* call of_platform_populate in order to probe sub-nodes on arm64 */ > > + err = of_platform_populate(fm_node, NULL, NULL, &of_dev->dev); > > + if (err) { > > + dev_err(&of_dev->dev, "%s: of_platform_populate() failed\n", > > + __func__); > > + goto fman_free; > > + } > > +#endif > > Should we remove fsl,fman from the PPC of_device_ids[], so this doesn't > need an ifdef? > > Why is it #ifdef CONFIG_ARM64 rather than #ifndef CONFIG_PPC? > > -Scott Igal was working on adding ARM64 support when this patch was created, thus the choice of #ifdef CONFIG_ARM64. Unifying this for PPC and ARM64 by always calling of_platform_populate() sounds like the best approach. I would need to synchronize the introduction of this code with the removal of the fsl,fman entry from the of_device_ids[] array. Dave, Michael, Scott, is it ok to add to v2 of this patch set the patch that removes the compatible "fsl,fman" from arch/powerpc/platforms/85xx/corenet_generic.c? Thanks, Madalin