From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226iEObWThWR/WlBnPXBhlrtGvD3G//glwsfTiiyWEgUpvJNvx4JXWtPW1o3JGZSJhywEPhw ARC-Seal: i=1; a=rsa-sha256; t=1517029697; cv=none; d=google.com; s=arc-20160816; b=sXz7E3lgV8gOAeIQajx9J0J+GMAJPX3JC+7P0Zs3PBV8PW0W3i4+CIq/WYtcJtDjJn +zyX4SqYzINZexUoBEsyQ2WOTpjsPKvy9AwNyLbNw8QU7iEjOKIxUfyl7xF2jRhyEbwP c9zS6it+D/xh1aWFvahTrAb9n6oGYS0epsUFRw4d2v9UJUUa73PazwN/75+SjUVSFiAn 1c7tpRvOmzDFP8uZiMG0Da8eU9jqaNckVNzU/tJchSpW/Aqzo0LxgMqHDtufJkY4dHIN BGi/OyXqe6lo1clGBqLnV2zIK/fZmyWrvvm9v9EZNraSNspYHYoy0sUAY2WzG1PdgDx/ MAAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:spamdiagnosticmetadata :spamdiagnosticoutput:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:dkim-signature:arc-authentication-results; bh=ogFY3JKrdiJL6QFYp3V0GIoUijj6chq7q7XnRjvxgeU=; b=FsbMRLMSLYAs2zGMCSLkI8lyUtH/QleuLv0eWyOHr/GW4GqXkyTU/VJ8R4m9RQxbXK JfPvSh7rKK/4+hK94D0ng8EGKye4GYA4HstcELySW0i7hXuEEkZ6zzPWuOsdT27PKoiF jWfiSdiydUPYTkXgXFSFI7HX6C0pjNZ0yJoUl+Tu6kH+/6IcwxdXGEVOkxDM81eb2o1z xbIMAMN1h32kCtvkw8/gkpMe6u/3h0cjDeGhxdpJ8lHvRNscxx19SP6xZOC8OjGeRVtk MhTMpM7V4jsK1trjei9H7894X3XEUsZqP/Z3Nmb1nQyd0yKtMr47/c8ActaLD/aHzaIc lTEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector1 header.b=YPqKCHao; spf=pass (google.com: domain of vadimp@mellanox.com designates 104.47.0.62 as permitted sender) smtp.mailfrom=vadimp@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Authentication-Results: mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector1 header.b=YPqKCHao; spf=pass (google.com: domain of vadimp@mellanox.com designates 104.47.0.62 as permitted sender) smtp.mailfrom=vadimp@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com From: Vadim Pasternak To: Darren Hart CC: "andy.shevchenko@gmail.com" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "jiri@resnulli.us" Subject: RE: [patch v11 - re-ordered 03/12] FIXME platform/mellanox: Remove redundant dev_err messages on device_create Thread-Topic: [patch v11 - re-ordered 03/12] FIXME platform/mellanox: Remove redundant dev_err messages on device_create Thread-Index: AQHTlUJ1K9yVCb8nYUWmV/lRRw7VkKOFIXWAgAEmzzCAAIuIgIAAWr7A Date: Sat, 27 Jan 2018 05:08:13 +0000 Message-ID: References: <1516826019-124903-1-git-send-email-vadimp@mellanox.com> <20180125214643.GB24122@fury> <20180126234117.GB3736@fury> In-Reply-To: <20180126234117.GB3736@fury> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=vadimp@mellanox.com; x-originating-ip: [46.120.54.214] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM4PR05MB3156;7:Lm2Fg9FaXB0uOQJa3BxBqWThAraBNvhq74AgK6f/Op2JxR8ynyMUbAkAPLWCUgcWLp846Pi4pRf6b0yn3DIn+kDuWzy59bZYmkFaFWm9dOtlLcIZpIbXvhpT/E5tVliTlneTSrgXZSzcc0+McX0e07YSSVEf7ugh1UzraGTXsbu3yUZSCkiuWYB2qBe6r8XM5fuVfgUUo+K6l9fjXDOl55xvqFkwjQmm9jYWFA9EahdT8P490aIdAfYst9idUi88 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d77842f9-536e-4b58-5f38-08d56543f7de x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:AM4PR05MB3156; x-ms-traffictypediagnostic: AM4PR05MB3156: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(85827821059158)(17755550239193); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(8121501046)(5005006)(3002001)(3231082)(2400081)(944501161)(93006095)(93001095)(10201501046)(6055026)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011);SRVR:AM4PR05MB3156;BCL:0;PCL:0;RULEID:;SRVR:AM4PR05MB3156; x-forefront-prvs: 056544FBEE x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(366004)(376002)(346002)(396003)(39380400002)(13464003)(189003)(199004)(33656002)(99286004)(74316002)(229853002)(2906002)(54906003)(14454004)(478600001)(316002)(7736002)(5250100002)(305945005)(53936002)(3846002)(6436002)(6116002)(39060400002)(4326008)(6246003)(25786009)(106356001)(68736007)(81166006)(81156014)(55016002)(8676002)(8936002)(9686003)(26005)(186003)(5660300001)(7696005)(76176011)(53546011)(6506007)(97736004)(15650500001)(102836004)(59450400001)(105586002)(6916009)(2950100002)(3660700001)(93886005)(86362001)(2900100001)(66066001)(3280700002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR05MB3156;H:AM4PR05MB3330.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: mbIX18deP1TFlXw58UkRvotwnsZQYo0scG/ya+TaMy89hAHEpmPtrOwl+Q64rNYzkFlVcYhE0byR1Ljy+e/BfQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d77842f9-536e-4b58-5f38-08d56543f7de X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2018 05:08:13.7303 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3156 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590500036473711477?= X-GMAIL-MSGID: =?utf-8?q?1590720932611690500?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: > -----Original Message----- > From: Darren Hart [mailto:dvhart@infradead.org] > Sent: Saturday, January 27, 2018 1:41 AM > To: Vadim Pasternak > Cc: andy.shevchenko@gmail.com; gregkh@linuxfoundation.org; linux- > kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; jiri@resnull= i.us > Subject: Re: [patch v11 - re-ordered 03/12] FIXME platform/mellanox: Remo= ve > redundant dev_err messages on device_create >=20 > On Fri, Jan 26, 2018 at 04:59:32PM +0000, Vadim Pasternak wrote: > > > > > > > -----Original Message----- > > > From: Darren Hart [mailto:dvhart@infradead.org] > > > Sent: Thursday, January 25, 2018 11:47 PM > > > To: Vadim Pasternak > > > Cc: andy.shevchenko@gmail.com; gregkh@linuxfoundation.org; linux- > > > kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; > > > jiri@resnulli.us > > > Subject: Re: [patch v11 - re-ordered 03/12] FIXME platform/mellanox: > > > Remove redundant dev_err messages on device_create > > > > > > On Wed, Jan 24, 2018 at 08:33:37PM +0000, Vadim Pasternak wrote: > > > > The upper layer will manage and report errors returned by the > > > > create and destroy functions. > > > > > > > > FIXME: but it doesn't - we don't even check > > > > > > I think we agreed to just drop this patch entirely, since this error > > > is not checked elsewhere? Keeping the dev_err messages? > > > > > > > Yes, we'll keep it. > > We just had conflict in patch order and I wanted to fix it, staying as > > much as possible aligned with the top of mellanox v10 branch. > > > > However currently we still have a problem in mellanox v11 after patch > > platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface It > > dropped parameter device in mlxreg_hotplug_device_create, which is > > Used inside the routine. > > > > I'll send a separate patch to fix it from top of v11. In other case > > it'll be necessary to fix Modify to use a regmap interface and > > re-send all from 5-th patch in series. > > > > Also we should drop the patch: > > platform/x86: mlx-platform: Simplify IO access to regmap context It > > introduced the issue reported by sparse. > > > > I am resending two last patches from review-dvhart-mellanox-v11 branch > > and also patch with fix for mlxreg_hotplug_device_create, as: > > 0010-platform-x86-mlx-platform-Extend-register-map-config.patch > > 0011-platform-mellanox-mlxreg-hotplug-Add-check-for-negat.patch > > 0012-platform-mellanox-mlxreg-hotplug-Fix-issue-of-commit.patch > > > > Thank you very much for your help, >=20 > OK, please see review-dvhart-mellanox-v12 on infradead or github. I've ve= rified > this passes a clean C=3D1 (sparse) build at each patch. I believe this is= in a state > that can be moved to testing. Please confirm. >=20 Confirmed. > If you still want to move the dev_err messages out of the create function= , we > can do that separately. Let's get this merged so we can move forward. >=20 It's OK with me. Let's leave it as it is now. Thank you, Vadim. > -- > Darren Hart > VMware Open Source Technology Center