From: Vadim Pasternak <vadimp@mellanox.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] platform/mellanox: mlxreg-hotplug: Fix uninitialized variable
Date: Wed, 7 Feb 2018 09:39:22 +0000 [thread overview]
Message-ID: <AM4PR05MB3330B66B4D7077DA6EAB882EA2FC0@AM4PR05MB3330.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1517994724-5931-1-git-send-email-geert@linux-m68k.org>
> -----Original Message-----
> From: Geert Uytterhoeven [mailto:geert@linux-m68k.org]
> Sent: Wednesday, February 07, 2018 11:12 AM
> To: Andy Shevchenko <andy@infradead.org>; Darren Hart
> <dvhart@infradead.org>; Vadim Pasternak <vadimp@mellanox.com>
> Cc: Arnd Bergmann <arnd@arndb.de>; platform-driver-x86@vger.kernel.org;
> linux-kernel@vger.kernel.org; Geert Uytterhoeven <geert@linux-m68k.org>
> Subject: [PATCH] platform/mellanox: mlxreg-hotplug: Fix uninitialized variable
>
> With gcc-4.1.2:
>
> drivers/platform/mellanox/mlxreg-hotplug.c: In function
> ‘mlxreg_hotplug_health_work_helper’:
> drivers/platform/mellanox/mlxreg-hotplug.c:347: warning: ‘ret’ is used
> uninitialized in this function
>
> Indeed, if mlxreg_core_item.count is zero, ret is used uninitialized.
>
> While this is unlikely to happen (it is set to ARRAY_SIZE(...) in x86 board files),
> this is done in another source file, so fix this by preinitializing ret to zero.
>
> Fixes: c6acad68eb2dbffd ("platform/mellanox: mlxreg-hotplug: Modify to use a
> regmap interface")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
> ---
> drivers/platform/mellanox/mlxreg-hotplug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c
> b/drivers/platform/mellanox/mlxreg-hotplug.c
> index 0dfa1ca0d05b0217..313cf8ad77bf68ce 100644
> --- a/drivers/platform/mellanox/mlxreg-hotplug.c
> +++ b/drivers/platform/mellanox/mlxreg-hotplug.c
> @@ -300,7 +300,7 @@ mlxreg_hotplug_health_work_helper(struct
> mlxreg_hotplug_priv_data *priv, {
> struct mlxreg_core_data *data = item->data;
> u32 regval;
> - int i, ret;
> + int i, ret = 0;
>
> for (i = 0; i < item->count; i++, data++) {
> /* Mask event. */
> --
> 2.7.4
prev parent reply other threads:[~2018-02-07 9:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 9:12 Geert Uytterhoeven
2018-02-07 9:39 ` Vadim Pasternak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB3330B66B4D7077DA6EAB882EA2FC0@AM4PR05MB3330.eurprd05.prod.outlook.com \
--to=vadimp@mellanox.com \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=dvhart@infradead.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®