From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757536AbcIGNj5 (ORCPT ); Wed, 7 Sep 2016 09:39:57 -0400 Received: from mail-db5eur01on0046.outbound.protection.outlook.com ([104.47.2.46]:19485 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751499AbcIGNjz (ORCPT ); Wed, 7 Sep 2016 09:39:55 -0400 From: Vadim Pasternak To: Jacek Anaszewski , "rpurdie@rpsys.net" CC: "linux-leds@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jiri@resnulli.us" , Michael Shych Subject: RE: [patch 2/2] leds: add driver for Mellanox systems leds Thread-Topic: [patch 2/2] leds: add driver for Mellanox systems leds Thread-Index: AQHSCQb7XMjIc6oTTE2v2AjH3SUBX6BuAGeAgAABLOA= Date: Wed, 7 Sep 2016 13:39:52 +0000 Message-ID: References: <1473259995-196607-1-git-send-email-vadimp@mellanox.com> <821b4b7a-aa0b-293d-01d0-722094c1bc12@samsung.com> In-Reply-To: <821b4b7a-aa0b-293d-01d0-722094c1bc12@samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=vadimp@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-office365-filtering-correlation-id: 19f2cb83-8597-4ab9-3107-08d3d7247253 x-microsoft-exchange-diagnostics: 1;DB5PR05MB1271;6:xDdigv6Mtndc9k/jvf461TbhruF0i6nwr3W00I/YOEL67h2+G6HPR3PxSFKOpcz04JoGRlYLX3AhRjdkkquGj602BZy0pA51XXgF6e6A9ZBy9sZGcOZbHoMLXQdBPQuzOeztI6kTSP/U9Ffwy1bQEg+V7bDiVwhXoHwKjx3MgsS57ULMvg9ptNcSz0L3Mhm6oSnmjKzGwqvJH6vWA5roiuomfYoIj9kA2WPAAylqLw4erWirM6+6lMunAA8hAQFghC9ZOHoTC2Oq8Mjz2vAOloTD7LAGyuJyi8zD0y0enrEBbNx3nu1R67+ZyhZrmZcpcGqshwSNuTZQj3PM/r93lw==;5:v1uCfUvDCpUiF5beTbmCFR09f+WfgR0tcR26wVyK3xQXooWk+OKW86LvFdghWAS34kKSsycDJyTRDHjh3uYTY42ZCmT/TAnWuvK2wSfbfiI//HBNp2ZOfO6CYpOofqy5pnzHE0+Mx27Q1AyfoquiRw==;24:cizvs5d9zgcGGj39HQxvQib0NWcAAS90HPZ+byyfqh5PRh125I/UqKMG5FZqFQrMKO9v8OHIrgqKthyuOulv1x3yhMv5rnovCvbuSTWxsRg=;7:d+9GL+iUHXgYQWtq+prnaMoS/VVLcZLW25H89tiGhPn1pJ0QGOJwR6VzFcdUgcU8SSu/TtJ0z9DgMvIL5lbqfzYibAF4bAPO5dLfRfhaH24dDZOvmzlixiSVdFBlnVXC9jwytbaRnLxr2GlqOmFDtH0EPqDyVq5Gp9eph1BKDzLnci18xaNG8eNAfr3UgaWf4Tfsl3wKlucl3/X6bd3o2Zxl8e0mSh8zizCKEzw255UWhnqdz1X75A4nAKwB72Oe x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR05MB1271; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(7411616537696); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:DB5PR05MB1271;BCL:0;PCL:0;RULEID:;SRVR:DB5PR05MB1271; x-forefront-prvs: 0058ABBBC7 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(377454003)(13464003)(24454002)(189002)(199003)(2950100001)(4001430100002)(586003)(106356001)(77096005)(106116001)(105586002)(8936002)(19580405001)(81156014)(122556002)(19580395003)(3660700001)(2900100001)(6116002)(2906002)(11100500001)(3280700002)(107886002)(5001770100001)(50986999)(305945005)(97736004)(7696003)(7736002)(7846002)(66066001)(33656002)(68736007)(4326007)(9686002)(92566002)(189998001)(101416001)(76576001)(87936001)(5002640100001)(81166006)(3846002)(102836003)(54356999)(86362001)(76176999)(575784001)(2501003)(8676002)(10400500002)(5660300001)(74316002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR05MB1271;H:AM5PR0501MB2097.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2016 13:39:52.5009 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1271 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u87De3pP016338 Hi Jacek, The patch 2/2 I sent after Dave's review. Now I have patch 1/2 and patch 2/2, produced with git format-patch -2 HEAD ... But 1/2 is re-work after your comments. Would it be OK if I produce now new patch with all fixes as [patch v1], and starting from this point will follow [patch v2], etc? Sorry for this mess. Thanks, Vadim. > -----Original Message----- > From: Jacek Anaszewski [mailto:j.anaszewski@samsung.com] > Sent: Wednesday, September 07, 2016 4:11 PM > To: Vadim Pasternak ; rpurdie@rpsys.net > Cc: linux-leds@vger.kernel.org; linux-kernel@vger.kernel.org; jiri@resnulli.us; > Michael Shych > Subject: Re: [patch 2/2] leds: add driver for Mellanox systems leds > > Hi Vadim, > > Please use git format-patch -n, where n is the number of patches to be produced > starting from your current git HEAD. > > It will produce patches tagged [PATCH 1/2], [PATCH 2/2], or starting from > [PATCH 0/2] when added --cover-letter switch. > > Now it looks as if this patch was a part of the patch set comprising two patches, > but I don't see the first one. > I assume that you added the numbering by hand and this one was intended to be > put in the one set with the following one: > > [patch] leds: add driver for Mellanox systems leds > > On 09/07/2016 04:53 PM, vadimp@mellanox.com wrote: > > From: Vadim Pasternak > > > > Fix in comments 3KHz and 6KHz to 3Hz and 6Hz respectively. > > > > Signed-off-by: Vadim Pasternak > > --- > > drivers/leds/leds-mlxcpld.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/leds/leds-mlxcpld.c b/drivers/leds/leds-mlxcpld.c > > index 0ec2375..eeed35c 100644 > > --- a/drivers/leds/leds-mlxcpld.c > > +++ b/drivers/leds/leds-mlxcpld.c > > @@ -47,8 +47,8 @@ > > #define MLXPLAT_CPLD_LPC_REG_BASE_ADRR 0x2500 /* LPC bus access */ > > > > /* Color codes for leds */ > > -#define LED_OFFSET_HALF 0x01 /* Offset from solid for 3KHz blink > */ > > -#define LED_OFFSET_FULL 0x02 /* Offset from solid for 6KHz blink > */ > > +#define LED_OFFSET_HALF 0x01 /* Offset from solid for 3Hz blink > */ > > +#define LED_OFFSET_FULL 0x02 /* Offset from solid for 6Hz blink > */ > > #define LED_IS_OFF 0x00 /* Off */ > > #define LED_RED_STATIC_ON 0x05 /* Solid red */ > > #define LED_RED_BLINK_HALF (LED_RED_STATIC_ON + > LED_OFFSET_HALF) > > @@ -237,7 +237,7 @@ static void mlxcpld_led_store_hw(u8 mask, u8 off, u8 > vset) > > /* Each led is controlled through low or high nibble of the relevant > > * CPLD register. Register offset is specified by off parameter. > > * Parameter vset provides color code: 0x0 for off, 0x5 for solid red, > > - * 0x6 for 3KHz blink red, 0xd for solid green, 0xe for 3KHz blink > > + * 0x6 for 3Hz blink red, 0xd for solid green, 0xe for 3Hz blink > > * green. > > * Parameter mask specifies which nibble is used for specific led: mask > > * 0xf0 - lower nibble is to be used (bits from 0 to 3), mask 0x0f - > > @@ -274,8 +274,8 @@ static int mlxcpld_led_blink(struct led_classdev > > *led, { > > struct mlxcpld_led_priv *pled = cdev_to_priv(led); > > > > - /* HW supports two types of blinking: full (6KHz) and half (3KHz). > > - * For delay on/off zero default setting 3KHz is used. > > + /* HW supports two types of blinking: full (6Hz) and half (3Hz). > > + * For delay on/off zero default setting 3Hz is used. > > */ > > if (!(*delay_on == 0 && *delay_off == 0) && > > !(*delay_on == LED_BLINK_3HZ && *delay_off == LED_BLINK_3HZ) > && > > > > > -- > Best regards, > Jacek Anaszewski