From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753386AbcI1Msu (ORCPT ); Wed, 28 Sep 2016 08:48:50 -0400 Received: from mail-db5eur01on0075.outbound.protection.outlook.com ([104.47.2.75]:43008 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753182AbcI1Msm (ORCPT ); Wed, 28 Sep 2016 08:48:42 -0400 From: Vadim Pasternak To: Greg KH CC: "dvhart@infradead.org" , "davem@davemloft.net" , "geert@linux-m68k.org" , "akpm@linux-foundation.org" , "kvalo@codeaurora.org" , "mchehab@kernel.org" , "linux@roeck-us.net" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "jiri@resnulli.us" Subject: RE: [patch v1] drivers/platform/x86: introduce support for Mellanox hotplug driver Thread-Topic: [patch v1] drivers/platform/x86: introduce support for Mellanox hotplug driver Thread-Index: AQHSFMK0yFEOAYkzuUmQ9j2sM4vq26CFcLoAgAAHHSCAAA0pAIAAAQmAgAABwgCACVu20A== Date: Wed, 28 Sep 2016 12:48:37 +0000 Message-ID: References: <1474550067-142107-1-git-send-email-vadimp@mellanox.com> <20160922123038.GA2630@kroah.com> <20160922134312.GA30274@kroah.com> <20160922135312.GA13047@kroah.com> In-Reply-To: <20160922135312.GA13047@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=vadimp@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-office365-filtering-correlation-id: 643982fe-7c1c-45d5-7797-08d3e79dc41c x-microsoft-exchange-diagnostics: 1;AM5PR0501MB2098;6:7QgMK72GL0e2m6USw3Hjk6scJhJEjO/oW7umD34eZRL+fka3NvjJWGe2pGYXu38WtUQKQGOZ4rxB1o0zlDvf5nADaNjfT6J+vwwRqiWx+Qup9Rmk2eVCv6m4KGM1VsyO9wKixD6ag657tOWsGiT7VVi8AEiHYcBR+fGMqPB/2E6UcX6UtOqjyYP/WLZQ4nFR+PGOeSNbBvRWo69IyxDMv/nif+lW7IF6oBiwcKF9sMZ7K2Mhdj1nRQRx9s858qCMnTm+gt0Azm07DFQa6osmm/OHM9WeFlmS4+eGCLfY/slWhJBZgeUcwWRFGM7YT3YNfajuOG8UHEgGMsdjvLINdA==;5:fW09GrrqQXTncSZyRyv4UUB0IGW80Ratzz2cecUq90M2mAup9ymzYcVzsTSH/b9Up37nf7JmMYZmJvhEafydq+CxpMPSqGerZVQ9dn3EbuBi7JMOphtXUS63gUfs40z8oEwZGfU1ekmq+KgkR1a8bA==;24:eQQ4dIYYWKrX2ufYk9Uvndxe9jJtddlWAQn2A9FG50NROx+nLf0VmvMxbMKFclKoj2Q2FJtjBwOXOfqD15tCc7pvSlUOgS7q/kawkFOWZ6o=;7:g7dgJ22DQG4HSqDtvCUbUsGTYAJnaYELB60vN/nAawCmWWcjndiY79MM/QxuqpUB2wBC/gVcI4Dzepn365BMhVRK4odHwv/A/BC1NnOLtqAjJsCQ3AURRbM6dzJZknb65GKasnJTTFXP/w9uAA5jtNjZzaLzFFBLVgcemq4q3pQJfA5KV8VO6tzUthzEPsDEAPYWpxTRzXXINNb9EdeTK0/6RtNxAeygwpyEwlO9MngPw+fPCV25C5bbKpbA4NAKaqDoQjIEdZOSixOpJSsogXuvOpuFHwQavUScSU7QMf0rJ689PcqLzMONosNh0NXq x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0501MB2098; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:AM5PR0501MB2098;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0501MB2098; x-forefront-prvs: 0079056367 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(377454003)(189002)(199003)(13464003)(24454002)(66066001)(101416001)(3660700001)(122556002)(86362001)(33656002)(97736004)(189998001)(8936002)(92566002)(54356999)(7696004)(50986999)(7846002)(7416002)(76176999)(110136003)(7736002)(6916009)(8676002)(2950100002)(2900100001)(5660300001)(106356001)(106116001)(105586002)(305945005)(19580395003)(93886004)(19580405001)(9686002)(81166006)(81156014)(74316002)(77096005)(3280700002)(76576001)(4326007)(10400500002)(3846002)(68736007)(2906002)(102836003)(5002640100001)(11100500001)(6116002)(586003)(87936001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0501MB2098;H:AM5PR0501MB2097.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2016 12:48:37.3872 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2098 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u8SCmu8x015030 > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Thursday, September 22, 2016 4:53 PM > To: Vadim Pasternak > Cc: dvhart@infradead.org; davem@davemloft.net; geert@linux-m68k.org; > akpm@linux-foundation.org; kvalo@codeaurora.org; mchehab@kernel.org; > linux@roeck-us.net; linux-kernel@vger.kernel.org; platform-driver- > x86@vger.kernel.org; jiri@resnulli.us > Subject: Re: [patch v1] drivers/platform/x86: introduce support for Mellanox > hotplug driver > > On Thu, Sep 22, 2016 at 01:50:28PM +0000, Vadim Pasternak wrote: > > > > > > > -----Original Message----- > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > Sent: Thursday, September 22, 2016 4:43 PM > > > To: Vadim Pasternak > > > Cc: dvhart@infradead.org; davem@davemloft.net; geert@linux-m68k.org; > > > akpm@linux-foundation.org; kvalo@codeaurora.org; mchehab@kernel.org; > > > linux@roeck-us.net; linux-kernel@vger.kernel.org; platform-driver- > > > x86@vger.kernel.org; jiri@resnulli.us > > > Subject: Re: [patch v1] drivers/platform/x86: introduce support for > > > Mellanox hotplug driver > > > > > > On Thu, Sep 22, 2016 at 01:01:46PM +0000, Vadim Pasternak wrote: > > > > > > > > > > > > > -----Original Message----- > > > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > > > Sent: Thursday, September 22, 2016 3:31 PM > > > > > To: Vadim Pasternak > > > > > Cc: dvhart@infradead.org; davem@davemloft.net; > > > > > geert@linux-m68k.org; akpm@linux-foundation.org; > > > > > kvalo@codeaurora.org; mchehab@kernel.org; linux@roeck-us.net; > > > > > linux-kernel@vger.kernel.org; platform-driver- > > > > > x86@vger.kernel.org; jiri@resnulli.us > > > > > Subject: Re: [patch v1] drivers/platform/x86: introduce support > > > > > for Mellanox hotplug driver > > > > > > > > > > On Thu, Sep 22, 2016 at 01:14:27PM +0000, vadimp@mellanox.com > wrote: > > > > > > From: Vadim Pasternak > > > > > > > > > > > > Enable system support for the Mellanox Technologies hotplug > > > > > > platform driver, which provides support for the next Mellanox > > > > > > basic > > > systems: > > > > > > "msx6710", "msx6720", "msb7700", "msn2700", "msx1410", > > > > > > "msn2410", "msb7800", "msn2740", "msn2100" and also various > > > > > > number of derivative systems from the above basic types. > > > > > > This driver handles hot-plug events for the power suppliers, > > > > > > power cables and fans for the above systems. > > > > > > > > > > > > The Kconfig currently controlling compilation of this code is: > > > > > > driver/platform/x86:config MLX_CPLD_PLATFORM > > > > > > tristate "Mellanox platform hotplug driver support" > > > > > > > > > > > > Signed-off-by: Vadim Pasternak > > > > > > --- > > > > > > MAINTAINERS | 7 + > > > > > > drivers/platform/x86/Kconfig | 10 + > > > > > > drivers/platform/x86/Makefile | 1 + > > > > > > drivers/platform/x86/mlxcpld-hotplug.c | 543 > > > > > ++++++++++++++++++++++++++ > > > > > > include/linux/platform_data/mlxcpld-hotplug.h | 90 +++++ > > > > > > > > > > Why do you need a platform_data .h file for a stand-alone driver? > > > > > > > > > > > > > I have another module mlx-platform, which is reviewed now (I also > > > > got a number feedbacks from you on this matter). I want to > > > > activate mlxcpld-hotplug from this module. > > > > > > Ah. Hm, I thought "platform_data" was depreciated. Really, there > > > is no way to put this in acpi or device tree? This feels so 1990's... > > > > > > > I can't put in ACPI, since we don't have it. > > Regarding device tree - I know how to do it for ARM and PPC, but I didn't find > some good examples for x86. > > Maybe you can give me some reference for that? > > I have no idea, sorry :( Hi, I'd like to kindly clarify whether the patch I sent could be applied, or I need to modify something? Best regards, Vadim.