From: Aisheng Dong <aisheng.dong@nxp.com>
To: Peng Fan <peng.fan@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux@rempel-privat.de" <linux@rempel-privat.de>,
Leonard Crestez <leonard.crestez@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 3/4] firmware: imx: scu-pd: ignore power domain not owned
Date: Thu, 23 Apr 2020 10:06:54 +0000 [thread overview]
Message-ID: <AM6PR04MB4966F8E07B105EDCAF3CB40680D30@AM6PR04MB4966.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1587625174-32668-4-git-send-email-peng.fan@nxp.com>
> From: Peng Fan <peng.fan@nxp.com>
> Sent: Thursday, April 23, 2020 3:00 PM
>
> Should not register power domain that not owned by current partition.
>
> Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/firmware/imx/scu-pd.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
> index d1b313fa7b96..7b43bd63cc1e 100644
> --- a/drivers/firmware/imx/scu-pd.c
> +++ b/drivers/firmware/imx/scu-pd.c
> @@ -46,6 +46,7 @@
>
> #include <dt-bindings/firmware/imx/rsrc.h> #include
> <linux/firmware/imx/sci.h>
> +#include <linux/firmware/imx/svc/rm.h>
> #include <linux/io.h>
> #include <linux/module.h>
> #include <linux/of.h>
> @@ -246,6 +247,9 @@ imx_scu_add_pm_domain(struct device *dev, int idx,
> struct imx_sc_pm_domain *sc_pd;
> int ret;
>
> + if (!imx_sc_rm_is_resource_owned(pm_ipc_handle, pd_ranges->rsrc + idx))
> + return NULL;
> +
Same question.
See my comment on patch 2/4.
Regards
Aisheng
> sc_pd = devm_kzalloc(dev, sizeof(*sc_pd), GFP_KERNEL);
> if (!sc_pd)
> return ERR_PTR(-ENOMEM);
> --
> 2.16.4
next prev parent reply other threads:[~2020-04-23 10:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 6:59 [PATCH 0/4] firmware: imx: fix/update cm4 and add resource check peng.fan
2020-04-23 6:59 ` [PATCH 1/4] firmware: imx: scu-pd: fix cm40 power domain peng.fan
2020-04-23 10:02 ` Aisheng Dong
2020-04-23 6:59 ` [PATCH 2/4] firmware: imx: add resource management api peng.fan
2020-04-23 10:04 ` Aisheng Dong
2020-04-23 10:57 ` Peng Fan
2020-04-23 14:04 ` Aisheng Dong
2020-04-24 1:11 ` Peng Fan
2020-04-24 2:04 ` Aisheng Dong
2020-06-01 12:40 ` Peng Fan
2020-06-02 2:41 ` Aisheng Dong
2020-06-02 4:50 ` Peng Fan
2020-06-02 7:28 ` Aisheng Dong
2020-06-02 7:47 ` Peng Fan
2020-06-02 9:07 ` Aisheng Dong
2020-06-02 3:07 ` Aisheng Dong
2020-06-02 5:23 ` Peng Fan
2020-06-02 7:12 ` Aisheng Dong
2020-04-23 6:59 ` [PATCH 3/4] firmware: imx: scu-pd: ignore power domain not owned peng.fan
2020-04-23 10:06 ` Aisheng Dong [this message]
2020-04-23 6:59 ` [PATCH 4/4] firmware: imx: scu-pd: add more cm4 resources peng.fan
2020-04-23 10:33 ` Aisheng Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR04MB4966F8E07B105EDCAF3CB40680D30@AM6PR04MB4966.eurprd04.prod.outlook.com \
--to=aisheng.dong@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=peng.fan@nxp.com \
--cc=qiangqing.zhang@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®