From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013062.outbound.protection.outlook.com [40.107.159.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89D9F2FBE08; Fri, 10 Oct 2025 16:23:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.62 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760113436; cv=fail; b=mFpKLcjrz66MzLH9WAV3nHagN22uTIQEpMen3UPuZ/J1eMmnSb/dTUNxLnQZEMdHphJidZ1nK9eUy+QZUtIYfOST9SaIrySsA+C2oEr6yvBAbpCafSjhEdNXA2TGZfNL0VDuOed0QCUhe3Q8Exkx+4wVpH+oZekmQCOeNw7alIo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760113436; c=relaxed/simple; bh=QpQ0snk79clkR8GxQmbmsbll3HjhkbuKFZxa0ZJd9zI=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=FVpGCxrwzCWQTwD3JHqIdz/+9XrALkYwPUyLgMkgS0//ODQTMiWN84jWWaca4IoJLasommVM01QPUQPD5v3Hj4nfmgjuw6B8aNOTqsUL0L1BhYxzJorF3bQHAvPIYQ7E8psSXYodsMfn0QBtOoXoqVwJ3Yk8A57YNKQIJ6cDeLw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=HzGfc8Ib; arc=fail smtp.client-ip=40.107.159.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="HzGfc8Ib" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bHIrHZtf2jpGU2oVweSsWccwxbcPcUMkMnpIneTLP79QQVxnoEb1WIP5mpk6TkhuytaTQCA63rV/MeXIuI50oW4qGMCoAG4s1v90uNzQjccdR6A9Cgiz3TpRpQIh0rUwORFWGYFrpr2HBYvJYtiwZTx9Mb0Igkx3wPybbTT5BldC7R9P2qpFm9mn4Pqw7faI+29FYrx9oP0i6N1DgPgMLSgvsO1fSUpvF6dv/aP2swb+4dRGaL5o85CXpnazvHDVjS9IEVkx/VUIbNQFf1z1HVspDSDy/DUstCGXXawOEc9Mq6Qrg46gDuhFOoC5xmeRYPu3OOx3sfMR5Bc+kXKpXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nCfClxFd8Cgo9GcNn7ybbxI6l+p7vGD/DEDWpkn1nio=; b=jqASEK7ibbKS6GHHyH45Dw/zKK+qBHMEo7cmVYoTfv3tmuBuyoqJ1YlbIWgSoAYz61Y3wISrBFVaQgnH28n2rGd58hGDd59wLAYDPx87q8pDasJ+McEOq8QeF+E0bSum+27uIOxfH0PihUPITaRrHRtjtcutjb//FsFtnPEzULph3132cDwZadj7AadH9O1S9COL/H8kDTNu893qRE20CUtzlFBf9TQoK/SQZ9fCu4u8Hmsg2HHLojA5DNMtw2UauNtv0NIqWWbPnX3KSjAtGE6rVqOxCvPT8LwpefglL/t1IgS2HXehVXwxsvkBHRJORe+4tzjh0CntdY3oe9imWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nCfClxFd8Cgo9GcNn7ybbxI6l+p7vGD/DEDWpkn1nio=; b=HzGfc8IbqftS3zi5v6gIJlsAtApIcmXFDZthvW9eAqSj5qXLBuXuTyeB2+APW0A0elxQcNCTDBBu+HbknI3czlaqspPf/wFFawyNXMsTt8Q4YJpmld/h1ga0rXn7+oiq0P3Brfxr1u7gKJwgC0QcEzBRE9gSG7pMDnCeKy6u7Et5N5XwMOl7zRnfAomGQvykZelV+gLdg1U2TRdJ0jPCHtwoAcp8g5ywNtltRhmI7zuX58DIzG+Oc4wExD3JZ/nwld3gcJQHnGnQkY1ZkZvRohoQTgeASz8pByXlJCQCvLUKuMx74vJ5RjfCndZ0g+7TVzw2NyQlULNFFHTZY6T3xw== Received: from AM7PR04MB7142.eurprd04.prod.outlook.com (2603:10a6:20b:113::9) by AM9PR04MB8414.eurprd04.prod.outlook.com (2603:10a6:20b:3ef::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9203.10; Fri, 10 Oct 2025 16:23:50 +0000 Received: from AM7PR04MB7142.eurprd04.prod.outlook.com ([fe80::6247:e209:1229:69af]) by AM7PR04MB7142.eurprd04.prod.outlook.com ([fe80::6247:e209:1229:69af%6]) with mapi id 15.20.9182.017; Fri, 10 Oct 2025 16:23:50 +0000 From: Claudiu Manoil To: Vladimir Oltean , Wei Fang CC: Clark Wang , "andrew+netdev@lunn.ch" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , Frank Li , "imx@lists.linux.dev" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH net] net: enetc: correct the value of ENETC_RXB_TRUESIZE Thread-Topic: [PATCH net] net: enetc: correct the value of ENETC_RXB_TRUESIZE Thread-Index: AQHcOcsjLfa+tXqAmEqFL+MdmHhkNLS7VNgAgAA7RCA= Date: Fri, 10 Oct 2025 16:23:50 +0000 Message-ID: References: <20251010092608.2520561-1-wei.fang@nxp.com> <20251010124846.uzza7evcea3zs67a@skbuf> In-Reply-To: <20251010124846.uzza7evcea3zs67a@skbuf> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM7PR04MB7142:EE_|AM9PR04MB8414:EE_ x-ms-office365-filtering-correlation-id: 1a666cd4-bbf0-4b29-e75d-08de08196571 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|376014|7053199007|38070700021; x-microsoft-antispam-message-info: =?us-ascii?Q?8hp97c9rT7UH7Gc+l0BsyL1+6pwKGCEkZ+lZ0uNDqsEoxNocQ2HwTbC+2OyN?= =?us-ascii?Q?T8Hr6ivIqg4bUWRWhilK0waCbwsuF4XiCzRP55W+WjY+pKUP8FBPCjZbpBTP?= =?us-ascii?Q?IBw/ls4Vhov5WQhC0yUisyCfLtUU30AHF1k6Mzyqt2soNaIZK/u/oUTRKJV1?= =?us-ascii?Q?3VyoZx70xYNh+eZfKrkcBAFZ8AEyVBbhlNbr2SqnR2Mr/aK9fOiV52IcAx26?= =?us-ascii?Q?fALeXfpzGDAIflwOsL+XHuXqrwbiTb3jTwq74cIc5fFYiRCKsymK6fpRXfuZ?= =?us-ascii?Q?mAlSMKHN78etqnk20ZArLLoCJzhTXu/IIZ82Hn2PURSEHC7e3F75DrZ80Ua0?= =?us-ascii?Q?KQUzf3NIvX9nNfo0PUfr01J8y6c+AS9pst8iIRLy1Jbgmjq9rdKXBo3DvKU6?= =?us-ascii?Q?XgN1qwlTGrDHZ2LzUltJRBlxfGtlRj4Kt6Ti2qdt+BEYx4vhPvJ7JdaWW5TY?= =?us-ascii?Q?04x1pVUXxAgF8E5zguFPBShwpx9uFWpYCvRGSESyHRQklQKZRfIc1hVmsbNS?= =?us-ascii?Q?YVnPWMDsMSh37FpQP0e9OS6ylN/it02s9bonJL+uaM/23Ti30zOMz1o2q+h4?= =?us-ascii?Q?4gsqAphYOtKW2iBB+jHIV3CDfwARtwbzaVIwA9oDwJCEMDR84P+a9I20OiGQ?= =?us-ascii?Q?j1LlpVLzhudIhVbPxfI+8IrHeEmPEtGbXSEGyzihR/QwiZuK9ap8h2rzHH51?= =?us-ascii?Q?Mkf8Gl3+RnxWJTYbKzkjDpRYJ3NIE1bP3mYFwS1NLuHLqqRqLqoTZTjTBqeR?= =?us-ascii?Q?pocTKCjaV04lJSMBamsaMn+FL5faOSK2xPNFzL+dInfaNiYmMAToCVTLb/Oz?= =?us-ascii?Q?AykhCAFt13bgTd2D26Mb6cnkKUZ6nCL939BE98DCFlGHLQpGgkqzggv96KZT?= =?us-ascii?Q?DVwouthpTjcw2XUx6s5o+nDxEAvKO+J5rfveQYT1RFT0porWWzAcjTlVGIPq?= =?us-ascii?Q?BEbHHjb6NpMeYosaIE356iCvFkihcCVNQJM3oUFvsZr5mQ9mq7yQi8oYH9Uy?= =?us-ascii?Q?wlZL98Yf6Z2HEbMVEYYepu7hOrbgEzxxEov1MB8KIt+p81CdXh4XlVeBFene?= =?us-ascii?Q?Kpi4XSUKCUQV1Lrpx4r6y6PrTJ2fEz622ZjBdV0+NLiu2Vc3yQHQ6bUogxnx?= =?us-ascii?Q?j4lXqEvQko7Pmb7J+5oSVfP4MAv6VvAeCB3dYXzT7OilYdzcoNLjX+4+Sz4Z?= =?us-ascii?Q?yRFFcOxdYF2YlbVPVrWV48Gmqd1fwbaxLnPFkLh8Og9gdpV4c9i4Wlw53bWR?= =?us-ascii?Q?bidxOGNa+xk53mc6xibGBMTOSL8sgVXh3CIAEl8zEICrsJ7tSFd/pi74mgac?= =?us-ascii?Q?mx2SHpjz4mflnjSivsTjtP8/sQgeIhHuoohqGLv2COE9seNPTT76u18IQGtu?= =?us-ascii?Q?+IbfgH5JFUv+tncjpeuU8169mCq1T0sjng09M0UQgdslPae2+BIaVaVgjNBJ?= =?us-ascii?Q?pFU0IA0D9GMV6uc/yVLnsIp+H7/GJZI/P/l+nQmcSdzONz6IYFWlsBS6Yo/w?= =?us-ascii?Q?5peI/0vDsBuL5Kjtjy2yT8ZRwFaUa+NzhfIo?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7142.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(376014)(7053199007)(38070700021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sklCw30xmhKPo/8V1UIJ/BVmyyKQyssZS1evGb5myIHd7HdmgyaOGjNeSN+Z?= =?us-ascii?Q?BaoC9xQtza7mcoJOu7MdSYRPfKKu9AZeIlU6Ibw8q4qJhc6JTQnCCTb2Ht1t?= =?us-ascii?Q?vfIOhAIp0OkOT2a8mBcrc+cI0THyeJE/5CGtsR0J1ySjVzFbb9XiY5uICm45?= =?us-ascii?Q?UHemIRiUS4qBFDuRU3thIM9z2YM0J7FdGcOZwKaWjiXolmMOZ0W3h4qN3IA/?= =?us-ascii?Q?+UVwuxDUmVzcgfB2ni53wKl3Lm507ZgHMbgS1Q9YLV3civ/rf9UCuXIvUfDH?= =?us-ascii?Q?PGkVTStFWQI2n7Aitoegk8xtjhqO1XF2rJxSgj0qrLKwe7r1bNcoPMcLDSO/?= =?us-ascii?Q?wgR54Bct0/jFhuLJdvITI+ieJCw3f7vlS34Zkw/nJduGkjC53poNP3tI77BL?= =?us-ascii?Q?7HEl+2PAFvyLwRelSizY80SikIj2yJrZJjkU5clnOvVSct6lHqwiPsYFcikw?= =?us-ascii?Q?RGXJKefarTpBzawig8xDf5BMC741vwqgqL8aSI5/JYgpwYgi8Hpcs4cYm6NS?= =?us-ascii?Q?GtlhQy+SZmoo/ffebYcBv+a0mCbXLHKtHluXnhCnTiZUahhvp+V9MXQXXsS5?= =?us-ascii?Q?UIRVF7AihPHUIeB1QtxiUk+ZUNXIerF+XM3mlHNlzWo6LQjRlo1dg7acF/AA?= =?us-ascii?Q?nXwEeSJleCahR+IYGtrBSd8qQgJFuP7yXoCVKunFiy6sqFS7a0kjYAzZVi9P?= =?us-ascii?Q?CXxDrTTMyPwDBBD5X8PDiECYxxim8wHaIC/gfL1F7GfmyqiYp+kA8WgwL23e?= =?us-ascii?Q?e2dvt7+mIddUyFnyk5A4NQmz09ouJjwOztMmEUD2lnSA4qYeJDitgwUlrGla?= =?us-ascii?Q?miZH3OH8McPnQM3YuNlCOCjz+xGH1RFnbElX1b0WrxLf1kXjabeQN/IQ7mPw?= =?us-ascii?Q?kewuOtuvYv7x5k4/UVnzalMbLoITiDC2oc5KIO2a1gUR04GkxLmctu6CLuc+?= =?us-ascii?Q?M7APkH48nIOtz4ns3rIXSxn1cp5LxaWQwNCsA1ch+unvDsNZKP+7uYrAp+dz?= =?us-ascii?Q?Dkko05w+P7oQTpvVS9DlVZmZJsOG3k4EwkAxjZM4pixvYRkaUJAcWkTz49Lo?= =?us-ascii?Q?pMlRyS/3c/Qv61EdO1s8hkATq1zkIYNvWFgvqbLEV9p2symyIkY7p7XyPNir?= =?us-ascii?Q?izDw+62neLQikozCBL49ymlzGP3+cE9kCjDufEobP7OIaUFwiC/qz77axse6?= =?us-ascii?Q?MU8oPayfFl/O82TX+VRS29H4YIjILfd/I4SwqpIjmfoH+BVw4oG5/p/vqjBw?= =?us-ascii?Q?tSb0e6m+wRdiIugDalY+of6Uj8fxB+m9y45wCvjZlyZ/lP/O2HXI5ecFMt4/?= =?us-ascii?Q?db5UJYS/QuZVXtcFhKVzoyW9Riy8rwNuMONXvvTsd67ifu6Tj9hs0gFwkHIT?= =?us-ascii?Q?Q9Jif63knjSsFabouZw8BZtsbd3kj4g5zUWJYdwilzkYWmn+H+9DezBAcizo?= =?us-ascii?Q?b5OuhIYg6Egic8Qx13hJot49nD6IRvsWqU1UkSsVAkhjKJtBY4TvYCDnRRqj?= =?us-ascii?Q?mfoiNyVF0nZsqra3WG16QQkCvZOShawGDsO2RNCe5jJKR4LatEtbGvn2rwzP?= =?us-ascii?Q?tyavmRK/xfmJLJuSkkv4U/Jc3enMoQEegTQMKjVe?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7142.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a666cd4-bbf0-4b29-e75d-08de08196571 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2025 16:23:50.1854 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: C6A6QnYNNWZx0JjDA+qrO7GzJD7BJ0faiMqlPCHj3xVMcY87ZNZVhBOxqqFw0xQwpoOj1DRDTJAmW8bNNQ57Qw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8414 > -----Original Message----- > From: Vladimir Oltean > Sent: Friday, October 10, 2025 3:49 PM > To: Wei Fang ; Claudiu Manoil > > Cc: Clark Wang ; andrew+netdev@lunn.ch; > davem@davemloft.net; edumazet@google.com; kuba@kernel.org; > pabeni@redhat.com; Frank Li ; imx@lists.linux.dev; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH net] net: enetc: correct the value of ENETC_RXB_TRUES= IZE >=20 > On Fri, Oct 10, 2025 at 05:26:08PM +0800, Wei Fang wrote: > > ENETC_RXB_TRUESIZE indicates the size of half a page, but the page > > size is adjustable, for ARM64 platform, the PAGE_SIZE can be 4K, 16K > > and 64K, so a fixed value '2048' is not correct when the PAGE_SIZE is 1= 6K or > 64K. > > > > Fixes: d4fd0404c1c9 ("enetc: Introduce basic PF and VF ENETC ethernet > > drivers") > > Signed-off-by: Wei Fang > > --- > > drivers/net/ethernet/freescale/enetc/enetc.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/freescale/enetc/enetc.h > > b/drivers/net/ethernet/freescale/enetc/enetc.h > > index 0ec010a7d640..f279fa597991 100644 > > --- a/drivers/net/ethernet/freescale/enetc/enetc.h > > +++ b/drivers/net/ethernet/freescale/enetc/enetc.h > > @@ -76,7 +76,7 @@ struct enetc_lso_t { > > #define ENETC_LSO_MAX_DATA_LEN SZ_256K > > > > #define ENETC_RX_MAXFRM_SIZE ENETC_MAC_MAXFRM_SIZE > > -#define ENETC_RXB_TRUESIZE 2048 /* PAGE_SIZE >> 1 */ > > +#define ENETC_RXB_TRUESIZE (PAGE_SIZE >> 1) > > #define ENETC_RXB_PAD NET_SKB_PAD /* add extra space if > needed */ > > #define ENETC_RXB_DMA_SIZE \ > > (SKB_WITH_OVERHEAD(ENETC_RXB_TRUESIZE) - ENETC_RXB_PAD) > > -- > > 2.34.1 > > >=20 > I wonder why 2048 was preferred, even though PAGE_SIZE >> 1 was in a > comment. > Claudiu, do you remember? Initial driver implementation for enetcv1 was bound to 4k pages, I need to = recheck why and get back to you. Regards, Claudiu