mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Shen Jianping (ME-SE/EAD2)" <Jianping.Shen@de.bosch.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	"jic23@kernel.org" <jic23@kernel.org>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"dima.fedrau@gmail.com" <dima.fedrau@gmail.com>,
	"marcelo.schmitt1@gmail.com" <marcelo.schmitt1@gmail.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Lorenz Christian (ME-SE/EAD2)" <Christian.Lorenz3@de.bosch.com>,
	"Frauendorf Ulrike (ME/PJ-SW3)" <Ulrike.Frauendorf@de.bosch.com>,
	"Dolde Kai (ME-SE/PAE-A3)" <Kai.Dolde@de.bosch.com>
Subject: RE: [PATCH v2 2/2] iio: imu: smi240: imu driver
Date: Wed, 14 Aug 2024 11:22:14 +0000	[thread overview]
Message-ID: <AM8PR10MB47218D483B63C0CE88BD64FDCD872@AM8PR10MB4721.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <7181442b-574e-4fab-94c0-e3282ac2d16d@kernel.org>

>
>On 13/08/2024 11:41, Shen Jianping (ME-SE/EAD2) wrote:
>>> +EXPORT_SYMBOL_GPL(smi240_core_probe);
>>> +
>>> +MODULE_AUTHOR("Markus Lochmann <markus.lochmann@de.bosch.com>");
>>> +MODULE_AUTHOR("Stefan Gutmann <stefan.gutmann@de.bosch.com>");
>>> +MODULE_DESCRIPTION("Bosch SMI240 driver"); MODULE_LICENSE("Dual
>>> +BSD/GPL");
>>
>> Hm? How many modules do you have here? What are their names?
>>
>> We have one module, named  "Bosch SMI240 driver". Any problem here?
>
>That's not the name of the module. That's description. What is the module filename
>(filename=name!)?
>
>Fix your quoting, because you misrepresent people's comments.

Sorry to give you this feeling, No, we we don't want to silence you to avoid work.  Just do not understand the module name correctly.

filename you mean the ko filename correct ?  We have only smi240.ko as output. Therefore just one module and we shall put MODULE_* only in one source file right. 
Shall we put in smi240_core.c or smi240_spi.c ?

Best regards,
Jianping Shen

  reply	other threads:[~2024-08-14 11:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09 11:16 [PATCH v2 0/2] iio: imu: smi240: cover-letter Jianping.Shen
2024-08-09 11:16 ` [PATCH v2 1/2] dt-bindings: iio: imu: smi240: devicetree binding Jianping.Shen
2024-08-09 14:19   ` Conor Dooley
2024-08-09 11:16 ` [PATCH v2 2/2] iio: imu: smi240: imu driver Jianping.Shen
2024-08-09 12:07   ` Christophe JAILLET
2024-08-09 12:18     ` Shen Jianping (ME-SE/EAD2)
2024-08-10 12:45       ` Krzysztof Kozlowski
2024-08-12 10:13         ` Shen Jianping (ME-SE/EAD2)
2024-08-10 12:44   ` Krzysztof Kozlowski
2024-08-13  9:41     ` Shen Jianping (ME-SE/EAD2)
2024-08-13  9:46       ` Krzysztof Kozlowski
2024-08-13 13:54         ` Shen Jianping (ME-SE/EAD2)
2024-08-13 14:37           ` Krzysztof Kozlowski
2024-08-13 14:51             ` Shen Jianping (ME-SE/EAD2)
2024-08-13 15:53               ` Krzysztof Kozlowski
2024-08-13 15:59       ` Krzysztof Kozlowski
2024-08-14 11:22         ` Shen Jianping (ME-SE/EAD2) [this message]
2024-08-13 15:57   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM8PR10MB47218D483B63C0CE88BD64FDCD872@AM8PR10MB4721.EURPRD10.PROD.OUTLOOK.COM \
    --to=jianping.shen@de.bosch.com \
    --cc=Christian.Lorenz3@de.bosch.com \
    --cc=Kai.Dolde@de.bosch.com \
    --cc=Ulrike.Frauendorf@de.bosch.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dima.fedrau@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®