From: Moti Haimovski <mhaimovski@habana.ai>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"david.m.ertman@intel.com" <david.m.ertman@intel.com>,
"ogabbay@kernel.org" <ogabbay@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1] make AUXILIARY_BUS config selection clearer
Date: Tue, 6 Jun 2023 14:50:21 +0000 [thread overview]
Message-ID: <AM9PR02MB7706888212798FE0CC8213D6D152A@AM9PR02MB7706.eurprd02.prod.outlook.com> (raw)
In-Reply-To: <20230606-aspirate-evident-00b27a98a718@wendy>
Hi Conor,
Noting is wrong with the drivers 😊
I've stumbled that issue when trying to figure-out how to manipulate the auxiliary-bus selection
Via "make menuconfig"
The issue is that with the current Kconfig when you run " make menuconfig" and enter the
Device Drivers ---> Generic Driver Options ---> Sub-menu then there is no mentioning of
the Auxiliary bus although it is the first entry in drivers/base/Kconfig that this menu is presenting.
So, the user has no idea that this option exists and no way to manipulate it via menconfig.
My commit makes this option "visible" by adding the short description in the "bool" line
and , while at it, adding a short description for the sake of future generations.
No functionality nor default values were altered.
Hope this answers your question
Moti H
> -----Original Message-----
> From: Conor Dooley <conor.dooley@microchip.com>
> Sent: Tuesday, 6 June 2023 16:48
> To: Moti Haimovski <mhaimovski@habana.ai>
> Cc: gregkh@linuxfoundation.org; david.m.ertman@intel.com;
> ogabbay@kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v1] make AUXILIARY_BUS config selection clearer
>
> Hey Moti,
>
> On Tue, Jun 06, 2023 at 04:35:28PM +0300, Moti Haimovski wrote:
> > Add a display string and a help section to the config AUXILIARY_BUS
> > section under the "Generic Driver Options" menu in order to make its
> > selection clearer.
>
> I am a wee bit confused, since it is not explicitly mentioned here, why is this
> now going to be user visible/selectable? What was wrong with the drivers
> that needed it selecting it?
>
> Thanks,
> Conor.
>
> >
> > Signed-off-by: Moti Haimovski <mhaimovski@habana.ai>
> > ---
> > drivers/base/Kconfig | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index
> > 6f04b831a5c0..e1caac1d9a58 100644
> > --- a/drivers/base/Kconfig
> > +++ b/drivers/base/Kconfig
> > @@ -2,7 +2,16 @@
> > menu "Generic Driver Options"
> >
> > config AUXILIARY_BUS
> > - bool
> > + bool "Support for auxiliary bus"
> > + help
> > + The auxiliary bus driver provides a way to export an interface
> > + for another subsystem to drive, implement a common intersection
> > + of functionality or split a function into child-devices
> > + representing sub-domains of functionality where each auxiliary
> > + device represents a part of its parent functionality (usually)
> > + driven by another driver.
> > +
> > + If unsure, say Y.
> >
> > config UEVENT_HELPER
> > bool "Support for uevent helper"
> > --
> > 2.25.1
> >
next prev parent reply other threads:[~2023-06-06 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 13:35 Moti Haimovski
2023-06-06 13:47 ` Conor Dooley
2023-06-06 14:50 ` Moti Haimovski [this message]
2023-06-06 15:04 ` Conor Dooley
2023-06-06 15:28 ` Moti Haimovski
2023-06-06 17:35 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM9PR02MB7706888212798FE0CC8213D6D152A@AM9PR02MB7706.eurprd02.prod.outlook.com \
--to=mhaimovski@habana.ai \
--cc=conor.dooley@microchip.com \
--cc=david.m.ertman@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®