From: Chancel Liu <chancel.liu@nxp.com>
To: Shengjiu Wang <shengjiu.wang@gmail.com>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
Frank Li <frank.li@nxp.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: Re: [PATCH v3] ASoC: dt-bindings: imx-card: Add dsp_a DAI format
Date: Sat, 28 Mar 2026 09:37:48 +0000 [thread overview]
Message-ID: <AM9PR04MB8353BC528DDBF158FEB50AF0E354A@AM9PR04MB8353.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAA+D8ANNmKX1oULZH=N8YE0hp24pP1JSvS9srugq+XMo+sQFnA@mail.gmail.com>
> > Existing i.MX audio sound card described by this binding use codecs
> > that operate in i2s or dsp_b formats. The newly added CS42448 codec
> > requires dsp_a for its TDM interface. To properly describe such
> > hardware in DT, the binding needs to allow dsp_a DAI format.
> >
> > Only i2s, dsp_b and dsp_a are included because these are the formats
> > actually used by the hardware supported by this binding. Other formats
> > such as left_j, right_j, ac97 are not used or required by the hardware
>
> "pdm", "left_j", "right_j" are supported by SAI, so I think they should be
> added from the hardware point of view.
>
> Best regards
> Shengjiu Wang
You're right. The binding should describe the full hardware capability
rather than only the formats currently used on a specific board or by
the current driver.
SAI is the controller of i.MX audio sound card. Therefore, the binding
must enumerate all formats that the SAI hardware is capable of,
regardless of current usage. According to the SAI specification, the
following DAI formats are supported:
- i2s
- right_j
- left_j
- dsp_a
- dsp_b
- pdm
- msb
- lsb
I will update the binding in v4 to include all of these formats.
Regards,
Chancel Liu
> > currently covered by this binding, so they are intentionally not added.
> >
> > Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> > ---
> > Changes in v3:
> > - Rewrote commit message completely to describe hardware requirements.
> > Explicitly documented why only dsp_a is added and why other formats
> > are not included.
> > - Rebased on latest code base. No functional changes.
> >
> > Changes in v2:
> > - Updated commit message to explain current support for i2s and dsp_b
> > formats and new support for dsp_a. No code changes.
> >
> > Documentation/devicetree/bindings/sound/imx-audio-card.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> > b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> > index 5424d4f16f52..75757fbccd89 100644
> > --- a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> > +++ b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> > @@ -37,6 +37,7 @@ patternProperties:
> > items:
> > enum:
> > - i2s
> > + - dsp_a
> > - dsp_b
> >
> > dai-tdm-slot-num: true
> > --
> > 2.50.1
> >
prev parent reply other threads:[~2026-03-28 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 3:15 Chancel Liu
2026-03-27 6:06 ` Shengjiu Wang
2026-03-28 9:37 ` Chancel Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM9PR04MB8353BC528DDBF158FEB50AF0E354A@AM9PR04MB8353.eurprd04.prod.outlook.com \
--to=chancel.liu@nxp.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shengjiu.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®