From: Andrei Stefanescu <andrei.stefanescu@nxp.com>
To: "Chester Lin" <clin@suse.com>, "Rob Herring" <robh+dt@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Andreas Färber" <afaerber@suse.de>
Cc: dl-S32 <S32@nxp.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Larisa Ileana Grigore <larisa.grigore@nxp.com>,
"Ghennadi Procopciuc (OSS)" <ghennadi.procopciuc@oss.nxp.com>,
Matthias Brugger <mbrugger@suse.com>
Subject: RE: [PATCH v3 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs
Date: Wed, 21 Dec 2022 12:28:58 +0000 [thread overview]
Message-ID: <AM9PR04MB8487286EC9EE4AE3F2FD382CE3EB9@AM9PR04MB8487.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20221221073232.21888-2-clin@suse.com>
Hi Chester,
> +patternProperties:
> + '-pins$':
Sorry, I missed this in the previous versions. Could you change it to '_pins' (underscore)? In our .dts files we use underscore in the names for pinctrl configuration nodes e.g. i2c4_pins, usbotg_pins.
> + patternProperties:
> + '-grp[0-9]$':
The same comment also applies here.
> + llce-can0-pins {
> + llce-can0-grp0 {
This should also change to something like:
llce_can0_pins {
llce_can0_grp0 {
...
}
}
Otherwise, this and PATCH 2/2 look good to me.
Best regards,
Andrei
next prev parent reply other threads:[~2022-12-21 12:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 7:32 [PATCH v3 0/2] Add pinctrl support for S32 SoC family Chester Lin
2022-12-21 7:32 ` [PATCH v3 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs Chester Lin
2022-12-21 12:28 ` Andrei Stefanescu [this message]
2022-12-21 12:30 ` Krzysztof Kozlowski
2022-12-21 13:52 ` Chester Lin
2022-12-22 11:28 ` Krzysztof Kozlowski
2023-01-09 7:04 ` Chester Lin
2023-01-09 9:08 ` Krzysztof Kozlowski
2022-12-21 7:32 ` [PATCH v3 2/2] pinctrl: add NXP S32 SoC family support Chester Lin
2023-01-09 13:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM9PR04MB8487286EC9EE4AE3F2FD382CE3EB9@AM9PR04MB8487.eurprd04.prod.outlook.com \
--to=andrei.stefanescu@nxp.com \
--cc=S32@nxp.com \
--cc=afaerber@suse.de \
--cc=clin@suse.com \
--cc=devicetree@vger.kernel.org \
--cc=ghennadi.procopciuc@oss.nxp.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=larisa.grigore@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®