RE: [EXT] Re: [PATCH v12 4/4] Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets

[Neeraj sanjay kale <neeraj.sanjaykale@nxp.com>]

Hi Paul,

Thank you for reviewing the patch.

> >
> > This driver has Power Save feature that will put the chip into sleep
> > state whenever there is no activity for 2000ms, and will be woken up
> > when any
> 
> Interesting. Are two seconds recommended in some specification?
This 2 seconds is a default timeout value in this design, which is enough to decide if the communication between chip is going to be idle, in order to prevent more frequent sleep-wakeup cycles, and to not keep the power consumption high for too long in idle scenarios.
We however intend to make this timeout configurable (default will still be 2000ms) in future patches, probably by coming up with a new hci vendor command.

> > +
> > +static u8 *nxp_get_fw_name_from_chipid(struct hci_dev *hdev, u16
> > +chipid)
> 
> Any reason to limit the length of `chipid` instead of using `unsigned int`?
This 'chipid' is nothing but the one received from chip's bootloader signature, which is of 16 bits.
Please check 'struct v3_start_ind' definition and 'nxp_recv_chip_ver_v3()'.
To maintain consistency I have kept the datatype as u16. Please let me know if you think otherwise.

Thanks,
Neeraj