From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013059.outbound.protection.outlook.com [40.107.159.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3749A23E32B; Mon, 13 Oct 2025 14:04:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.59 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760364282; cv=fail; b=PM3ATBaKmKIsoPWgv7K3t8L8v6FKETF59TzK0ZjPLfZUPX5O+SwemZ83eEshS/oUxMtoAlhVtxeZfUJ8k3fdqIr80NKfXO5eplUF9f0KeyVeDnPr89Zfbde5wtrfgA46fy9kFLLICb4fPyu6Zc8CPGHCemgh0bbK+uG/MBgSsh4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760364282; c=relaxed/simple; bh=95WJqGm84R/NXKU7F7jLU2XJ8DkGTTzB2tPhqkh7HJY=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=pia6jhzBodoIu5FOaKX59fzhPbzbBmnFIbDN9TwyOOGpSq/XpjEpQ/8jTvc8FfzYm088IFjMlvB7jUkOs8pOC5o7At//Z5MkiDwPzF9TeUMSTX6Le5THlAMKjMjnZmcYgsD0/nTg8K0pPEDz8NrUOcmTpALS52R64avawUmtOoU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=siemens.com; spf=pass smtp.mailfrom=siemens.com; dkim=pass (2048-bit key) header.d=siemens.com header.i=@siemens.com header.b=h2QrbEKH; arc=fail smtp.client-ip=40.107.159.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=siemens.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=siemens.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=siemens.com header.i=@siemens.com header.b="h2QrbEKH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ng/D1D2M/yPM8v78SEpDTljQ6Imldrh62/AJV30jM0sCxU0JvRBpJ1nUG5IVj6ck1tp24z68zPGI2jW5C3ZYRnZwv588YFfTxtXmEF8O00+Rpa82xTNgnQWsQjBT+QjYlFrgKnD3cktt1dja853ITH8JlsUprhI/NxRTMbp3NITsMHofgu+UhEpAVB3z7paDNG8SGEEsWtzp8vGso11VgYrMLpXobkrFPUPNXetZTC5WKqRP3cIDL/woeTmu0uUs/Vx9xjzkzPQN2qPA05fCR7hwCa0oy/YiL2TnbJEln0VkqcwR+ch2aXWb0WI+qh2tFmJbVasMcbgvUs8NgBZEcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WBts28voem9fIPykFi6MB953E2oKGB11pgb9Qr3/ftA=; b=eY0y7TDEvmyw1NhrznViv7JQCydaohLMI1Dah8+QZ2U+vKDk8LRxnDQ9buaTkbLW9Iu6vRf5OQOKOrdHDGRuiX8ZxlgIu7qM8zGCbuUrH5Q2enypun64J34fKC6FwWPWRxdBAiClgtdkwG/APcNAgSl5P3/IZ74mkMrerXPwFqXThrYmZd348yAmX2dz+6Hk5zhxVPqhs0n8lfOJFPtbSr9R9pNVyYhD7BrtxFQyeD3N6iAtTIA0t8JV+DMysO3IQmwox6hIJzlSMJQNfjsn3AlWNZjcbdadnJwUyWD8+dhs3umhiRKh8mIGTcL8P4OWD2c/yLjFgjpUBFqBrBjHPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WBts28voem9fIPykFi6MB953E2oKGB11pgb9Qr3/ftA=; b=h2QrbEKHwSUvk+Ec9J4niahASIyIQ3cL1ko2oGV6fVXrYd+4N/lvui2n+3uuHillsb+uSAp+4jguZPd/62q1mw0AB1P5u9QvR4ThJiDErhMi/Wxr5sEIdWlqcVuHGrnnTXljikDHjInTf86cqs3zDJs+Pzno/MI+JHfj5vS7H/yG5wQ+2nEliEacUhoWzv9w6X/6K2LxN0bElAe0rC3b8x5rmMbKON20bAsQahulLjMpVt0sf8OJFyf9130JS3qQMkMybkDiPcvM/cHKoBIFFRI2+6Ml242FIBpOSav4Bq1+3BRaWcXQbgYNheSGCfV5r2WP+DyqkiRXcYg6YZ7PIg== Received: from AS1PR10MB5675.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:47b::22) by DU0PR10MB6932.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:417::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9203.12; Mon, 13 Oct 2025 14:04:36 +0000 Received: from AS1PR10MB5675.EURPRD10.PROD.OUTLOOK.COM ([fe80::f25:24f8:9a0e:3430]) by AS1PR10MB5675.EURPRD10.PROD.OUTLOOK.COM ([fe80::f25:24f8:9a0e:3430%3]) with mapi id 15.20.9203.009; Mon, 13 Oct 2025 14:04:36 +0000 From: "Bouska, Zdenek" To: Chwee-Lin Choong , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Vinicius Costa Gomes CC: "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Avi Shalev , Song Yoong Siang Subject: RE: [PATCH iwl-net v1] igc: fix race condition in TX timestamp read for register 0 Thread-Topic: [PATCH iwl-net v1] igc: fix race condition in TX timestamp read for register 0 Thread-Index: AQHcKItpUFEqLTRPfEmV5xB013B+17S7SvLQ Date: Mon, 13 Oct 2025 14:04:36 +0000 Message-ID: References: <20250918183811.31270-1-chwee.lin.choong@intel.com> In-Reply-To: <20250918183811.31270-1-chwee.lin.choong@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_ActionId=407c7d11-f3d5-4f5c-991f-8af73bb9c081;MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_ContentBits=0;MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_Enabled=true;MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_Method=Standard;MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_Name=restricted;MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_SetDate=2025-10-10T10:09:51Z;MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_SiteId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_Tag=10, 3, 0, 1; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS1PR10MB5675:EE_|DU0PR10MB6932:EE_ x-ms-office365-filtering-correlation-id: 8a9c25fe-0637-4fe4-d383-08de0a61719d x-ms-exchange-atpmessageproperties: SA x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024|38070700021|921020; x-microsoft-antispam-message-info: =?iso-8859-2?Q?hgSiHNP55hXv+vmDHCFhUuETPA5GYIFIy52eCbw+3cOb3jJ3cTCnc03Nya?= =?iso-8859-2?Q?o+asVczx8LYMsXk4K5Uc9tKY13s4saevFsW90ai68qQy9lHao6wo3p8FO+?= =?iso-8859-2?Q?+IuTG+WkXrxQYKTKYbD4Z17eIK5tux5JDyBqUoM1GCQyHkIXGX1XhZIGOG?= =?iso-8859-2?Q?eWGKoq7EAA/S9+U7nMba7DLIseVHRX+d53/+8tc8gEnpUSn5StcptuC8RB?= =?iso-8859-2?Q?okjw96kbPZ1spKIUchRzLdPLr9iFn9lk0hDhT4Z/U3+JSR7L8T4Er65JLq?= =?iso-8859-2?Q?RAsaIRiWYUjohOrs1RgzouZrnXkFjk54dGzddikMoZAhRK2fP5hBaR/LlJ?= =?iso-8859-2?Q?DxU0Rqn739hMf4lojw5THdu/iK5LbmPh+IWY3ZyaLWyu2jjJzLRDlZOBa7?= =?iso-8859-2?Q?BW2GjkgUAlQ3U48g2eWOJU1M4/yKhI2+yqLEJMymRhoqZ+0ll5/yfGahwp?= =?iso-8859-2?Q?3loSYMUrOQXv1gGe+oKAtO5hraxsTIPTuiq4QIHEKhRNVjR841LFFaahPP?= =?iso-8859-2?Q?TmkvaFqr9HlplEvTJ05h7HdBL0OrI1O0tVPpYGSOMNXRRdQqTm0ehJRp60?= =?iso-8859-2?Q?UPlAqN7GGM4LotNTMC30OVyZFuI77fPY8kjzE+jMCgTeWyN/uPVMLdRure?= =?iso-8859-2?Q?e1qxqmZAbkQfZ4k7UZHr6WXHoua5DJN7Cf2jrXQOrzrjf04SjnTb5J1Xvt?= =?iso-8859-2?Q?51A5foFWOSPsbEGY3zx1LXYeEKrZtIwLIFIZtZw4ZMtdT5gbhts453GDUj?= =?iso-8859-2?Q?eQSGY+Fo4zDRmm7/cAA/oL/hGWnM2Ctw9+MWsZXEndVYHiNEBAfMFA6E/6?= =?iso-8859-2?Q?l7HxWgnwV6LjxjjHvBtRn0aaNspF0KV5mdo9nMUIxN1ffO+EELtgJV3O2w?= =?iso-8859-2?Q?uQ88LJHh5JmYdUUcvxN0mvHg6ieyxLGUXeJ2y74K42pK8kb1ZI6tH1uDSE?= =?iso-8859-2?Q?ZGA2fDn1RUF7j1RfpXDPKnHEdelIsy/t3C83yiLxup+ceKFxxLHvqhuaoG?= =?iso-8859-2?Q?BGuYC7X7T8w0Sz1dzBo01hO9TgCLUpMlsR9OoSMnx3rYtCtPSaGBc+DkJb?= =?iso-8859-2?Q?iI1OoIq8nGcTrB2C4OJMmmj1/q5B1gC6LN7+HynZOFruzvIRJ3GNFculA5?= =?iso-8859-2?Q?gGF3NSBVlkPyb5BvMPL066JlTckobHtNBZ75UNX92hLpJZW6j7nkc9fWYY?= =?iso-8859-2?Q?7j3wHt98zf5tzlORlDCNQNv6n//+nF8TWLu9SWQL955MxUDgj25IzDXNwm?= =?iso-8859-2?Q?cTw5Z7VclV/vVkIRzdOPk40bIrKjHKd7YNTpjjcvQmgT2D+ExQKJlOCyPG?= =?iso-8859-2?Q?IpLnqltjKdezzQNFG9Vn4o7Ri5eERqqhZjjf1cUZnfGqzsR/hvQWUG3nAg?= =?iso-8859-2?Q?hrHLycprfTE+PTcfFvACwZ6KpqnLyT4sBqxFOWyFdOwJDmVke8euKNqJai?= =?iso-8859-2?Q?aFTSTswVoyxGfEs32jlvGOHbCizoUCE/GsT5BCeEdmMEEQiy3fXlCFPbQG?= =?iso-8859-2?Q?6qN0x8iNaycSoHzNtgoKy04eZJdtJBkGDr2Kr2ut7om5WgVkTrZXAhZu0/?= =?iso-8859-2?Q?ZYYheqpUXJjP/2nNUio4waZdkY/VmkiLaNgeXGBBqX/7nK6WDQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS1PR10MB5675.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024)(38070700021)(921020);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?yO0R5ur07+po/U0KNbDDto7k/hnPGvH0jcK7GirOh3K6oyIlDPB/eingvV?= =?iso-8859-2?Q?iaksSdF1Mzd/14VE9cUVg8BHvOC4gtRfe45t2wvBOFD1XS5lm4439+W9gS?= =?iso-8859-2?Q?DxDbpicFuA9/eNQsN481N9BE7K6odKO01jrR92G6ZSfFkLLqrkt6uUIryz?= =?iso-8859-2?Q?gdso3lerRsbrrag9qIQt6ezwtpXKDNElYTbXvSwzGlqj9CvlvXLT0empz7?= =?iso-8859-2?Q?f8OkBQ17ISD4d16UAj1FGklmHQ8fIehlnSvBxUUouqpJ/MyT3TTYAFfzGZ?= =?iso-8859-2?Q?c+fSBiWJNJsQ13Kf+FmbLQOpB13SO1NX1SbcUigt9xeEk20U6C9DFtcnC0?= =?iso-8859-2?Q?G5Qyib9Ir77LAKj9Kjflgk+Jws0mDzxTMe0GqccofBIq7c5tfyJYJmiamT?= =?iso-8859-2?Q?LL37b5mBIPQsO+7VB4C9P7aRvoHOmqiPSMqX0deoJt0hFrEIttgUBHMk3M?= =?iso-8859-2?Q?wYH9xKuX6W+lBu1mRUJQsbfdOwL2njJtQRtPvVu6KaxYUH+0IOi3SkQSqo?= =?iso-8859-2?Q?HXU5XcbcvrqZiyWoHOYuzCjVb64WGyprbKbr1GurDwxoLFeQR6Oj1kgrTT?= =?iso-8859-2?Q?6HddXavvBSIzjWEa+bzWVWcIPN6g0aCxOO3JEihdB/hgZBG3c0IYGepZY2?= =?iso-8859-2?Q?o7w3YLObetoRSUAmddC1u3KQYMBHTLfMHkq1fculekb54btVoGMSrENJwv?= =?iso-8859-2?Q?DzKog30qrgoUZjCENY57HNn3OQMsvpjjpTH9TGKrf5sFQJ448BvyPjOVo8?= =?iso-8859-2?Q?3rZAA5whjel1FrCfvzMYWsDXmvQsNH2wdZyFi3Vx9AsAtoJy0RGD5b4ULe?= =?iso-8859-2?Q?hcCQelcvrSreuhxlXplVOxWgdojJGAimbDc/1elbfW9UZBT8A8y4AbChYs?= =?iso-8859-2?Q?fVfb9VuKSfWy9cJPNAEiW0Bhh0s2+Xp1EH0tlGnUmG0+zxlOQQy6yWhUOB?= =?iso-8859-2?Q?7W49s2mSWCVCsofS1L02WawggE/jHPaecN7KzBrPt8LRY36R1M5z6W7c6/?= =?iso-8859-2?Q?j4Hs5RnMUNyqVNr4m2ePu2nqrxodMwfsjTOD+pKCu+wMUpQOJ/Nl9G4lRM?= =?iso-8859-2?Q?6A/QQz/K3VMfKDMMIp63OL7Wlg6rwvj2LfjVvk9mlz0ibVrwAm/8yTGkVr?= =?iso-8859-2?Q?zmCOOuf3QyEO6owBVXnFcrZl1GylcVkZHtbdTSIYXM1PjhqOtF1TOpGMe+?= =?iso-8859-2?Q?M9lSBgLV4LNib0sksKQArWQWXkVt4IJxFbq6TOeQ6nptaGAvkqBsRTqM2K?= =?iso-8859-2?Q?vvQZkzsaINgF0eVNK47CNqkA7UWpMN9sbPHWN+yyIEQNpLEoqY6EJkoK/l?= =?iso-8859-2?Q?yzThMvv7mRhiXSZdwzVD41Ardcpzv47whKH+wFPsbSZV13SY5/dXhHW+mG?= =?iso-8859-2?Q?vhDiutttEYDOFhSsUYTlzxCqbAQf+8hnfPMBFzPi5AQ3wSuLp1Kf5NM5n5?= =?iso-8859-2?Q?stI3Apm2i2yTNi9I1SBIPYqhjxlG8o+Q0UWMMm4O+aTjcHRu8075+M9LYA?= =?iso-8859-2?Q?d529NLbYUZPo9JbCsrDD5w02RQb3wD1pFDV/fDzfUCzE8oX+oPw5s4I8B1?= =?iso-8859-2?Q?6hzKCO7GaC/w0xxzMuB8V0KDcH1BHvAcMy+sa3fBCCWhLVsbwByiZCmpYA?= =?iso-8859-2?Q?vJ3O3w3phwu9uQsqem/E90YyW2poaBMFIcIVcNgIk+JLiRmSdfBMom1w?= =?iso-8859-2?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS1PR10MB5675.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 8a9c25fe-0637-4fe4-d383-08de0a61719d X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2025 14:04:36.7170 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aVT1/AhdBt/PZ1wGQeyBfsPP3DAV5aUcKrE7WMDIjlMbmhiFvKqI5UACcz8882BcEaL8aUZeKZPBqdoHkoJQAsYIEQxG22L+wRdNZJ7lM04= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB6932 On 18/09/2025 19:38, Chwee-Lin Choong wrote: > This fix also prevents TX unit hangs observed under heavy > timestamping load. >=20 I have tested this patch with heavy TX timestamps load. I have not reproduced any hangs when I apply this patch to 6.15.0. But when I apply it to 6.17.0, then I still have some hangs, but not as muc= h as without the patch on 6.17.0. Used git bisect with this patch and I found that this is the first commit w= here this patch does not avoid all hangs: commit 0d58cdc902dace2298406b3972def04f55e3d775 Author: Faizal Rahim Date: Mon Mar 17 23:07:35 2025 -0400 igc: optimize TX packet buffer utilization for TSN mode In preparation for upcoming frame preemption patches, optimize the TX packet buffer size. The total packet buffer size (RX + TX) is 64KB, wit= h a maximum of 34KB for either RX or TX. Split the buffer evenly, allocating 32KB to each. For TX, assign 7KB to each of the four TX packet buffers (total 28KB) and reserve 4KB for BMC. When I revert this commit and apply this patch on 6.17.0 I have no hangs. Best regards, Zdenek Bouska -- Siemens, s.r.o Foundational Technologies