From: Luigi Leonardi <luigi.leonardi@outlook.com>
To: ameryhung@gmail.com
Cc: amery.hung@bytedance.com, bobby.eshleman@bytedance.com,
bpf@vger.kernel.org, bryantan@vmware.com,
dan.carpenter@linaro.org, davem@davemloft.net,
decui@microsoft.com, edumazet@google.com, haiyangz@microsoft.com,
jasowang@redhat.com, jiang.wang@bytedance.com, kuba@kernel.org,
kvm@vger.kernel.org, kys@microsoft.com,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
mst@redhat.com, netdev@vger.kernel.org, oxffffaa@gmail.com,
pabeni@redhat.com, pv-drivers@vmware.com, sgarzare@redhat.com,
simon.horman@corigine.com, stefanha@redhat.com, vdasa@vmware.com,
virtualization@lists.linux-foundation.org, wei.liu@kernel.org,
xiyou.wangcong@gmail.com, xuanzhuo@linux.alibaba.com,
Luigi Leonardi <luigi.leonardi@outlook.com>
Subject: Re: [RFC PATCH net-next v6 12/14] vsock/loopback: implement datagram support
Date: Thu, 1 Aug 2024 14:18:10 +0200 [thread overview]
Message-ID: <AS2P194MB2170C5B197652F909252BA809AB22@AS2P194MB2170.EURP194.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240710212555.1617795-13-amery.hung@bytedance.com>
> +static bool vsock_loopback_dgram_allow(u32 cid, u32 port)
> +{
> + return true;
> +}
> +
> static bool vsock_loopback_seqpacket_allow(u32 remote_cid);
> static bool vsock_loopback_msgzerocopy_allow(void)
> {
> @@ -66,7 +71,7 @@ static struct virtio_transport loopback_transport = {
> .cancel_pkt = vsock_loopback_cancel_pkt,
>
> .dgram_enqueue = virtio_transport_dgram_enqueue,
> - .dgram_allow = virtio_transport_dgram_allow,
> + .dgram_allow = vsock_loopback_dgram_allow,
>
> .stream_dequeue = virtio_transport_stream_dequeue,
> .stream_enqueue = virtio_transport_stream_enqueue,
> --
> 2.20.1
Code LGTM! Just because you have to send a new version I'd modify
the commit message to something like:
"Add 'vsock_loopback_dgram_allow' callback for datagram support."
Feel free to change it :)
Thank you,
Luigi
next prev parent reply other threads:[~2024-08-01 12:18 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 21:25 [RFC PATCH net-next v6 00/14] virtio/vsock: support datagrams Amery Hung
2024-07-10 21:25 ` [RFC PATCH net-next v6 01/14] af_vsock: generalize vsock_dgram_recvmsg() to all transports Amery Hung
2024-07-15 8:02 ` Luigi Leonardi
2024-07-15 23:39 ` Amery Hung
2024-07-29 19:25 ` Arseniy Krasnov
2024-07-10 21:25 ` [RFC PATCH net-next v6 02/14] af_vsock: refactor transport lookup code Amery Hung
2024-07-25 6:29 ` Arseniy Krasnov
2024-07-28 22:10 ` Amery Hung
2024-07-10 21:25 ` [RFC PATCH net-next v6 03/14] af_vsock: support multi-transport datagrams Amery Hung
2024-07-15 8:13 ` Arseniy Krasnov
2024-07-15 17:41 ` Amery Hung
2024-07-28 20:28 ` Arseniy Krasnov
2024-07-28 21:53 ` Amery Hung
2024-07-29 5:12 ` Arseniy Krasnov
2024-07-10 21:25 ` [RFC PATCH net-next v6 04/14] af_vsock: generalize bind table functions Amery Hung
2024-07-23 14:39 ` Stefano Garzarella
2024-07-28 18:52 ` Amery Hung
2024-07-30 8:00 ` Stefano Garzarella
2024-07-30 17:56 ` Amery Hung
2024-07-10 21:25 ` [RFC PATCH net-next v6 05/14] af_vsock: use a separate dgram bind table Amery Hung
2024-07-23 14:41 ` Stefano Garzarella
2024-07-28 21:37 ` Amery Hung
2024-07-30 8:05 ` Stefano Garzarella
2024-07-10 21:25 ` [RFC PATCH net-next v6 06/14] virtio/vsock: add VIRTIO_VSOCK_TYPE_DGRAM Amery Hung
2024-07-10 21:25 ` [RFC PATCH net-next v6 07/14] virtio/vsock: add common datagram send path Amery Hung
2024-07-23 14:42 ` Stefano Garzarella
2024-07-26 23:22 ` Amery Hung
2024-07-30 8:22 ` Stefano Garzarella
2024-07-29 20:00 ` Arseniy Krasnov
2024-07-29 22:51 ` Amery Hung
2024-07-30 5:09 ` Arseniy Krasnov
2024-07-10 21:25 ` [RFC PATCH net-next v6 08/14] af_vsock: add vsock_find_bound_dgram_socket() Amery Hung
2024-07-10 21:25 ` [RFC PATCH net-next v6 09/14] virtio/vsock: add common datagram recv path Amery Hung
2024-07-23 14:42 ` Stefano Garzarella
2024-07-30 0:35 ` Amery Hung
2024-07-30 8:32 ` Stefano Garzarella
2024-07-10 21:25 ` [RFC PATCH net-next v6 10/14] virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit Amery Hung
2024-07-10 21:25 ` [RFC PATCH net-next v6 11/14] vhost/vsock: implement datagram support Amery Hung
2024-07-10 21:25 ` [RFC PATCH net-next v6 12/14] vsock/loopback: " Amery Hung
2024-08-01 12:18 ` Luigi Leonardi [this message]
2024-07-10 21:25 ` [RFC PATCH net-next v6 13/14] virtio/vsock: " Amery Hung
2024-07-11 23:02 ` Luigi Leonardi
2024-07-11 23:07 ` Amery Hung
2024-07-10 21:25 ` [RFC PATCH net-next v6 14/14] test/vsock: add vsock dgram tests Amery Hung
2024-07-20 19:58 ` Arseniy Krasnov
2024-07-23 14:43 ` Stefano Garzarella
2024-07-28 22:06 ` Amery Hung
2024-07-23 14:38 ` [RFC PATCH net-next v6 00/14] virtio/vsock: support datagrams Stefano Garzarella
2025-07-22 14:35 ` Stefano Garzarella
2025-07-26 5:53 ` Amery Hung
2025-07-29 12:40 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS2P194MB2170C5B197652F909252BA809AB22@AS2P194MB2170.EURP194.PROD.OUTLOOK.COM \
--to=luigi.leonardi@outlook.com \
--cc=amery.hung@bytedance.com \
--cc=ameryhung@gmail.com \
--cc=bobby.eshleman@bytedance.com \
--cc=bpf@vger.kernel.org \
--cc=bryantan@vmware.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=jiang.wang@bytedance.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oxffffaa@gmail.com \
--cc=pabeni@redhat.com \
--cc=pv-drivers@vmware.com \
--cc=sgarzare@redhat.com \
--cc=simon.horman@corigine.com \
--cc=stefanha@redhat.com \
--cc=vdasa@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.liu@kernel.org \
--cc=xiyou.wangcong@gmail.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®