AW: [PATCH 2/2] USB: serial: option: add Wistron NeWeb M18QW support

[Ulv Michel <ulv@on2.de>]

Hello Greg,

> We need a full name, sorry.
the full name is Ulv Michel.

> And where is patch 1/2 of this series?
Part 1 is this: https://lore.kernel.org/linux-usb/2025012501-pediatric-abide-b802@gregkh/T/#t

> >  	  .driver_info = RSVD(1) | RSVD(4) },
> > +	{ USB_DEVICE_AND_INTERFACE_INFO(0x1435, 0x3185, 0xff, 0x00, 0x00) },   /* Wistron Neweb M18QW */

> You forgot a tab before the comment :(
:( I removed the tab because the checkpatch.pl complained the length of the line being more than 100 columns...
What would be you suggestion? Resubmit? Or keep it?

Thanks,
Ulv


-----Ursprüngliche Nachricht-----
Von: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Gesendet: Montag, 3. Februar 2025 16:17
An: Ulv Michel <ulv@on2.de>
Cc: Johan Hovold <johan@kernel.org>; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
Betreff: Re: [PATCH 2/2] USB: serial: option: add Wistron NeWeb M18QW support

On Sat, Jan 25, 2025 at 10:40:05AM +0100, U Michel wrote:
> From: U M <ulv@on2.de>

We need a full name, sorry.

And where is patch 1/2 of this series?


> 
> Update the USB serial option driver to support Wistron NeWeb M18QW.
> 
> ID 1435:3185 WNC M18QW
> 
> T:  Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#=  2 Spd=480  MxCh= 0
> D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> P:  Vendor=1435 ProdID=3185 Rev= 3.18
> S:  Manufacturer=Android
> S:  Product=Android
> S:  SerialNumber=WNC_ADB
> C:* #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=500mA
> I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> E:  Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)
> E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> E:  Ad=84(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> E:  Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> E:  Ad=86(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
> E:  Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> E:  Ad=88(I) Atr=03(Int.) MxPS=   8 Ivl=32ms
> E:  Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 5 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=(none)
> E:  Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=125us
> 
> Tested successfully connecting via picocom and submitting at commands
> 
> Signed-off-by: U M <ulv@on2.de>
> ---
>  drivers/usb/serial/option.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c 
> index 1e2ae0c6c41c..b166f1607b0e 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -2285,6 +2285,7 @@ static const struct usb_device_id option_ids[] = {
>  	{ USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x7e11, 0xff, 0xff, 0xff) },	/* D-Link DWM-156/A3 */
>  	{ USB_DEVICE_INTERFACE_CLASS(0x1435, 0xd191, 0xff),			/* Wistron Neweb D19Q1 */
>  	  .driver_info = RSVD(1) | RSVD(4) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(0x1435, 0x3185, 0xff, 0x00, 0x00) },   /* Wistron Neweb M18QW */

You forgot a tab before the comment :(

thanks,

greg k-h