mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wei Fang <wei.fang@nxp.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Marek Vasut <marex@nabladev.com>,
	"Frank Li (OSS)" <frank.li@oss.nxp.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	Clark Wang <xiaoning.wang@nxp.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Eric Dumazet <edumazet@kernel.org>, Frank Li <frank.li@nxp.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
	"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: RE: [net-next,PATCH 2/2] enetc: Make eMDIO MDC rate configurable from DT
Date: Fri, 23 Oct 2026 02:08:02 +0000	[thread overview]
Message-ID: <AS4PR04MB9338592F92D23CCC59FF181E88642@AS4PR04MB9338.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <ucqfjqsvvnxp7csa53lsbtxxeti4n53wdrybzuemargqkt556y@amr6rfv5oq4f>

> > > > Your first patch only modified the EMDIO binding-doc, not the
> > > > ENETC and switch binding-doc.
> > > So I need to patch also
> > > Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml ? Any
> > > other binding document ?
> > >
> >
> > fsl,enetc.yaml and nxp,netc-switch.yaml.
> >
> > However, once again, I don't highly recommend adding a clocks property
> > to the DTS to obtain the MDC source clock frequency. My reasons are as
> follows:
> >
> > 1. The MDC source clock is the NETC system clock, which is a fixed
> > configuration with a fixed frequency for each SoC, hardcode the rate in driver
> is simpler.
> 
> In the RCW project (https://github.com/nxp-qoriq/rcw), we have for LS1028A:
> - R_SQPP_0x85bb/rcw_800_sdboot.rcw and
> R_SQPP_0x85bb/rcw_800_emmcboot.rcw:
>   set CGA_PLL2_RAT=8, giving 800 / 3 = 266.67 MHz.
> - R_SQPP_0x85bb/rcw_1500_gpu700.rcw: sets CGA_PLL2_RAT=14, giving 1400
> / 3 =
>   466.67 MHz.
> 
> Apart from these, yes, the other RCWs do set CGA_PLL2_RAT=12, giving 400
> MHz.
> But the statement in general is false.

Okay, it seems that the LS1028A is a special case. For i.MX, we set the NETC to
a fixed operating frequency for each SoC and do not modify it. Therefore, it is
more appropriate to leave the LS1028A as is for now.


  reply	other threads:[~2026-10-23  2:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 19:32 [net-next,PATCH 1/2] dt-bindings: net: enetc-mdio: Document optional MDC clock Marek Vasut
2026-10-16 19:32 ` [net-next,PATCH 2/2] enetc: Make eMDIO MDC rate configurable from DT Marek Vasut
2026-10-16 20:04   ` Frank Li
2026-10-16 22:04     ` Marek Vasut
2026-10-17  2:24     ` Wei Fang
2026-10-17 17:30       ` Marek Vasut
2026-10-19  2:59         ` Wei Fang
2026-10-19 16:10           ` Marek Vasut
2026-10-20  7:43             ` Wei Fang
2026-10-21 15:15               ` Vladimir Oltean
2026-10-23  2:08                 ` Wei Fang [this message]
2026-10-16 20:59   ` Andrew Lunn
2026-10-16 22:26     ` Marek Vasut
2026-10-17 17:39       ` Andrew Lunn
2026-10-16 19:59 ` [net-next,PATCH 1/2] dt-bindings: net: enetc-mdio: Document optional MDC clock Frank Li
2026-10-18 19:42 ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS4PR04MB9338592F92D23CCC59FF181E88642@AS4PR04MB9338.eurprd04.prod.outlook.com \
    --to=wei.fang@nxp.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=chleroy@kernel.org \
    --cc=claudiu.manoil@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@kernel.org \
    --cc=frank.li@nxp.com \
    --cc=frank.li@oss.nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=marex@nabladev.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=vladimir.oltean@nxp.com \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®