From: Joy Zou <joy.zou@nxp.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Frank Li <frank.li@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: Re: [PATCH v4 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support
Date: Wed, 24 Apr 2024 09:04:36 +0000 [thread overview]
Message-ID: <AS4PR04MB938629FE2E40DA32B8A95E2AE1102@AS4PR04MB9386.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20240424085955.xsseqmzarh3uyfys@pengutronix.de>
> -----Original Message-----
> From: Marco Felsch <m.felsch@pengutronix.de>
> Sent: 2024年4月24日 17:00
> To: Joy Zou <joy.zou@nxp.com>
> Cc: Frank Li <frank.li@nxp.com>; Jacky Bai <ping.bai@nxp.com>;
> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> <linux-imx@nxp.com>; devicetree@vger.kernel.org; imx@lists.linux.dev;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: Re: [PATCH v4 1/1] arm64: dts: imx93-11x11-evk: add rtc
> PCF2131 support
>
> On 24-04-24, Joy Zou wrote:
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > > > b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > > > index 07e85a30a25f..bc3c9271d747 100644
> > > > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > > > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > > > @@ -281,6 +281,23 @@ ldo5: LDO5 {
> > > > };
> > > > };
> > > >
> > > > +&lpi2c3 {
> > > > + #address-cells = <1>;
> > > > + #size-cells = <0>;
> > >
> > > while reading your patch I also noticed that you had to specify
> > > these cells here. It is very common to specify it within the base
> > > dtsi file imx93.dtsi. Can you please provde an extra patch which
> > > adds this to the base dtsi followed by this patch, which of course do need
> to specify it again.
> > >
> > > Thanks you,
> > > Marco
> > >
> > Thanks for your comments!
> > Have checked the base dtsi file imx93.dtsi. The these cells already existed.
>
> You're right, not sure why I didn't saw it in the first place.
>
> > The current cells is same with the lpi2c3 node in imx93.dtsi. So
> > should remove these cells in order to keep terse?
>
> Yes please remove it.
>
> Regards,
> Marco
Thanks for your comments!
Will change it in next version.
BR
Joy Zou
prev parent reply other threads:[~2024-04-24 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 3:14 [PATCH v4 0/1] Add " Joy Zou
2024-04-17 3:14 ` [PATCH v4 1/1] arm64: dts: imx93-11x11-evk: add " Joy Zou
2024-04-17 3:09 ` Fabio Estevam
2024-04-17 3:26 ` [EXT] " Joy Zou
2024-04-17 4:57 ` Marco Felsch
2024-04-24 2:28 ` [EXT] " Joy Zou
2024-04-24 8:59 ` Marco Felsch
2024-04-24 9:04 ` Joy Zou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS4PR04MB938629FE2E40DA32B8A95E2AE1102@AS4PR04MB9386.eurprd04.prod.outlook.com \
--to=joy.zou@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®