From: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"marcel@holtmann.org" <marcel@holtmann.org>,
"luiz.dentz@gmail.com" <luiz.dentz@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>
Cc: "linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Amitkumar Karwar <amitkumar.karwar@nxp.com>,
Rohit Fule <rohit.fule@nxp.com>, Sherry Sun <sherry.sun@nxp.com>,
Luke Wang <ziniu.wang_1@nxp.com>, Bough Chen <haibo.chen@nxp.com>,
LnxRevLi <LnxRevLi@nxp.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: net: bluetooth: btnxpuart: Add firmware-name property
Date: Wed, 10 Apr 2024 08:13:34 +0000 [thread overview]
Message-ID: <AS4PR04MB9692C8CEB08D7AE01CDDE789E7062@AS4PR04MB9692.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <e9cef5dd-c4fc-43c0-839b-d311d87a28ca@linaro.org>
Hi Krzysztof,
Thank you for the review. I have made the changes you requested and sent out the v3 patch.
Thanks,
Neeraj
>
> On 08/04/2024 15:22, Neeraj Sanjay Kale wrote:
> > This adds a new optional device tree property called firware-name.
> >
> > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
>
> BTW, there is no such device as btnxpuart. Bindings are for hardware.
> With corrected subject:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> > ---
> > v2: Add maxItems, simplify description, remove "nxp/". (Krzysztof)
> > ---
> > .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> > b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> > index f01a3988538c..6774cc4d6a9e 100644
> > ---
> > a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> > +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.y
> > +++ aml
> > @@ -31,6 +31,11 @@ properties:
> > This property depends on the module vendor's
> > configuration.
> >
> > + firmware-name:
> > + maxItems: 1
> > + description:
> > + Specify firmware file name.
>
> Drop description, redundant. You did not say anything different than property
> is saying already.
next prev parent reply other threads:[~2024-04-10 8:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 13:22 [PATCH v2 0/2] Bluetooth: btnxpuart: Update firmware names Neeraj Sanjay Kale
2024-04-08 13:22 ` [PATCH v2 1/2] dt-bindings: net: bluetooth: btnxpuart: Add firmware-name property Neeraj Sanjay Kale
2024-04-08 13:29 ` Krzysztof Kozlowski
2024-04-10 8:13 ` Neeraj Sanjay Kale [this message]
2024-04-08 13:22 ` [PATCH v2 2/2] Bluetooth: btnxpuart: Update firmware names Neeraj Sanjay Kale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS4PR04MB9692C8CEB08D7AE01CDDE789E7062@AS4PR04MB9692.eurprd04.prod.outlook.com \
--to=neeraj.sanjaykale@nxp.com \
--cc=LnxRevLi@nxp.com \
--cc=amitkumar.karwar@nxp.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=haibo.chen@nxp.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=rohit.fule@nxp.com \
--cc=sherry.sun@nxp.com \
--cc=ziniu.wang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®