mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhipeng Wang <zhipeng.wang_1@nxp.com>
To: Trilok Soni <trilokkumar.soni@oss.qualcomm.com>,
	"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
	"tglx@kernel.org" <tglx@kernel.org>
Cc: "shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"chun-hung.wu@mediatek.com" <chun-hung.wu@mediatek.com>,
	"walter.chang@mediatek.com" <walter.chang@mediatek.com>,
	"jstultz@google.com" <jstultz@google.com>,
	"amergnat@baylibre.com" <amergnat@baylibre.com>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	Jindong Yue <jindong.yue@nxp.com>,
	Xuegang Liu <xuegang.liu@nxp.com>
Subject: RE: [EXT] Re: [PATCH v3 0/4] clocksource: Add module support for timer drivers
Date: Wed, 4 Mar 2026 07:22:31 +0000	[thread overview]
Message-ID: <AS8PR04MB8420DC3D992C8966B5BA71FCEB7CA@AS8PR04MB8420.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <2387f306-d7df-41a6-a526-d5bc56ae1c06@oss.qualcomm.com>

Hello Trilok,

Thank you for the feedback.

Yes, MediaTek SoCs have ARM architectural timers. The timer-mediatek
driver provides an always-on system timer that complements, rather than
replaces, the ARM architected timer.

I will send v4 with an updated cover letter to clarify this.

BRs,
Zhipeng


> -----Original Message-----
> From: Trilok Soni <trilokkumar.soni@oss.qualcomm.com>
> Sent: 2026年3月4日 13:41
> To: Zhipeng Wang <zhipeng.wang_1@nxp.com>; daniel.lezcano@linaro.org;
> tglx@kernel.org
> Cc: shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; matthias.bgg@gmail.com;
> angelogioacchino.delregno@collabora.com; linux-kernel@vger.kernel.org;
> imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org;
> linux-mediatek@lists.infradead.org; chun-hung.wu@mediatek.com;
> walter.chang@mediatek.com; jstultz@google.com; amergnat@baylibre.com;
> Aisheng Dong <aisheng.dong@nxp.com>; Jindong Yue
> <jindong.yue@nxp.com>; Xuegang Liu <xuegang.liu@nxp.com>
> Subject: [EXT] Re: [PATCH v3 0/4] clocksource: Add module support for timer
> drivers
> 
> [You don't often get email from trilokkumar.soni@oss.qualcomm.com. Learn
> why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On 3/3/2026 6:57 PM, Zhipeng Wang wrote:
> > This patch series enables clocksource timer drivers to be built as
> > loadable kernel modules, which is particularly useful for GKI (Generic
> > Kernel Image) configurations.
> >
> > This series is based on the previous MediaTek timer modularization work:
> > Link:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore
> > .kernel.org%2Fall%2F20230517022557.24388-1-walter.chang%40mediatek.c
> om
> > %2F&data=05%7C02%7Czhipeng.wang_1%40nxp.com%7C3c600569cf2c45f
> e76d308de
> >
> 79b09401%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6390819
> 964656056
> >
> 68%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjA
> uMDAwMCI
> >
> sIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sda
> ta=l
> > Y0pdTxMyzbZospgoWZHb4sOFTwdl84pJXxvRt4fN3I%3D&reserved=0
> 
> You are not explaining clearly on the why part? Does MTK doesn't have ARM
> compliant timers and due to which you have specific timer driver?
> 
> It is not clear.
> 
> 
> >
> > The series includes:
> > 1. Export necessary functions from clocksource/mmio 2. Remove __init
> > markings from timer-of to support modules 3. Convert MediaTek timer
> > driver to support module build 4. Convert i.MX TPM timer driver to
> > support module build
> >
> > Testing performed:
> > - Built and tested on i.MX8ULP platform
> > - Built and tested on MediaTek platform
> > - Verified both built-in and module configurations
> > - Confirmed timer functionality in both configurations
> >
> > Changes in v3:
> > - Reworded summary line for timer-mediatek driver as suggested.
> > - Improved commit message formatting (line wrapping).
> > - No functional changes to the code.
> >
> > Changes in v2:
> > - Added Signed-off-by from submitter (Zhipeng Wang) to all patches
> >   as requested by reviewers
> >
> > Changes in v1:
> > - Fixed 'unsigned' to 'unsigned int' in clocksource_mmio_init()
> > - Changed MODULE_LICENSE from "GPL v2" to "GPL" for mediatek driver
> > - Added i.MX TPM timer driver module support
> >
> > Chun-Hung Wu (3):
> >   clocksource/drivers/mmio: Export clocksource_mmio_init()
> >   clocksource/drivers/timer-of: Remove __init markings
> >   clocksource/drivers/timer-mediatek: Convert timer-mediatek to a
> >     loadable module
> >
> > Jindong Yue (1):
> >   clocksource/drivers/imx-tpm: Support building imx-tpm driver as
> > module
> >
> >  drivers/clocksource/Kconfig          |  4 ++--
> >  drivers/clocksource/mmio.c           |  8 ++++---
> >  drivers/clocksource/timer-imx-tpm.c  | 36
> > +++++++++++++++++++++++++---  drivers/clocksource/timer-mediatek.c |
> 33 +++++++++++++++++++++++++
> >  drivers/clocksource/timer-of.c       | 23 +++++++++---------
> >  drivers/clocksource/timer-of.h       |  6 ++---
> >  6 files changed, 88 insertions(+), 22 deletions(-)
> >


      reply	other threads:[~2026-03-04  7:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04  2:57 Zhipeng Wang
2026-03-04  2:57 ` [PATCH v3 1/4] clocksource/drivers/mmio: Export clocksource_mmio_init() Zhipeng Wang
2026-03-04  2:57 ` [PATCH v3 2/4] clocksource/drivers/timer-of: Remove __init markings Zhipeng Wang
2026-03-04  2:57 ` [PATCH v3 3/4] clocksource/drivers/timer-mediatek: Convert timer-mediatek to a loadable module Zhipeng Wang
2026-03-04  5:41   ` Trilok Soni
2026-03-04  7:30     ` [EXT] " Zhipeng Wang
2026-03-04  2:57 ` [PATCH v3 4/4] clocksource/drivers/imx-tpm: Support building imx-tpm driver as module Zhipeng Wang
2026-03-04  4:26 ` [PATCH v3 0/4] clocksource: Add module support for timer drivers Frank Li
2026-03-04  5:40 ` Trilok Soni
2026-03-04  7:22   ` Zhipeng Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8PR04MB8420DC3D992C8966B5BA71FCEB7CA@AS8PR04MB8420.eurprd04.prod.outlook.com \
    --to=zhipeng.wang_1@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=amergnat@baylibre.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chun-hung.wu@mediatek.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=jindong.yue@nxp.com \
    --cc=jstultz@google.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=tglx@kernel.org \
    --cc=trilokkumar.soni@oss.qualcomm.com \
    --cc=walter.chang@mediatek.com \
    --cc=xuegang.liu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®