From: Hongxing Zhu <hongxing.zhu@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
Peng Fan <peng.fan@nxp.com>, "marex@denx.de" <marex@denx.de>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
"tharvey@gateworks.com" <tharvey@gateworks.com>,
Frank Li <frank.li@nxp.com>
Cc: "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH v6 1/6] arm64: dts: Add i.MX8MM PCIe EP support
Date: Mon, 30 Jan 2023 02:02:15 +0000 [thread overview]
Message-ID: <AS8PR04MB86769DE0BA3D2D077B2EFF378CD39@AS8PR04MB8676.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <c4733adc-4f2f-f4ff-5517-b4d2bc003ac8@linaro.org>
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: 2023年1月20日 16:08
> To: Hongxing Zhu <hongxing.zhu@nxp.com>; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; Peng Fan
> <peng.fan@nxp.com>; marex@denx.de; Marcel Ziswiler
> <marcel.ziswiler@toradex.com>; tharvey@gateworks.com; Frank Li
> <frank.li@nxp.com>
> Cc: lorenzo.pieralisi@arm.com; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH v6 1/6] arm64: dts: Add i.MX8MM PCIe EP support
>
> On 20/01/2023 06:25, Richard Zhu wrote:
> > Add i.MX8MM PCIe EP support.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 24
> +++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > index 31f4548f85cf..9662aeccdb3b 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > @@ -1315,6 +1315,30 @@ pcie0: pcie@33800000 {
> > status = "disabled";
> > };
> >
> > + pcie0_ep: pcie_ep@33800000 {
>
> No underscores in node names.
Hi Krzystof:
Thanks for your review comments.
Sorry to reply late, since I'm taking the Spring Festival Vacation in the past days.
Got that. Would be changed later.
>
> > + compatible = "fsl,imx8mm-pcie-ep";
>
> Did you test it with bindings? Does it pass without warnings?
>
>
It's my fault that I'm trying to let fsl,imx6q-pcie.yaml to cover the binding
DT-schema for the Endpoint modes.
One standalone fsl,imx6q-pcie-ep.yaml should be created as DT-schema for i.MX
PCIe Endpoint modes.
I would summit next version a moment later. Please help to review them.
Thanks in advanced.
Best Regards
Richard Zhu
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2023-01-30 2:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 5:25 [PATCH DTS v6 0/6] Add i.MX PCIe EP mode support Richard Zhu
2023-01-20 5:25 ` [PATCH v6 1/6] arm64: dts: Add i.MX8MM PCIe EP support Richard Zhu
2023-01-20 8:07 ` Krzysztof Kozlowski
2023-01-30 2:02 ` Hongxing Zhu [this message]
2023-01-20 5:25 ` [PATCH v6 2/6] arm64: dts: Add i.MX8MM PCIe EP support on EVK board Richard Zhu
2023-01-20 8:08 ` Krzysztof Kozlowski
2023-01-30 2:02 ` Hongxing Zhu
2023-01-20 5:25 ` [PATCH v6 3/6] arm64: dts: Add i.MX8MQ PCIe EP support Richard Zhu
2023-01-20 8:08 ` Krzysztof Kozlowski
2023-01-30 2:03 ` Hongxing Zhu
2023-01-20 5:25 ` [PATCH v6 4/6] arm64: dts: Add i.MX8MQ PCIe EP support on EVK board Richard Zhu
2023-01-20 8:08 ` Krzysztof Kozlowski
2023-01-30 2:04 ` Hongxing Zhu
2023-01-20 5:25 ` [PATCH v6 5/6] arm64: dts: Add i.MX8MP PCIe EP support Richard Zhu
2023-01-20 5:25 ` [PATCH v6 6/6] arm64: dts: Add i.MX8MP PCIe EP support on EVK board Richard Zhu
2023-01-20 8:09 ` Krzysztof Kozlowski
2023-01-30 2:04 ` Hongxing Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR04MB86769DE0BA3D2D077B2EFF378CD39@AS8PR04MB8676.eurprd04.prod.outlook.com \
--to=hongxing.zhu@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=frank.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marcel.ziswiler@toradex.com \
--cc=marex@denx.de \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®