RE: [PATCH 0/3] media: imx8mq-mipi-csi2: Simplify power management handling

["G.N. Zhou (OSS)" <guoniu.zhou@oss.nxp.com>]

Hi Laurent,

> -----Original Message-----
> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Sent: Sunday, September 29, 2024 9:44 PM
> To: rmfrfs@gmail.com; martink@posteo.de; kernel@puri.sm;
> mchehab@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de; festevam@gmail.com
> Cc: G.N. Zhou (OSS) <guoniu.zhou@oss.nxp.com>; imx@lists.linux.dev; linux-
> media@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH 0/3] media: imx8mq-mipi-csi2: Simplify power management
> handling
> 
> Hello,
> 
> This small patch series is a reaction to "[PATCH] media: nxp:
> imx8mq-mipi-csi2: Fix CSI clocks always enabled issue" ([1]). Instead of making
> the PM handling more complex, I think it can be greatly simplified.
> 
> I have only compile-tested the patches. Guoniu, could you give this a try ?

After applying the patches and test both on iMX8ULP.

  For iMX8ULP, it will cause kernel dump when access CSI registers and system hang during do suspend/resume while streaming
  Need to add system suspend/resume handlers and call pm_runtime_force_suspend/resume in the handlers.
  
  I tried to debug this issue and found pm runtime callback won't be called when system resume. The state of power domain won't
  enabled.

> 
> [1] https://lore.kernel.org/r/20240929101635.1648234-1-
> guoniu.zhou@oss.nxp.com
> 
> Laurent Pinchart (3):
>   media: imx8mq-mipi-csi2: Drop stream stop/restart at suspend/resume
>     time
>   media: imx8mq-mipi-csi2: Drop ST_SUSPENDED guard
>   media: imx8mq-mipi-csi2: Drop system suspend/resume handlers
> 
>  drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 113 ++----------------
>  1 file changed, 10 insertions(+), 103 deletions(-)
> 
> 
> base-commit: 81ee62e8d09ee3c7107d11c8bbfd64073ab601ad
> --
> Regards,
> 
> Laurent Pinchart