From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932648AbcESOWV (ORCPT ); Thu, 19 May 2016 10:22:21 -0400 Received: from mail-by2on0131.outbound.protection.outlook.com ([207.46.100.131]:20929 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932234AbcESOWU convert rfc822-to-8bit (ORCPT ); Thu, 19 May 2016 10:22:20 -0400 From: "N, Soumya P" To: Steven Rostedt CC: "mingo@redhat.com" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts. Thread-Topic: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts. Thread-Index: AQHRsBpgsSb/EMl5gk2arryxuHY0rp+/Hf2AgADY5aCAAEiTAIAACffQ Date: Thu, 19 May 2016 13:49:16 +0000 Message-ID: References: <1463500874-77480-1-git-send-email-soumya.p.n@hpe.com> <20160518155433.1631bb23@gandalf.local.home> <20160519091036.44e14667@gandalf.local.home> In-Reply-To: <20160519091036.44e14667@gandalf.local.home> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: goodmis.org; dkim=none (message not signed) header.d=none;goodmis.org; dmarc=none action=none header.from=hpe.com; x-originating-ip: [116.75.105.145] x-ms-office365-filtering-correlation-id: 0fad3074-dd2c-4528-d6b0-08d37fec5e94 x-microsoft-exchange-diagnostics: 1;AT5PR84MB0034;5:j+56HUS7htZuOGv2JAnO3QIC8/TTEaG5Ze6VE7ZfiQjJX33NSRQ9oez3JwjTUd4TOaNPyiATxN3D88Sd3G4VIuXjKwhQYx5us2qWui7WzhmO/0A5o7K8m2syn01qUDrkFF5lepCHvXMokl1A3BcmHw==;24:Iw9a4IZ5UfyvxmMBeEVf1WHwOq9+8dfuvM79Dr7uThQkELtxek9w4nCMVRRuSbBj+P0xf0OVyCG1bzRH3Gtm6x19OXPr3iAlJ5XoCexCWbU=;7:QYOnj37KK9jyL8T4fclM/dmCW2SJ5AjYnp8c6JRdmgIIB5H1kQrVoLkGFUo1wZHB9k/FPmgN5pfak9o2HhgMASRUfstcTKc1zqgA413CowJf79r2EEnPHutC2JlU9bkp7mK+HxhMg5boOmoiUVOqN+7Y3ZbVEs0ZiCHTHc7PvF1Oi+ScFLAtYABmJNwFle3L x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0034; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:AT5PR84MB0034;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0034; x-forefront-prvs: 094700CA91 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(13464003)(24454002)(43544003)(51914003)(110136002)(93886004)(5002640100001)(8676002)(19580395003)(9686002)(189998001)(10400500002)(122556002)(81166006)(5003600100002)(4326007)(5008740100001)(2906002)(8936002)(6116002)(102836003)(3846002)(92566002)(1220700001)(3280700002)(3660700001)(586003)(106116001)(77096005)(99286002)(2950100001)(2900100001)(66066001)(86362001)(19580405001)(50986999)(76176999)(54356999)(11100500001)(5004730100002)(33656002)(87936001);DIR:OUT;SFP:1102;SCL:1;SRVR:AT5PR84MB0034;H:AT5PR84MB0036.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2016 13:49:16.3787 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0034 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steve, Thanks for the explanation. I will take care of your comments and send v2 of the same patch. Thanks, Soumya. -----Original Message----- From: Steven Rostedt [mailto:rostedt@goodmis.org] Sent: Thursday, May 19, 2016 6:41 PM To: N, Soumya P Cc: mingo@redhat.com; linux-kernel@vger.kernel.org Subject: Re: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts. On Thu, 19 May 2016 08:53:17 +0000 "N, Soumya P" wrote: > Hi Steve, > > Could you please explain what this error means? > Is it related to length of subject? > I have run checkpatch.pl on patch and didn't show any error. > > Thanks, > Soumya. > > -----Original Message----- > From: Steven Rostedt [mailto:rostedt@goodmis.org] > Sent: Thursday, May 19, 2016 1:25 AM > To: N, Soumya P > Cc: mingo@redhat.com; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] ftrace: As disabling interrupts is costly and write_lock variant of tasklist_lock is not held from interrupt context it is not necessary to disable interrupts. > > > -ERUNONSUBJECT A subject (and this includes normal net etiquette as well) should be a short description of what the email (or patch) is about, preferably under 80 characters. What you supplied is an abstract. it should have been something as simple as: ftrace: Don't disable interrupts when taking read_lock() for graph tracer And don't rely on checkpatch.pl. Read Documentation/SubmittingPatches in the kernel proper. -- Steve