From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753708AbcD0Q3o (ORCPT ); Wed, 27 Apr 2016 12:29:44 -0400 Received: from mail-bl2on0109.outbound.protection.outlook.com ([65.55.169.109]:51072 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753689AbcD0Q3k convert rfc822-to-8bit (ORCPT ); Wed, 27 Apr 2016 12:29:40 -0400 X-Greylist: delayed 592 seconds by postgrey-1.27 at vger.kernel.org; Wed, 27 Apr 2016 12:29:40 EDT From: "Dall, Betty" To: "Rafael J. Wysocki" CC: "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ACPI/device_sysfs: Add sysfs support for _HRV hardware revision Thread-Topic: [PATCH] ACPI/device_sysfs: Add sysfs support for _HRV hardware revision Thread-Index: AQHRoKAEgScEqgDbwUOsm6w7O7yHbA== Date: Wed, 27 Apr 2016 16:15:30 +0000 Message-ID: References: <1460558894-11971-1-git-send-email-betty.dall@hpe.com> <3691881.pb3S7Il1cr@vostro.rjw.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: rjwysocki.net; dkim=none (message not signed) header.d=none;rjwysocki.net; dmarc=none action=none header.from=hpe.com; x-originating-ip: [15.65.252.14] x-ms-office365-filtering-correlation-id: d4cd9e5f-4346-4aef-3f78-08d36eb72740 x-microsoft-exchange-diagnostics: 1;AT5PR84MB0081;5:1kL7RcAsn+gHgYto/n3jUalOYZWWNJUp4yHwTfLKn6kehQd9ZylLx56pfE3DzbnFyYMkxSoCekq/298KGAG4/wevDTzK+/fK/ZNwGXBbVusUXty3NcLYaT9tZaPSBZ4gDhD/Qenvn1fhy4+z4apEew==;24:7sqsDjbT9t2PYNIrbk7BIeRaQIrCUFximhIPdyUUUO0l53jY7NpwFp6OzPT+/lO9IG0ENoIC0SoZgyH+ty1SErhXV1mEm72zHYW1f0+fI4I=;7:+OJhg/4JUndmrcYoea+WcrepW5CUj4XiD8vZULZdTEQNGhoodIEgTae/o6VA3VVbX7eWUrLAYZlY9LxS4QHzhr0fZM0N7h8/ntqvp9wjCL7Od77Vt/9aTl8gkBvAARF6SDe42SarjFlhtdBa8zVBgL/Rk9GUCbJrHnnV4vd45Qs7E5QKfE04t40nsGsgbJtj x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0081; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(9101521072)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:AT5PR84MB0081;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0081; x-forefront-prvs: 0925081676 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(24454002)(57704003)(3846002)(92566002)(122556002)(77096005)(54356999)(1096002)(2900100001)(76176999)(5004730100002)(2906002)(102836003)(586003)(9686002)(5008740100001)(11100500001)(1220700001)(81166005)(6116002)(33656002)(189998001)(110136002)(87936001)(106116001)(19580395003)(99286002)(19580405001)(66066001)(5002640100001)(10400500002)(5003600100002)(50986999)(4326007);DIR:OUT;SFP:1102;SCL:1;SRVR:AT5PR84MB0081;H:AT5PR84MB0083.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2016 16:15:30.4714 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0081 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/26/2016 02:33 PM, Rafael J. Wysocki wrote: > On Wednesday, April 13, 2016 08:48:14 AM Betty Dall wrote: >> The ACPI _HRV object on the device is used to supply Linux with >> the device's hardware revision. This is an optional object. Add >> sysfs support for the _HRV object if it exists on the device. >> >> Signed-off-by: Betty Dall > > The patch itself looks OK to me, but why exactly do we need that thing in sysfs? > > Thanks, > Rafael > Hi Rafael, I am working on a platform where non-PCI hardware is changing quickly and users want to check what hardware version they are running on. For example, someone checks out a lab system and wants to see if the device is the latest version or if it needs to be updated - they could cat the sysfs hrv file to find the version. It is most useful for non-PCI devices because lspci can list the hardware version for PCI devices; PCI devices in my testing don't supply _HRV. But, there is not an easy solution for non-PCI devices to get the hardware revision from user space with out this hrv sysfs patch. Originally, I added the sysfs hrv to my specific device driver. On review, I thought it would a good improvement for all devices that have an _HRV. Thanks, Betty