From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: <linux-kernel@vger.kernel.org>
Cc: "Andrew Morton" <akpm@osdl.org>
Subject: Redundant unplug_timer deletion
Date: Mon, 1 Mar 2004 13:38:07 -0800 [thread overview]
Message-ID: <B05667366EE6204181EABE9C1B1C0EB501F2AB4D@scsmsx401.sc.intel.com> (raw)
The only path to get to del_timer call in __generic_unplug_device()
is when blk_remove_plug() returns 1, and in that case it already
removed the unplug_timer.
Patch to remove this redundant call.
- Ken
--- linux-2.6.3/drivers/block/ll_rw_blk.c 2004-02-17 19:57:16
+++ linux-2.6.3.blk/drivers/block/ll_rw_blk.c 2004-03-01 13:29:37
@@ -1136,8 +1136,6 @@ static inline void __generic_unplug_devi
if (!blk_remove_plug(q))
return;
- del_timer(&q->unplug_timer);
-
/*
* was plugged, fire request_fn if queue has stuff to do
*/
next reply other threads:[~2004-03-01 21:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-01 21:38 Chen, Kenneth W [this message]
2004-03-01 22:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B05667366EE6204181EABE9C1B1C0EB501F2AB4D@scsmsx401.sc.intel.com \
--to=kenneth.w.chen@intel.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®