From: "Drokin, Oleg" <oleg.drokin@intel.com>
To: Anil Belur <askb23@gmail.com>
Cc: "Dilger, Andreas" <andreas.dilger@intel.com>,
"<gregkh@linuxfoundation.org>" <gregkh@linuxfoundation.org>,
"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>,
"<hpdd-discuss@lists.01.org>" <hpdd-discuss@ml01.01.org>
Subject: Re: [PATCH v3 1/7] staging: lustre: lclient: glimpse.c fixing coding style issues
Date: Mon, 16 Jun 2014 04:55:08 +0000 [thread overview]
Message-ID: <B0C4F83C-ACD6-49D0-B841-DBE1CBE3F5FC@intel.com> (raw)
In-Reply-To: <1402892916-5298-1-git-send-email-askb23@gmail.com>
Hello!
On Jun 16, 2014, at 12:28 AM, Anil Belur wrote:
> From: Anil Belur <askb23@gmail.com>
>
> Fixed "ERROR: need consistent spacing around '+' (ctx:WxV)"
>
> Signed-off-by: Anil Belur <askb23@gmail.com>
> ---
> drivers/staging/lustre/lustre/lclient/glimpse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/lclient/glimpse.c b/drivers/staging/lustre/lustre/lclient/glimpse.c
> index 7bbca4b..60a6e6e 100644
> --- a/drivers/staging/lustre/lustre/lclient/glimpse.c
> +++ b/drivers/staging/lustre/lustre/lclient/glimpse.c
> @@ -177,7 +177,7 @@ static int cl_io_get(struct inode *inode, struct lu_env **envout,
> io->ci_obj = clob;
> *envout = env;
> *ioout = io;
> - result = +1;
> + result = + 1;
This looks wrong.
Here +1 is apparently meant as +1 (compare to -1) to underscore it's positive nature.
If you wanted to drop the +, that'd be fine, I guess, but in your version it looks outright wrong to me (I tested and it compiles, though).
Bye,
Oleg
next prev parent reply other threads:[~2014-06-16 4:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 4:28 Anil Belur
2014-06-16 4:28 ` [PATCH v3 2/7] " Anil Belur
2014-06-16 4:28 ` [PATCH v3 3/7] staging: lustre: lclient: lcommon_misc.c " Anil Belur
2014-06-16 4:28 ` [PATCH v3 4/7] staging: lustre: lclient: lcommon_cl.c " Anil Belur
2014-06-16 4:28 ` [PATCH v3 5/7] " Anil Belur
2014-06-16 4:28 ` [PATCH v3 6/7] " Anil Belur
2014-06-16 4:28 ` [PATCH v3 7/7] " Anil Belur
2014-06-16 5:05 ` Drokin, Oleg
2014-06-16 6:01 ` Anil Shashikumar Belur
2014-06-16 4:55 ` Drokin, Oleg [this message]
2014-06-16 6:01 ` [PATCH v3 1/7] staging: lustre: lclient: glimpse.c " Anil Shashikumar Belur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B0C4F83C-ACD6-49D0-B841-DBE1CBE3F5FC@intel.com \
--to=oleg.drokin@intel.com \
--cc=andreas.dilger@intel.com \
--cc=askb23@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpdd-discuss@ml01.01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®