From: "Zhaolei" <zhaolei@cn.fujitsu.com>
To: "Frederic Weisbecker" <fweisbec@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Cc: "Steven Rostedt" <rostedt@goodmis.org>,
"Ingo Molnar" <mingo@elte.hu>, "Tom Zanussi" <tzanussi@gmail.com>,
"KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>,
"Oleg Nesterov" <oleg@redhat.com>,
"LKML" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] workqueue_trace: Add max execution time mesurementfor per worklet
Date: Thu, 30 Apr 2009 09:10:26 +0800 [thread overview]
Message-ID: <B0DFF0EA5CE64F6683BEDD6641CA20C2@zhaoleiwin> (raw)
In-Reply-To: <20090429133342.GA5987@nowhere>
* From: "Frederic Weisbecker" <fweisbec@gmail.com>
> On Wed, Apr 29, 2009 at 12:06:16AM -0700, Andrew Morton wrote:
>> What is the meaning of M_EXECus? Mean execution time in microseconds,
>> I assume? I wonder if that is sufficiently high resolution nowadays.
>
>
> It's the maximum execution time encountered for a given worklet.
> I also have a small patch, about ready, to get the average.
>
>
>> You'll note that all the functions are reported as "foo+0x0/0xN".
>> There is a way of suppressing the unneeded and unuseful "+0x0/0xN",
>> but I forget what it is and the comments over lib/vsprintf.c:pointer()
>> didn't help. I think it's %pS.
>
>
> I don't know any way to perform this.
> %pF and %pS will act pretty much the same, except:
>
> Extract from lib/vsprintf.c:
>
> * Note: The difference between 'S' and 'F' is that on ia64 and ppc64
> * function pointers are really function descriptors, which contain a
> * pointer to the real address.
>
> But the output formatting is the same: address, offset, size, modname.
>
> I found it a bit annoying, so I proposed the following patch recently:
>
> http://lkml.org/lkml/2009/4/15/310
>
> And someone came with a better idea, IMO:
>
> http://lkml.org/lkml/2009/4/17/105
>
>
>>
>> The patchset adds no user documentation for the feature and should not
>> (IMO) be merged in such a state. Please.
>>
>
>
> Ok, I will try something today about the documentation.
>
> Thanks!
Hello,
To Frederic
Thanks for reply this mail for me.
Your saying is better than me.
To Andrew:
Sorry for replay late, I was rest yesterday.
Frederic's answer is all I wish to say.
Thanks
Zhaolei
>
>
>ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
prev parent reply other threads:[~2009-04-30 1:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 10:51 [PATCH 0/4] workqueue_trace: Add max execution time mesurement for " Zhaolei
2009-04-28 10:52 ` [PATCH 1/4] tracing/workqueue: turn workfunc_stats::inserted into unsigned int Zhaolei
2009-04-28 10:53 ` [PATCH 2/4] tracing/workqueue: Avoid accessing task_struct's member variable in stat file read Zhaolei
2009-04-28 10:54 ` [PATCH 3/4] tracing/workqueue: Use list_for_each_entry instrad of list_for_each_entry_safe in probe_workqueue_destruction() Zhaolei
2009-04-28 10:57 ` [PATCH 4/4] tracing/workqueue: Add max execution time mesurement for per worklet Zhaolei
2009-04-28 17:14 ` Oleg Nesterov
2009-04-30 1:15 ` Zhaolei
2009-04-28 21:53 ` [PATCH 0/4] workqueue_trace: " Frederic Weisbecker
2009-04-29 7:06 ` Andrew Morton
2009-04-29 13:33 ` Frederic Weisbecker
2009-04-29 13:43 ` Steven Rostedt
2009-04-29 13:45 ` Steven Rostedt
2009-04-29 15:36 ` Andrew Morton
2009-04-29 15:49 ` Frederic Weisbecker
2009-04-29 19:10 ` Ingo Molnar
2009-04-30 1:10 ` Zhaolei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B0DFF0EA5CE64F6683BEDD6641CA20C2@zhaoleiwin \
--to=zhaolei@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®