From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011057.outbound.protection.outlook.com [40.93.194.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1BF621FF2E for ; Sat, 13 Jun 2026 19:02:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.57 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781377379; cv=fail; b=I9ZqJS8yAEpXTDgDJGfHASHWBqydurUjOXq80v39sw/uDuNkpbk4MkNXNHo+a3nc1SovjgR0rF5L8RzWwF5Dhm++dxFiqlkJf94ksuc02AZD8Bd43SrNuQbgBhfyibVoRo5TrY1l79UVaBBeawCkg0yL14eDjGmPhCR+SFTUoyU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781377379; c=relaxed/simple; bh=4kPtbFe3RBPjZu7TYgAwZr/3AVJBLuApkhkRK5vjtl4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Rj5hghAUoMmQM9WhOz1jf2iZoRMerGmqpn2l+Vs/dwREWkdqElJD8MvdhGd7yKwM+ywl1QyrZrH3pssUtca2njijSReWUhjJpjv2u506kbp6X2joGPDaDnq4G6EKsU54zNraWWAFeiCttKItOITBPvU5jhdx/0HZDPl1E2ueWsw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=nTUonNl2; arc=fail smtp.client-ip=40.93.194.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="nTUonNl2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E2PEj3Aj0FNgyD/TYsWFb5JbvDMCE1QwLMS9eocZxBM+tyWGjiIODZ020WOysETfgAupNHN6EO88r9oAVjCbv47KP1y6qEOv2J9V3yNKKiEB2ELDWWU9s5g22/Gz3Pj9y/tAZZGSbsUDyw0nJJ89PaKcfS0UlisnqSJRnasC/9UyqGPrwQT8kA60aJUi3NYXUseVlvGgEn+Qoi6X1C4tiMANKQIQR/vb4EftYD0Mvd6U4L2GntzEg2JV1HmXFZfqZApRcm6dnInlmR7W9D1iBawUcENXoh5juj/J+9ofhf9hqsU4AjqizLz/FNX2y/yz3ACRCdRJj9+riJmJwPQDBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CNYLcXDMFTjdGzkTSjwH9Tmy2HQZoEL3/TiyVfh5vy0=; b=k9aFo+adPsMyXIygnjbpyVjnbMbKmy7Ic2QGVO00NiCLTfUK3PKpPESG/LhbEpn317l9gBQ7WI1yyAdOpegTkyXEhuLIZ+KgvndrCKySCJit+El9ReTxfZl7S/Ay8tzD4sJjTBpp75/srdqmeuMcxSgsF8M5ODzW5Gmr3LGAezc3Z8gsYUZdSk0KEpqAQogXmJmO8fF5KzsWsy3zg8CjJYTi9V1zCOQlYco7p63P01sOQ9jXhuiSA5og+xFvvWrU5LkuMuxYY9XQViceqwvb/oVrqTy42gGA8zXApDQI5AtL+nsxagQdgwPJAhP1AyFjBSkITDrSb2L+e7fuIGYDEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CNYLcXDMFTjdGzkTSjwH9Tmy2HQZoEL3/TiyVfh5vy0=; b=nTUonNl2Ui3IVBna6jkvZWXwkvPC8q3La/22rolqjCzsL7Wb6V00K4HE+O7jWLnBdTVoPwDnwNNotj4zHuzFfcbjdkxWqJmN0ML7O0467b5ECWhTTmDnOy4mS1SYwABGRSn0YEXGq5i5N2IAas3QwpcC3XapzWEmxelK0t22kHDxQG+mEgybcyTUw2aoYmoRYDR4LaPW9YD3+OXAHEv60TRXKSQ9jF5TqrZvo21pxiqh15MDH8zHDax5khGyvvTdAMAVv9QtyzV987tnuttduJCpnETlEC30DyLwTrhnPb4a07xsSSsBAWU+9HaA+9cH7rnNGyPpwvhzTURJXRo6Lg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by DM4PR12MB6614.namprd12.prod.outlook.com (2603:10b6:8:bb::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.113.13; Sat, 13 Jun 2026 19:02:52 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%5]) with mapi id 15.21.0113.015; Sat, 13 Jun 2026 19:02:52 +0000 From: Zi Yan To: Usama Arif Cc: Andrew Morton , david@kernel.org, chrisl@kernel.org, kasong@tencent.com, ljs@kernel.org, ying.huang@linux.alibaba.com, Baoquan He , willy@infradead.org, youngjun.park@lge.com, hannes@cmpxchg.org, riel@surriel.com, shakeel.butt@linux.dev, alex@ghiti.fr, kas@kernel.org, baohua@kernel.org, dev.jain@arm.com, baolin.wang@linux.alibaba.com, npache@redhat.com, "Liam R. Howlett" , ryan.roberts@arm.com, Vlastimil Babka , lance.yang@linux.dev, linux-kernel@vger.kernel.org, nphamcs@gmail.com, shikemeng@huaweicloud.com, kernel-team@meta.com Subject: Re: [v2 04/16] mm/huge_memory: move softleaf_to_folio() inside migration branch Date: Sat, 13 Jun 2026 15:02:49 -0400 X-Mailer: MailMate (2.0r6290) Message-ID: In-Reply-To: <20260602142537.198755-5-usama.arif@linux.dev> References: <20260602142537.198755-1-usama.arif@linux.dev> <20260602142537.198755-5-usama.arif@linux.dev> Content-Type: text/plain X-ClientProxiedBy: DS7PR07CA0009.namprd07.prod.outlook.com (2603:10b6:5:3af::9) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|DM4PR12MB6614:EE_ X-MS-Office365-Filtering-Correlation-Id: 82ca4e81-ec9e-41dc-8bd0-08dec97e5ebe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|1800799024|376014|7416014|56012099006|11063799006|4143699003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 6g0Yw8gascEGYKgRe+S+EyGvzeo+z+LFPvFx1mLj5CI+9HyQiOEi/OMwnFscDvBbVXDfMGPyvbzIX7CYeUGsd52kSuONaOyYgLZ8c7Woqh37N/QNNQhwS4cWh2r8BvORAeiMKbtpIUZTBlyFGZA6HJZ7oDIPc+1Jgq0hJg2p9JAmG5VggxmGUeeUSqkmBlI6PVTJi2u2UawWfgG77UZamZv6nx8U0QVIwCjw0xPilxuvCd2tqYmO9Xm16Twqu2Ekn5KtTBPM1brrDVEHmirsLnPzIfmCNtQZMbuxVqLd7/zTk1GXIQjAxyP0VJ3NcOUIi7LlINXucI+7/HMGkd3narJUwf/r5/OxbiRMYJg6SeHhFPKjsFlNRWgPc/j4kzRQSCgyNVokBhQmGE2r8Be4P46NEfQ04pUVcGs+kLepXUhLUYoXkAuRL9s2rJKxe6mitn4q+Vv0mFks3NW5JuJhe38j/DNXPSNd003dBu0BqnTo9BFMxW36DfRgoFOQrtctsvrGLR2XuK+imfj/CBrax9zVNbGXMXXHS/uc7fj4jlS3gqe7SfhDwacYtpwcQ0n1aJ06hRpMB9529uxfzTleTBcVea/yMmlJAa/EKQozPVt0/mnUHnHV/alTL925fzFLV/4zAWW+a5oPw3p9ntUwtUmlNtrPl2ooTcYiCpwTNIYhNcjL7eeWLsxT0Y0m1q3i X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(1800799024)(376014)(7416014)(56012099006)(11063799006)(4143699003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jCut4KYIah+ugXgi3yR5nipgm+9MC4gobvigeVd5pxg5yTemtNpy4r5JJAcN?= =?us-ascii?Q?uNb7JMh8GTA/kpd3u4kYSwR8SSu+G1JfHWuIDVh9jN36jDpOsb8EKIVzv0Y1?= =?us-ascii?Q?nalqhDw5YU64CAgAptE+HEI74h0EO2OTfN165Ry6JG7g5Xu4Seo76kG/dEMM?= =?us-ascii?Q?0NTJa20/8KovnuLYt3ncXONWnk3nfEMXBM0wG8gizGCuAE9BRzjDqki2KHjC?= =?us-ascii?Q?sUjHzahyBSnjzd1lqbwAZfyahCsoR9FDCzDt8N7EGa9C9WgIShL/xCv56Z6e?= =?us-ascii?Q?9u8PwXwFz6WtCmEaTSKMvHomdyJGkQlRUfHvsAqUyJ5znSNsfl457TRBFwnF?= =?us-ascii?Q?Bt2wud6pvcPDxKb+foOFk3ubeizQLRDh33+69qfLkHsqd29+lX4y/3akmSUn?= =?us-ascii?Q?CTJVdUo8bI/UYh+YXOqFQLwSK/JTksKam/4UOYmakWxSigGIvpezjfWO/wGG?= =?us-ascii?Q?nunkOyVtgkdV0QBzlA4qJLes9rebPWXK0tSw+7/3c1YMnHlZwJ9xxg5f5WQ0?= =?us-ascii?Q?Y9HxPdBpb6KMLHDwVJSRkYjsCILrNxUjoRrCw4UJ3yWpIqLg8mnZwOx6RMKR?= =?us-ascii?Q?ECaV+5FBBVL4oXRK65tAlaFL8ia1jdPFiAQCsblAezUvqBf8iYduOgnnGV4I?= =?us-ascii?Q?6cIDMwb9c5gr/jOZr+kJBfvSGuO0YkuKV1HJdsOj4/RM/Qa/CgJE/jVyduIh?= =?us-ascii?Q?aXYHzlt/w3usDi799XYbcKAmDHxMGcPJFpmP9A3UF5xQnW7PKTqKgaWywFBa?= =?us-ascii?Q?lLxSKvHRV/zLGU4SGaTlPWI+u8Ofkpv+18dsrVaNdwFG9XhSWRySyj4rKcIA?= =?us-ascii?Q?OOkWEmIZh/fufNpCGq9hM/JB4UlJZhZwuD5tggrkrfNgX54ZfiSZIjl+OGuS?= =?us-ascii?Q?g7pZyXMRnViH1gfX5tLfB4nQ9Eq8Sn5+WbYjll9/ZL4rDb1qvh82VQ391Q9z?= =?us-ascii?Q?9YEUsYRQdj/OHYzWcou1pANBE53+FqmYmFoGlvGn7OBqnJxKxNqcGIrQcmfZ?= =?us-ascii?Q?LuFkHrCQfTbcABJIqlBysup4i7PVCITCl1z3JVp521TcU/9OEl+xFLO7fgPZ?= =?us-ascii?Q?pPiHzDfWSEWuQJD7wDwbGHqHXkGbcSsafvu6TC9QVhEwS/8gJpfxkCZwFK8s?= =?us-ascii?Q?h81ZP5D3/hKlYhrPOqJ+drvxlIEvuWJNL791rd646XoyUny97lqc2GA0Gf97?= =?us-ascii?Q?EIIqhgcmtT2jn3M2zDthht9xD/+Yv2iOsOZIv3PklzpF6lvVyYa0DZc82FfV?= =?us-ascii?Q?aLzukP2Ta9ELXT/dMY0Ytl6lPmxQ3g0nM70VrmljQN+s9HNIjAIYCqPYJNLu?= =?us-ascii?Q?TT5PfhLqaCQHLVDDlfAOkaABqRz72VCg8xg0LvcIvgkZSzZ4am4uDtru1HIc?= =?us-ascii?Q?gHJmDNm4tDCzXClj7GQmAto+wMWVQGEBrTwQUT8OcoU74aL1axrXLL7VI2Sb?= =?us-ascii?Q?HFf4DOw0ZSpL5Agd73Ptx6FpUDRu0aYtiiHk9EA08Q+HRza1axgltv/qmBxN?= =?us-ascii?Q?ctup3b9B0SSHiseL9HJ7WeZi6jtlXwP+3oK+sYKg7+8gSBSasI59k9U8SOiR?= =?us-ascii?Q?0xchrXNONmAzeAqRiYnmO6idzcJxth4y+AqCZxpUTgl8RgY+kRE+Hv/a3zD6?= =?us-ascii?Q?2RhCtBBV+oJLCXrEzhRG+hJZdCbd+hkO16aVb4R8KdGiSJt9f9xmfG1302Ku?= =?us-ascii?Q?M4Xhiv3SPRKzbjdtsWbwCK3X3axICBqXdYG+W/O2EXuXj6kf?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82ca4e81-ec9e-41dc-8bd0-08dec97e5ebe X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2026 19:02:52.6547 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZPkn2ok3iAatsexAThK9zh8NI71CIsNO7XOt8ybB/MknwHa2eJCPOAQB/aAULxly X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6614 On 2 Jun 2026, at 10:24, Usama Arif wrote: > change_non_present_huge_pmd() calls softleaf_to_folio() unconditionally > at the top of the function. softleaf_to_folio() extracts a PFN from > the entry and converts it to a folio pointer, which is only meaningful > for migration and device_private entries that encode a real PFN. > > A swap entry encodes a swap offset instead, so softleaf_to_folio() > would produce a bogus pointer and crash on mprotect() when a PMD swap > entry is present. > > Move the call into the migration_write branch where the folio is > actually used, so the function is safe for any non-present PMD type. > > Acked-by: David Hildenbrand (Arm) > Reviewed-by: Dev Jain > Signed-off-by: Usama Arif > --- > mm/huge_memory.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > LGTM. Reviewed-by: Zi Yan -- Best Regards, Yan, Zi