From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762871AbdJQOcE (ORCPT ); Tue, 17 Oct 2017 10:32:04 -0400 Received: from mga03.intel.com ([134.134.136.65]:55019 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753970AbdJQOcB (ORCPT ); Tue, 17 Oct 2017 10:32:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,391,1503385200"; d="scan'208";a="139289831" From: "Duyck, Alexander H" To: Eric Dumazet , Henrik Austad CC: netdev , "David S . Miller" , Daniel Borkmann , David Ahern , Willem de Bruijn , John Fastabend , tcharding , LKML , Henrik Austad , "Sanchez-Palencia, Jesus" Subject: RE: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to compile as module Thread-Topic: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to compile as module Thread-Index: AQHTRzAuc2EYoOzPjUWD7YBDDveZ5aLoWxoA//+/JMA= Date: Tue, 17 Oct 2017 14:31:59 +0000 Message-ID: References: <1508235010-4056-1-git-send-email-haustad@cisco.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDA3OWM1YTItYWE1Ni00MjBiLWEwNWQtM2RlNDgyMjkzMmYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Imt3UVliYm55N3RUZ3JQaGkwVWErS1NnM2Z5citJSUl0d1wvSlwvRVVTbDUzWT0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9HEW8AB024788 > -----Original Message----- > From: Eric Dumazet [mailto:edumazet@google.com] > Sent: Tuesday, October 17, 2017 4:21 AM > To: Henrik Austad > Cc: netdev ; David S . Miller > ; Daniel Borkmann ; David > Ahern ; Duyck, Alexander H > ; Willem de Bruijn ; > John Fastabend ; tcharding ; LKML > ; Henrik Austad ; Sanchez- > Palencia, Jesus > Subject: Re: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to > compile as module > > On Tue, Oct 17, 2017 at 3:10 AM, Henrik Austad wrote: > > In commit 32302902ff09 ("mqprio: Reserve last 32 classid values for HW > > traffic classes and misc IDs") sch_mqprio started using > > netdev_txq_to_tc to find the correct tc instead of dev->tc_to_txq[] > > > > However, when mqprio is compiled as a module, it cannot resolve the > > symbol, leading to this error: > > > > ERROR: "netdev_txq_to_tc" [net/sched/sch_mqprio.ko] undefined! > > > > This adds an EXPORT_SYMBOL() since the other user in the kernel > > (netif_set_xps_queue) is also EXPORT_SYMBOL() (and not _GPL) or in a > > sysfs-callback. > > > > Cc: Alexander Duyck > > Cc: Jesus Sanchez-Palencia > > Cc: David S. Miller > > Signed-off-by: Henrik Austad > > > Reviewed-by: Eric Dumazet This is identical to a patch I submitted yesterday when I got the report from the kbuild robot. I would say your description looks much better than mine though so I would be good with dropping my patch in favor of this one. Acked-by: Alexander Duyck