From: Marcel Holtmann <marcel@holtmann.org>
To: Alexander Aring <alex.aring@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>,
linux-wpan@vger.kernel.org,
Network Development <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
ldv-project@linuxtesting.org
Subject: Re: [PATCH] ieee802154: fix error handling in ieee802154fake_probe()
Date: Sat, 15 Nov 2014 16:58:28 +0900 [thread overview]
Message-ID: <B1D43522-B042-4D92-8F8A-D2AD89A3F0F9@holtmann.org> (raw)
In-Reply-To: <20141115071603.GA3481@omega>
Hi Alex,
>> In case of any failure ieee802154fake_probe() just calls unregister_netdev().
>> But it does not look safe to unregister netdevice before it was registered.
>>
>> The patch implements straightforward resource deallocation in case of
>> failure in ieee802154fake_probe().
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
>>
>
> Thanks for the patch! But I already delete the whole fakehard driver.
> The patch to remove this driver is already in net-next.
>
> There was too many issues with the fake hardMAC drivers and we don't
> really supported a "real" hardMAC transceiver. For my rework to grab the
> good things from wireless implementation and put 802.15.4 functionality
> on it I simple delete the whole driver and _maybe_ add a new one with
> the new introduced interfaces for possible hardMAC functionality.
>
> This patch could go into bluetooth(net)/stable but I don't think that
> there are many users for this driver.
I am not sure that this is worth it then.
Dave, do you want to just take it via net-stable tree? We currently have no urgent bluetooth-stable tree patches pending.
Regards
Marcel
next prev parent reply other threads:[~2014-11-15 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 23:11 Alexey Khoroshilov
2014-11-15 7:16 ` Alexander Aring
2014-11-15 7:58 ` Marcel Holtmann [this message]
2014-11-16 19:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B1D43522-B042-4D92-8F8A-D2AD89A3F0F9@holtmann.org \
--to=marcel@holtmann.org \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=khoroshilov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®