mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Edward Goggin <egoggin@vmware.com>
To: "'Ingo Molnar'" <mingo@elte.hu>
Cc: "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
Subject: RE: Simple typo in reboot.c when enabling CONFIG_KDB_KDUMP
Date: Wed, 29 Apr 2009 06:15:47 -0700	[thread overview]
Message-ID: <B1FD1A0C73AC4E46A4F95BADC77079D35F55F115@PA-EXMBX02.vmware.com> (raw)
In-Reply-To: <20090429053233.GB4103@elte.hu>

Good point.  Its after applying a KDB patch from SGI.  I'll submit
the patch to Keith Owens at SGI intead. 

> -----Original Message-----
> From: Ingo Molnar [mailto:mingo@elte.hu] 
> Sent: Wednesday, April 29, 2009 1:33 AM
> To: Edward Goggin
> Cc: 'linux-kernel@vger.kernel.org'
> Subject: Re: Simple typo in reboot.c when enabling CONFIG_KDB_KDUMP
> 
> 
> * Edward Goggin <egoggin@vmware.com> wrote:
> 
> > Patch 1 of 1
> > 
> > Simple typo when enabling CONFIG_KDB_KDUMP.
> > 
> > Signed-off-by: Ed Goggin <egoggin@vmware.com>
> > 
> > 
> > --- linux-2.6.29/arch/x86/kernel/reboot.c	2009-04-28 
> 14:37:30.000000000 -0400
> > +++ linux-2.6.29.fix/arch/x86/kernel/./reboot.c	
> 2009-04-28 14:37:37.000000000 -0400
> > @@ -649,7 +649,7 @@ void halt_current_cpu(struct pt_regs 
> *re  #ifdef 
> > CONFIG_X86_32
> >  	if (!user_mode_vm(regs)) {
> >  		crash_fixup_ss_esp(&fixed_regs, regs);
> > -		regs = &fixed_Regs;
> > +		regs = &fixed_regs;
> >  	}
> >  #endif
> >          crash_save_cpu(regs, raw_smp_processor_id());
> 
> There's no such code in the current upstream kernel. Exactly 
> which kernel version (sha1) are you sending a patch against?
> 
> 	Ingo
> 

      reply	other threads:[~2009-04-29 13:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28 21:33 Edward Goggin
2009-04-29  5:32 ` Ingo Molnar
2009-04-29 13:15   ` Edward Goggin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B1FD1A0C73AC4E46A4F95BADC77079D35F55F115@PA-EXMBX02.vmware.com \
    --to=egoggin@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®