From: Nick Terrell <terrelln@fb.com>
To: "torvic9@mailbox.org" <torvic9@mailbox.org>
Cc: "Piotr Górski" <lucjan.lucjanov@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
"masahiroy@kernel.org" <masahiroy@kernel.org>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
"michal.lkml@markovi.net" <michal.lkml@markovi.net>
Subject: Re: [PATCH] init: add support for zstd compressed modules
Date: Thu, 1 Apr 2021 19:18:24 +0000 [thread overview]
Message-ID: <B25BE8E0-14AE-44EA-9A30-F6FED2B6567F@fb.com> (raw)
In-Reply-To: <722602000.5829.1617263646814@office.mailbox.org>
> On Apr 1, 2021, at 12:54 AM, torvic9@mailbox.org wrote:
>
> Thanks Piotr, good work!
> Question: Is `-T0` really faster in this particular case than the default `-T1`? Are modules installed sequentially?
The zstd CLI produces deterministic output regardless of the number of threads used. `-T1` (or not specifying `-T`) will produce the same output as `-T0`. `-T0` will be faster for large files (at the default level, multiple jobs will be spawned for files > 8MB), and be just as fast as `-T1` for smaller files.
Best,
Nick
> I also saw that Masahiro did some work on modules_install, moving MODULE_COMPRESS from the base Makefile to scripts/Makefile.modinst, so perhaps this should also be moved there at a later point.
>
> Tor Vic
next prev parent reply other threads:[~2021-04-01 19:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <722602000.5829.1617263646814@office.mailbox.org>
2021-04-01 8:01 ` torvic9
2021-04-01 19:18 ` Nick Terrell [this message]
2021-03-30 11:32 Piotr Gorski
2021-03-30 11:50 ` Oleksandr Natalenko
2021-03-31 17:39 ` Nick Terrell
2021-03-31 17:48 ` Oleksandr Natalenko
2021-03-31 19:21 ` Nick Terrell
2021-03-31 20:28 ` Oleksandr Natalenko
2021-04-07 13:53 ` Masahiro Yamada
2021-04-07 17:45 ` Nick Terrell
2021-04-07 14:32 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B25BE8E0-14AE-44EA-9A30-F6FED2B6567F@fb.com \
--to=terrelln@fb.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucjan.lucjanov@gmail.com \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=oleksandr@natalenko.name \
--cc=torvic9@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®