From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932499AbaCQGBn (ORCPT ); Mon, 17 Mar 2014 02:01:43 -0400 Received: from rtits2.realtek.com ([60.250.210.242]:54039 "EHLO rtits2.realtek.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753304AbaCQGBk (ORCPT ); Mon, 17 Mar 2014 02:01:40 -0400 X-SpamFilter-By: BOX Solutions SpamTrap 5.39 with qID s2H61NkK013827, This message is accepted by code: ctloc85258 From: hayeswang To: "'David Miller'" CC: , , , , References: <20140314.000741.1829674011496195593.davem@davemloft.net> <20140314.144311.2001561184461945910.davem@davemloft.net> Subject: RE: [PATCH net-next v3 1/2]r8152:addRTL8152_EARLY_AGG_TIMEOUT_SUPER Date: Mon, 17 Mar 2014 14:01:23 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <20140314.144311.2001561184461945910.davem@davemloft.net> Thread-Index: Ac8/tUI90ZeD04/XTjSpIs1NSTcyKQB8DH6A X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Originating-IP: [172.21.71.143] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Miller [mailto:davem@davemloft.net] > Sent: Saturday, March 15, 2014 2:43 AM [...] > > Besides, I don't wish to modify the setting by ethtool when re-loading > > the driver or rebooting every time. > > You have code to reset the driver, you can do it when the user asks > for the setting to be changed via ethtool. I do not see this as > a problem. > > The ethtool change can occur while the driver is already up, you'll > just need to reset the chip and make the new configuration, this is > not a problem. Thanks for your answer. I would study how to set it by ethtool. Best Regards, Hayes