From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <tom.leiming@gmail.com>
Cc: "Jörg-Volker Peetz" <jvpeetz@web.de>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Christoph Hellwig" <hch@lst.de>
Subject: Re: [PATCH next 3/4] blk-mq: user (1 << order) to implement order_to_size()
Date: Fri, 18 Apr 2014 22:05:04 -0700 [thread overview]
Message-ID: <B2C4D47E-30F0-4CC3-B3AD-22C791F61614@kernel.dk> (raw)
In-Reply-To: <CACVXFVMZ0LmpkYk5+-4yyosapzUp+te4txFq3iO09PpGKEXWRA@mail.gmail.com>
On Apr 18, 2014, at 8:17 PM, Ming Lei <tom.leiming@gmail.com> wrote:
>
>> On Sat, Apr 19, 2014 at 3:23 AM, Jörg-Volker Peetz <jvpeetz@web.de> wrote:
>>
>> Testing this with gcc 4.8.2 with order > 30 confirms that the automatic casting
>> is done operator-wise and the explicit casting is necessary.
>
> My gcc 4.8.2 doesn't complain the change, see below:
It won't complain, but that doesn't mean that it won't get it wrong. The cast is necessary.
next prev parent reply other threads:[~2014-04-19 5:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 15:49 [PATCH next 0/4] blk-mq: misc changes Ming Lei
2014-04-17 15:49 ` [PATCH next 1/4] blk-mq: free hctx->ctx_map when init failed Ming Lei
2014-04-18 14:21 ` Christoph Hellwig
2014-04-17 15:49 ` [PATCH next 2/4] blk-mq: fix allocation of set->tags Ming Lei
2014-04-18 14:22 ` Christoph Hellwig
2014-04-17 15:49 ` [PATCH next 3/4] blk-mq: user (1 << order) to implement order_to_size() Ming Lei
2014-04-17 19:03 ` Jörg-Volker Peetz
2014-04-17 19:13 ` Max Filippov
2014-04-18 15:47 ` Ming Lei
2014-04-18 19:23 ` Jörg-Volker Peetz
2014-04-19 3:17 ` Ming Lei
2014-04-19 5:05 ` Jens Axboe [this message]
2014-04-17 15:49 ` [PATCH next 4/4] blk-mq: initialize req->q in allocation Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B2C4D47E-30F0-4CC3-B3AD-22C791F61614@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jvpeetz@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®