From: hayeswang <hayeswang@realtek.com>
To: "'Francois Romieu'" <romieu@fr.zoreil.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next 1/5] r8169: modify pll power function
Date: Wed, 28 Mar 2012 10:52:24 +0800 [thread overview]
Message-ID: <B353B7C4530143B29686566C4F883487@realtek.com.tw> (raw)
In-Reply-To: <20120327225407.GB22177@electric-eye.fr.zoreil.com>
Francois Romieu [mailto:romieu@fr.zoreil.com]
> Sent: Wednesday, March 28, 2012 6:54 AM
> To: Hayeswang
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next 1/5] r8169: modify pll power function
>
> Hayes Wang <hayeswang@realtek.com> :
> > Adjust r810x_pll_power_down, r810x_pll_power_up, and
> r8168_pll_power_up.
> > Always power up device during rtl_open.
> > For r810x, turn off more power when the WOL is disabled.
>
> Would the "Always power up" part qualify as a "fix something" change ?
>
I don't see any issue about this yet. It seems to be reasonable to make suer the
device would work when the open is called no matter the power is turned off
before or not.
Best Regards,
Hayes
prev parent reply other threads:[~2012-03-28 2:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 7:53 Hayes Wang
2012-03-27 7:53 ` [PATCH net-next 2/5] r8169: add csi_opt Hayes Wang
2012-03-27 22:54 ` Francois Romieu
2012-03-28 2:52 ` hayeswang
2012-03-27 7:53 ` [PATCH net-next 3/5] r8169: support RTL8402 Hayes Wang
2012-03-27 7:53 ` [PATCH net-next 4/5] r8169: adjust some functions of 8111f Hayes Wang
2012-03-27 7:53 ` [PATCH net-next 5/5] r8169: support RTL8411 Hayes Wang
2012-03-27 22:54 ` Francois Romieu
2012-03-28 2:52 ` hayeswang
2012-03-27 22:54 ` [PATCH net-next 1/5] r8169: modify pll power function Francois Romieu
2012-03-28 2:52 ` hayeswang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B353B7C4530143B29686566C4F883487@realtek.com.tw \
--to=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®