From: Paul Cercueil <paul@crapouillou.net>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v4 2/2] MIPS: ingenic: Enable JZ4780_NEMC manually
Date: Tue, 28 Jul 2020 13:12:11 +0200 [thread overview]
Message-ID: <B4F6EQ.WB2WZOY40FDR@crapouillou.net> (raw)
In-Reply-To: <20200728104503.23655-2-krzk@kernel.org>
Hi Krzysztof,
Le mar. 28 juil. 2020 à 12:45, Krzysztof Kozlowski <krzk@kernel.org> a
écrit :
> The CONFIG_JZ4780_NEMC was previously a default on MIPS but now it has
> to be enabled manually.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
I think you should swap the two so that there are no problems when
bisecting.
With that:
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
Cheers,
-Paul
>
> ---
>
> Changes since v3:
> 1. New patch
> ---
> arch/mips/configs/ci20_defconfig | 1 +
> arch/mips/configs/qi_lb60_defconfig | 1 +
> arch/mips/configs/rs90_defconfig | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/arch/mips/configs/ci20_defconfig
> b/arch/mips/configs/ci20_defconfig
> index e511fe0243a5..0a46199fdc3f 100644
> --- a/arch/mips/configs/ci20_defconfig
> +++ b/arch/mips/configs/ci20_defconfig
> @@ -128,6 +128,7 @@ CONFIG_DMA_JZ4780=y
> CONFIG_INGENIC_OST=y
> # CONFIG_IOMMU_SUPPORT is not set
> CONFIG_MEMORY=y
> +CONFIG_JZ4780_NEMC=y
> CONFIG_PWM=y
> CONFIG_PWM_JZ4740=m
> CONFIG_EXT4_FS=y
> diff --git a/arch/mips/configs/qi_lb60_defconfig
> b/arch/mips/configs/qi_lb60_defconfig
> index 97c9a69d1528..81bfbee72b0c 100644
> --- a/arch/mips/configs/qi_lb60_defconfig
> +++ b/arch/mips/configs/qi_lb60_defconfig
> @@ -108,6 +108,7 @@ CONFIG_RTC_DRV_JZ4740=y
> CONFIG_DMADEVICES=y
> CONFIG_DMA_JZ4780=y
> CONFIG_MEMORY=y
> +CONFIG_JZ4780_NEMC=y
> CONFIG_IIO=y
> CONFIG_INGENIC_ADC=y
> CONFIG_PWM=y
> diff --git a/arch/mips/configs/rs90_defconfig
> b/arch/mips/configs/rs90_defconfig
> index 433ac5c0266a..de6752051ecc 100644
> --- a/arch/mips/configs/rs90_defconfig
> +++ b/arch/mips/configs/rs90_defconfig
> @@ -145,6 +145,7 @@ CONFIG_DMA_JZ4780=y
> CONFIG_INGENIC_OST=y
> # CONFIG_IOMMU_SUPPORT is not set
> CONFIG_MEMORY=y
> +CONFIG_JZ4780_NEMC=y
> CONFIG_IIO=y
> CONFIG_INGENIC_ADC=y
> CONFIG_IIO_RESCALE=y
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-07-28 11:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 10:45 [PATCH v4 1/2] memory: jz4780-nemc: Do not build by default Krzysztof Kozlowski
2020-07-28 10:45 ` [PATCH v4 2/2] MIPS: ingenic: Enable JZ4780_NEMC manually Krzysztof Kozlowski
2020-07-28 11:12 ` Paul Cercueil [this message]
2020-07-28 11:19 ` Krzysztof Kozlowski
2020-07-28 11:37 ` Thomas Bogendoerfer
2020-07-28 12:00 ` Krzysztof Kozlowski
2020-07-28 12:33 ` Thomas Bogendoerfer
2020-07-28 12:51 ` Paul Cercueil
2020-07-28 12:53 ` Krzysztof Kozlowski
2020-07-28 20:51 ` Thomas Bogendoerfer
2020-07-28 11:36 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B4F6EQ.WB2WZOY40FDR@crapouillou.net \
--to=paul@crapouillou.net \
--cc=arnd@arndb.de \
--cc=hns@goldelico.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome